Jump to content

Welcome, Guest!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Traumflug

Administrators
  • Content Count

    1,392
  • Joined

  • Last visited

  • Days Won

    44

Everything posted by Traumflug

  1. Traumflug

    Broken images

    @Occam, please use PS 1.6. Or better PS 1.5. There is all the broken code you desire so much.
  2. Traumflug

    Broken images

    Excellent!
  3. Traumflug

    Broken images

    No worries, this is for developers understanding how fallbacks work.
  4. Traumflug

    Broken images

    Dealing with this class of retrocompatibility would mean to try not only with appending _default, but also with removing this part of the name, right?
  5. Traumflug

    Broken images

    I see it now. The obvious quick fix is to change this name in the template. views/templates/hook/blocknewproducts.tpl, line 33. Names for image sizes were changed already.
  6. Traumflug

    Broken images

    Not sure which pull request you're talking about. I think the best solution is to let the module search available image types for the best match to the desired size. Another approach would be to let the module register it's own image type. This should reasonably work for all themes and arbitrary image names, then.
  7. Traumflug

    Broken images

    For a start-up like thirty bees a statement like that sounds pretty presumptuous. Shouldn't thirty bees remain compatible for now? thirty bees' message isn't to stick in the 1990's. thirty bees' message is to fix bugs. That's what happened. Sometimes fixing one bug exposes another bug. In such cases the right thing is not to revert the bugfix, but to fix the other bug as well.
  8. Traumflug

    Broken images

    Jungle drums say, Google still ranks layouts with exactly matching image sizes higher than those using one downloaded image for all these small representations/icons. If you changed your theme to get away with fewer image types, don't hesitate to remove the no longer needed ones from the list. Bonus points for also removing them from the theme's config.xml (which gets read at theme installation time, only).
  9. Traumflug

    Broken images

    It simply shouldn't matter which image type names a theme uses. There's a database table storing these image types and the whole point of this table is to allow changing these names. A theme can define any image type name it feels a need for. This was "always" the case. Since 1.1.0, the theme name gets prefixed to this image type name. Code for this was also "always" there, it was just entirely broken. With this code being fixed, thirty bees allows now distinct image types in distinct themes. thirty bees features multishop, each shop can have a different theme and each theme can have its own idea of image sizes. Image type 'home' in theme 1 can have an entire different size than image type 'home' in theme 2, after all. And then there are modules entirely ignoring all this and hardcoding image names, as if there was always just one shop, just one theme and this theme always had defined image types the module wants. A static world view, just like 1990. Care was taken of these hardcoded image types as well, of course. Requests for images not existing on disk get forwarded to PageNotFoundController, which then tries to find the best match actually existing. Last resort of this controller is to send this camera image, so in the case discussed here it apparently gets activated as expected. Apparently there's a situation possible where the fallback mechanism doesn't find what it could find. Debugging can start in these two locations: https://github.com/thirtybees/thirtybees/blob/1.1.x/controllers/front/PageNotFoundController.php#L57 https://github.com/thirtybees/thirtybees/blob/1.1.x/classes/ImageType.php#L241
  10. Traumflug

    Multiplefeatures?

    thirty bees has no kernel an never publishes release dates.
  11. Mauro found two glitches in the code: https://github.com/thirtybees/thirtybees/pull/1043 Cheers to him!
  12. Does it continue to work if you turn the cache back on? Or don't turn it off, just reload the page using the reload button? It might be a stale tools.js, which would be a one-time problem.
  13. Yupp, sieht nach einem Problem im Theme aus. Beim alten Theme klappen die Klicks auch nur, wenn man direkt auf den kleinen Kreis klickt. Auf den Text daneben klicken reicht nicht. thirty bees 1.1.0 kann übrigens auch das alte Theme. Einfach unter Voreinstellungen -> Themes umstellen.
  14. "Blutige Liebe". That's how it got translated to German 🙂
  15. This sounds like a bug where the variable for price rounding precision is missing/empty/forgotten. Filed here: https://github.com/thirtybees/thirtybees/issues/1044
  16. Uhm, what is the point of doing this? Updating v1.0.8 to v1.1.0 is pretty simple and straightforward.
  17. The nice thing about the newer updater is, one can reverse updates. If the newer version doesn't work out, just do this, "update" from 1.1.0 back to 1.0.4.
  18. https://github.com/thirtybees/thirtybees/issues/1031
  19. It should work. If not, it's a bug.
  20. Them saying this can well mean "we didn't even try". Quite a number of PS developers apparently fear new customers using thirty bees. For hardly imaginable reasons, because thirty bees is as compatible as another software can be, sometimes even more compatible than PS its self.
  21. Do you need module "cheque"? If not, uninstall and delete it. Uninstalling and deleting unused modules is generally a good idea. This brings a small, but existing performance advantage over just disabling it.
  22. I think that's called updating and yes, there is a module, of course. It's called "Core Updater" and available in the list of modules in your back office.
×
×
  • Create New...