Jump to content

Welcome, Guest!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Traumflug

Administrators
  • Content Count

    1,392
  • Joined

  • Last visited

  • Days Won

    44

Everything posted by Traumflug

  1. Traumflug

    Carrier API

    Get a better module. APIs can be fast, request results can get cached. Sorry, can't say something better.
  2. A database query returning no results returns boolean 'false', not an empty array. This worked fine before PHP 7.2. Changing this line: if (count($subscribe_products > 0)) to this if ($subscribe_products) should do the trick.
  3. Unless you're prepared to learn Git command line stuff, the best bet is to use Core Updater, the Bleeding Edge versions. Core Updater follows the repository on Github closely and gets updated automatically; each commit to the Github repository arrives there a couple of minutes later. It's designed behave this way and get used like this. This also means: version 1.1.x there as of today isn't the same as 1.1.x last week or next week.
  4. Well, having no nofollow adds ranking to the page one links to, not the own page. If a couple of shops do this, the linked product page will have a higher ranking than the shop, which is usually not what merchants want.
  5. The leftmost button in the TinyMCE editor reads "Source Code". Click that and you get a source code editor, without any WYSIWYG. One can also switch back and forth between these two views.
  6. I'd start with some trivial HTML to see whether the module rejects HTML in general or if there's something wrong with the code you paste. Trivial HTML would be <div></div>.
  7. Traumflug

    Rounding

    That's not intended, there are currencies which actually want no digits after the decimal. Still glad to see this "misbehavior" matches what you want.
  8. Thanks. It's on branch 1.1.x now, you can use Core Updater to get it.
  9. Traumflug

    Rounding

    Well, "Number of decimals" rounds to the given decimals, but also doesn't display additional ones. For example, rounding to full Euros works, but also displays it as € 123 rather than € 123.00. I'm pretty sure one could add some CSS to always add .00 to prices.
  10. Nice catch. That's when attempting to edit a product in an order in back office, bottommost panel, right? I'm just curious how you managed to get this error message, I don't get it. Which kind of PHP is this? Anyways, this small patch should fix it: diff --git a/controllers/admin/AdminOrdersController.php b/controllers/admin/AdminOrdersController.php index b04f824fb9..100813972a 100644 --- a/controllers/admin/AdminOrdersController.php +++ b/controllers/admin/AdminOrdersController.php @@ -2710,7 +2710,7 @@ class AdminOrdersControllerCore extends AdminController } $decimals = 0; - if ($currency->decimals) { + if ($this->context->currency->decimals) { $decimals = Configuration::get('PS_PRICE_DISPLAY_PRECISION'); } $this->ajaxDie(json_encode([
  11. Not sure whether this is a good idea. NoCaptchaRecaptcha and nocaptcharecaptcha are two distinct modules, one can have both installed. Any attempt to deviate from the name of the directory on disk might well lead to unexpected behavior in other places.
  12. It'd be pretty complicated to find a precise logic on how to apply such discounts. Where to apply it and where not. Hence the usual solution is to apply discounts either to a single product only, or to the order total.
  13. PHP code does quite a number of decisions based on the host name given. To get it working with an IP, at very least Preferences -> SEO & URLs -> Shop domain needs adjustment. Put the IP into there and into SSL domain. In case you wonder why thirty bees doesn't figure this automatically: these redirects are needed for multishop, for redirecton HTTP -> HTTPS and such stuff. There are a number of cases where these redirections make sense.
  14. That's intentional, because on small screens, large text would cover the whole image or not even fit on the screen. It's the 'hidden-xs' here: https://github.com/thirtybees/niara/blob/master/modules/homeslider/homeslider.tpl#L18
  15. IIRC it's like 5 images per request. This should be enough proof for the conclusion that there's something wrong with this image. I'd open it in GIMP, export it into a new file and try again.
  16. Maybe you miss that missing images get generated on the fly. Just request them, e.g. by visiting the product page, and they're there.
  17. Such generic images should come from img/l/.
  18. This obviously depends on how this other module hides the first module. However, the way you describe it, it makes no sense to have one module to add currencies, and another module to revert this. Removing both module sounds more logical.
  19. Since about a year, these do get removed by the migration module. https://github.com/thirtybees/psonesixmigrator/blob/master/classes/AjaxProcessor.php#L878-L880
  20. Let me repeat: XML files aren't executable, so no threat. Which means, delete them or don't, it doesn't matter.
  21. 2 hours ago, piet said: What about TB? That's pretty simple to answer. According to the document, vulnerable modules are: autoupdater (confirmed) gamification (perhaps) pscartabandonmentpro (third party) ps_facetedsearch (third party) None of these modules ship with thirty bees. To find more candidates and confirm a safe state, search for folders with the name 'phpunit'. There should be none and if there is any, delete it with all its content. Code in there is needed for code development, only. Command line for those who have shell access: find . -type d | grep -i phpunit Run this in the shop's root folder, it should create no output.
  22. Overrides sind selten eine gute Idee. An der markierten Stelle drängt sich doch geradezu ein Hook auf. Wie der, der auch die Symbole für die Kreditkarten anzeigt.
  23. My impression is, thirty bees could implement everything imaginable and people would still lament about "not moving anywhere". Actually, that's a situation I didn't expect when picking up work for thirty bees. About everywhere else, derived/forked projects are seen as pretty much equivalent to the former version. OpenOffice moved smoothly to LibreOffice, people happily tried ecgs-gcc in besides or favor of gcc, MariaDB is welcome for MySQL users, Ubuntu comes with a whole lot of derivatives, Ubuntu its self is a fork of Debian and very popular, and so on. In general forks are seen as an enrichment of the choices one can make rather than kind of a threat. Something is different with merchants.
×
×
  • Create New...