white space phone number

[SLiCK_303]

When creating a new address, we can save it into the DB even the phone number is just a whitespace.

To test: BO > Customers > Addresses > Set required fields for this section > make the phone required, FO > Sign in > My addresses > Add a new address > fill the phone number with whitespace and "Save", check if the error message is displayed.

The following almost fixes it, it makes it so you can't just put in a space, but doesn't fix the fact when you put in a space, goto a different field, the phone # field you just put a space in colors green for good. It also doesnt take into factor that I can put in an incomplete phone number, like 123-456-7 or 1234567, in the US it should have 10 digits.(ie. 123-456-7890) I guess I could change it to 10,15 or something.... ``` public static function isPhoneNumber($number) { $phoneNumber = preg_replace("/[+. ()-]/", "", $number);

    return (bool)preg_match('/^[0-9]{7,15}$/', $phoneNumber);
}

``` This is a replacement for the function in /classes/Validate.php

[Lathaneo]

Hi, May be you should to find a way to override the validate javascript function to match with this. You can find it in validate.js in root/js dir. It's just a function:

function validate_isPhoneNumber(s) { s.replace(/ +/g, "-"); var reg = /^[0-9]{7,15}$/; return reg.test(s); } I'm not really fan of regex, this one is wrong, but it should be something like that. Make the validation process before send the form, in my opinion, is better than doing it after with the validate.php.

Regards.

[SLiCK_303]

@lathaneo said in white space phone number:

I'm not really fan of regex, this one is wrong, but it should be something like that.

If this one is wrong, whats right? ;)

Make the validation process before send the form, in my opinion, is better than doing it after with the validate.php.

I agree with that.

[SLiCK_303]

Looks like I'm trying to fix this, and it's a very complicated problem to validate all phone numbers. This one seems to work fairly well... /^[+]?(1\-|1\s|1|\d{3}\-|\d{3}\s|)?((\(\d{3}\))|\d{3})(\-|\s)?(\d{3})(\-|\s)?(\d{4})$/g

I dont know what the final answer is, I just dont want people to be able to just put in a whitespace for their phone number