Bug: Stock check at order payment confirmation

[Chandra]

I have been testing out orders vis-a-vis stocks and believe stock check against products in the cart of an order happens at shipping selection step and not at payment confirmation step.

Consequently, if the stock in cart has been ordered by another customer, the order of the first customer still goes through, leading to negative stock and hence delivery issues.

Should there not be an additional stock check at the point of payment confirmation?

[dosbiner]

This is bug https://github.com/thirtybees/thirtybees/issues/504

[Chandra]

@dosbiner Thanks. I have added the below comment to the github issue.

``` Without understanding the code, I have a feeling the stock check happens at the point the Checkout button is clicked (and not at the point of clicking the payment Confirm button).

Would it make sense to repeat the stock check at the payment confirmation, since stock position would have changed between clicking check out and clicking confirm? ```