smarterweb Posted January 11, 2018 Posted January 11, 2018 reported PS bug here: http://forge.prestashop.com/browse/PSCSX-9383 and the fix here: https://github.com/PrestaShop/PrestaShop/pull/8538 can this be added to 1.0.4 please?
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 If you have confirmed the problem and the fix on tb's, you might wanna post this on gitub, https://github.com/thirtybees/thirtybees/issues
0 smarterweb Posted January 12, 2018 Author Posted January 12, 2018 well I don't quite why there's a forum for bugs and github. so where do I best report bugs? why have 2 places?
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 I think most bugs go on the forums first to be talked about, then if they are really a bug go on github...
0 smarterweb Posted January 12, 2018 Author Posted January 12, 2018 that bug has been reported in sept last year, so I assumed TB would have seen it too. will post it on git
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 I would fix it and do the pull request for this issue myself, but mine seem to get dismissed. ;(
0 smarterweb Posted January 12, 2018 Author Posted January 12, 2018 haha, hence I post here - just a user too trying to contribute
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 i hear ya, thats all I'm trying to do as well.
0 lesley Posted January 12, 2018 Posted January 12, 2018 Which pull did we dismiss of yours? I did not realize we did one.
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 Maybe you just havent gotten around to the new pull requests yet... ;) https://github.com/thirtybees/thirtybees/pull/428
0 lesley Posted January 12, 2018 Posted January 12, 2018 Oh, we haven't, it will make it in the next release, we just have been working on a couple internal projects.
0 lesley Posted January 12, 2018 Posted January 12, 2018 Oh, and thanks for the contribution, every little bit helps.
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 np..I try to help... Want me to do this one?
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 ill do it later today, im just up to let the dogs out right now.
0 SLiCK_303 Posted January 12, 2018 Posted January 12, 2018 @smarterweb , I did a pull request on this earlier, and it was accepted. So your wish was granted, nice contrib.
0 Baarssen Posted January 12, 2018 Posted January 12, 2018 indeed nice contribution, annoying issue what finally will be resolved for the users of volume discount
Question
smarterweb
reported PS bug here: http://forge.prestashop.com/browse/PSCSX-9383
and the fix here: https://github.com/PrestaShop/PrestaShop/pull/8538
can this be added to 1.0.4 please?
17 answers to this question
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now