[Solved, issue request created] Product Comparison Error when trying to remove product (30Bz 1.1.0 local dev Xampp)

[Acer]

Hi

I've been getting a js error on TB 1.1.0 with Product Comparison when trying to remove a product (adding appears to be ok).
The loading image appears and "loads forever" and throws the following js error:
 

products-comparison.js:65 Uncaught ReferenceError: baseUri is not defined
    at HTMLButtonElement.<anonymous> (products-comparison.js:65)
    at HTMLDocument.dispatch (jquery-1.11.0.min.js:3)
    at HTMLDocument.r.handle (jquery-1.11.0.min.js:3)

Notes:

• This is on local Xampp dev environment with PHP 7.2.
• Problem occurred in 1.08 previously as well.

Your help is appreciated in advance.

 

Edited September 16, 2019 by Theo

[musicmaster]

The error may be prior. I did a little test on my Xampp and got an error already on the comparison page before I deleted anything (I have compacted the image a bit to make it less wide):

When click the link to the error file I get this:

I assume that this sharing image will be used as basedir and that its backslashes will be processed as escapes in javascript and cause problems.

[Acer]

Hi

Indeed, there is a prior error that is occurring - I get the same Hexadecimal error.

So how do we fix this?

 

 

Edited September 10, 2019 by Theo

[musicmaster]

/modules/socialsharing/socialsharing.php line 243

change

_PS_IMG_DIR_.Configuration::get('PS_LOGO_MAIL', null, null, $this->context->shop->id), "'"

into

 str_replace("\\","/",_PS_IMG_DIR_).Configuration::get('PS_LOGO_MAIL', null, null, $this->context->shop->id), "'"

Can you make a Github issue?

[Acer]

Hi Musicmaster

This works, thank you 🙂

Regarding making a Github issue:
Not finding instructions on where to do this? (Contribute / making a Github issue) - can you please point me in the right direction?

Also, it seems the "Bug report link" from the main TB site to the forum doesn't work
https://forum.thirtybees.com/category/10/bug-reports

[musicmaster]

Glad to hear it works.

I see you have found the bug report section of the forum already. Some time ago TB changed its forum software and the links were changed. Occasionally you will still find old style links.

As for Github: it is probably best to make a report for the Social sharing module: https://github.com/thirtybees/socialsharing

The second tab there has the name "issues". It is the place where you can report problems.

[Acer]

On 9/10/2019 at 3:47 PM, musicmaster said:

/modules/socialsharing/socialsharing.php line 243

change

_PS_IMG_DIR_.Configuration::get('PS_LOGO_MAIL', null, null, $this->context->shop->id), "'"

into

 str_replace("\\","/",_PS_IMG_DIR_).Configuration::get('PS_LOGO_MAIL', null, null, $this->context->shop->id), "'"

Can you make a Github issue?

Hi
I've submitted the Github issue as requested
https://github.com/thirtybees/socialsharing/issues/5

[ksimunovic]

The issue I believe was not at all with the paths, the problem was that wrong logo URL generation method was used. PS_LOGO_MAIL was intended for use but no fallback was specified. As no PS_LOGO_MAIL is available with demo install I assumed this could happen to non-demo shops so I specified PS_LOGO as media which will be shared.

ksimunovic/socialsharing@1fad002