Core Updater - Database schema

[e-com]

Using a PHP script, I converted 100% of database tables to utf8mb4_unicode_ci.
Vast majority of prestashop modules are so sloppily made, that we have all the coding from all over the world in database 🙂
For what reason does Core Updater want to convert some tables back to utf8mb4_general_ci ?

 

[e-com]

I found the cause.
In CoreModels and CMSRole classes, tables have utf8mb4_general_ci encoding declared.
Is this necessary?
Can't these tables have utf8mb4_unicode_ci encoding like rest of database?
Performance difference between utf8mb4_general_ci and utf8mb4_unicode_ci is tenths of a microsecond.

 

[datakick]

It's probably a good idea to unify it.

When we switched from sql installs script to ObjectModel metadata, we converted the original script. We didn't really question if it makes sense or not, the intent was to generate the exact same SQL script from object model as had in install directory. 

Now we can definitely think about changes 🙂 this one seems like a good one. Can you create a PR?

[e-com]

OK, I'll do a PR on github.