Jump to content

Welcome, Guest!

By registering with us, you'll be able to discuss, share and private message with other members of our community.


  • Content Count

  • Joined

  • Last visited

  • Days Won


Posts posted by Traumflug

  1. 10 hours ago, Briljander said:

    I then have a product which has a size of 10 x 10 x 5. 

    When buying 1 product the shipping method can be used and the product fits into the parcel. 

    But when buying 4 of the same product the totalt size of the products would be (10 x 10 x 5) x 4 = 40 x 40 x 20.

    Four of these products would be 10 x 10 x 20 or 20 x 20 x 5 or 20 x 10 x 10 or ...

    Having so many possible combination explains why it's quite tricky to calculate "do they all fit?" Here we look at multiple items of the product only, often there are products of distinct size, which makes calculations even harder.

  2. 2 hours ago, datakick said:

    branch issue-1104 contains proposed fix

    There is Module::getNotThemeRelatedModules() in AdminThemesController which intends to do something similar. Automatic detection is better than a handcrafted list, of course, still the new code might duplicate more existing code than necessary or allow to deprecate more of previous code.

    Regarding these additional warnings: a simple "Theme configuration was unclear about the following modules, please review whether these modules are (un)installed the way you need them: <X>, <Y>, <Z>, ...," would be sufficient for my taste, but I take we have quite distinct opinions about what to burden merchants with.

  3. 21 hours ago, Occam said:

    For a merchant, however, only usability in practice counts.

    What you call 'usability' was pure luck. Themes not defining what they need relied on the previous theme doing the right thing.

    Even the default theme had three distinct flavors: the one in config/xml/themes/themenname.xml, the one in the theme's config.xml, installation when doing a fresh shop installation was yet another flavor. Highly unreliable behavior.

  4. 3 hours ago, datakick said:

    Thirty bees, on the other hand, should not be so eager to enforce these API contracts. There should have been some transition period, for example, when big red warning would be displayed during theme installation, informing user that the theme config.xml is not correctly composed.

    Nice idea, but probably not doable. I see no chance to detect whether a module isn't mentioned because the theme developer doesn't want it to be installed, or whether it isn't mentioned by sloppiness.

    Fixing themes is trivial, though. Install the theme, get its appearance right, then exporting it creates a correct config.xml.

  5. 2 hours ago, datakick said:

    He obviously thought this is redundant, as totals should be already calculated by Order class. That was a wrong assumption.  

    Well, it should be redundant. A class preparing values for display shouldn't have to recalculate numbers. It should just display the ones existing in the database already.

    If reverting this commit makes a distinction, the revert likely just covers some other issue which puts these wrong numbers into the database first place.

    Another topic with a revert would be the loss of precision, because removed code was obviously not subject to the price rounding audit.

  6. Core Updater checks validity of all thirty bees core files. Just click 'compare' without changing  the version. This calculates all the distinctions between files on your disk and the official distribution. Files not matching get reported as in need of modification.

    Note, however, there are modules out there which do such infiltration as part of their operations, so one always sees changes.

  7. It's certainly not as simple as clicking an 'update' button. thirty bees comes with a plethora of jQuery related files, one can update only all or nothing.

    On top of this, jQuery 3 is similar, but not entirely compatible with jQuery 1. There are compatibility files for mitigating the distinction.

    That said, jQuery 1.12 is considered to be safe (and compatible with the current 1.11.1). A request to update to 3.4 looks like a simple "use always the highest version number"-policy, without looking at the actual risks.

  8. I recently investigated such an installation and found that some files simply get deleted. This is what the hoster wrote:

    "Unfortunately, these files are deleted because our Firewall system consider them as suspicious. To my regret, they cannot be whitelisted. It is necessary to check these files and change the script."

    Notably, deleted files in question weren't uploaded directly through the network, but as a ZIP (module) package, so it's certainly not a firewall issue. Unpacking the ZIP resulted in 2 or 3 of the files missing, all others unpacked fine.

    I simply see no other choice than to turn off this "firewall", or if this is no option, to change hosting. If a hoster deletes files without telling the exact rules by which this is done, there is no chance to build a reliable system.

    That said, in the investigated case it worked to upload logos from another device. Uploaded from a desktop PC in the U.S. deleted the file, upload from a PC in the EU, or from a mobile device, worked. Totally bonkers.

  9. 4 hours ago, Occam said:
    You can avoid warnings like this by changing the count() function to _iscountable():

    Not really. An empty array has a count of zero, but is countable:

        php > echo count([]);
        php > echo is_countable([]);

  10. Ich betreibe zwar keinen Shop, doch Mindermengenzuschläge nerven. Da kauft man mehr als man braucht, nur um den Zuschlag los zu werden. Der Kunde bezahlt mehr, der Händler muss für's gleiche Geld mehr Ware verschicken, eine Loose-Loose-Situation.

    Deutlich angenehmer sind Staffelpreise. Braucht man nur drei Schrauben, kostet das Stück eben einen Euro. Juckt die Leute nicht sonderlich, deswegen kommen z.B. Baumärkte mit ihren Apothekenpreisen durch. Die Profis bekommen dagegen für ihren 500er-Pack einen konkurrenzfähigen Preis.

  11. 22 hours ago, wakabayashi said:

    Neither is the module used, nor was the new version tested.

    People not talking about the module doesn't mean they don't use it. Quite possibly the opposite is true: it works flawlessly, nobody has questions.

    And yes, that's kind of a trap. All too often, crappy stuff gets more popular, because people have to talk about its quirks.

  12. 23 hours ago, datakick said:

    Your hosting (or maybe cloudflare or similar service) can (and probably do) throttle number of simultaneous connections per IP address, and drop some requests using 503 error code.

    I'd consider this to be a broken hosting. Especially when returning 503 instead of just queuing/delaying requests. 15+ simultaneous requests isn't that unusual, could be 20 images on a static page as well.

  13. Could you copy the URL of this not existing page into here, please? If there's something like 'adminXYZ' inside, where XYZ are some random characters, please remove them before posting.

    Also, did you move the shop in the file system, perhaps? Like renaming its folder or moving it into another folder? One can do this, but there's some extra work required.

    Renaming the shop is a bit hidden. Go to back office -> Preferences -> Store Contacts, then scroll down the page, there's a tab "Contact Details". First line is the shop name.

  • Create New...