1.1.x module uninstall bug?

[SLiCK_303]

On many modules, when I uninstall them, I get this.  Seems like there should be words above the OK CANCEL buttons...

 

like this... for some reason when i uninstall bankwire module it works, but most others don't

 

Edited June 29, 2019 by SLiCK_303

[yaniv14]

@SLiCK_303 can you please check this commit.

https://github.com/thirtybees/thirtybees/pull/983/commits/fd590f6bcdae5f337d341b43c093a5127a9ae779

 

Edited June 30, 2019 by yaniv14

[SLiCK_303]

I noticed this same behavior on my 1.0.8-1.0.x site too, not sure now long it's been like this......

edit: i have a 1.0.6 test site (dont ask), and it does this same thing.  So this behavior has been going on for a long time.

Edited June 30, 2019 by SLiCK_303

[SLiCK_303]

I'm thinking that it's because of..

        $this->confirmUninstall = $this->l('Are you sure about removing these details?');

bankwire module has this line in it's main php file, the modules  that have no message do not have this line.  So I recommend that there should be a default message, or make this line one of the requirements for module writing.

I think it would be more accurate, at least in english, that it reads something like..

        $this->confirmUninstall = $this->l('Are you sure about removing this module?');

..or something similar.

Edited June 30, 2019 by SLiCK_303

[Traumflug]

It's just a lack of a default message, nothing serious.

To not forget it: https://github.com/thirtybees/thirtybees/issues/982

[SLiCK_303]

@yaniv14 works like a champ...good job!

Edited June 30, 2019 by SLiCK_303