dollar euro

[musicmaster]

While entering prices in the backoffice I encountered the following little issue:

This shop is only in euro's. Yet the prices are quoted as "USD 1.99 €". Does anyone know where this USD comes from?

[zen]

57 minutes ago, musicmaster said:

While entering prices in the backoffice I encountered the following little issue:

This shop is only in euro's. Yet the prices are quoted as "USD 1.99 €". Does anyone know where this USD comes from?

Yes, I didn't noticed it before...  but this USD has nothing to do it here and was not there in 1.0.8 version.

Edited November 18, 2019 by zen

[zen]

It comes from the function displayPrice that needs some correction in the file : js/tools.js

line 117

    if (currencySign && currencySign!== 'undefined') {
      formattedCurrency = formattedCurrency.replace('USD', currencySign);
    }

And I am not sure it really needs to be there.. why replacing to USD, in others files it setup by default to euro € symbol... strange, maybe somebody can explain where does it comes from.

 

Edited November 18, 2019 by zen

[zen]

GetDatakick post this solution : https://github.com/thirtybees/thirtybees/commit/821de66a61eee4eed4acccc2b49a2b75f9c54498

Edited November 19, 2019 by zen

[DRMasterChief]

So, do you think with the solution given at Github  this problem is solved ? 

(i can confirm this issue in 1.1.0 ,  but it is not in 1.0.8) 

 

[zen]

GetDatackick solved it :

 

Quote

 

displayPrice: always replace USD symbol

When Auto format is turned on for some currency, displayPrice javascript
method will use browser built-in support for currency formatting to
format currency in specific locale.

It does so by evaluating this expression:

return price
  .toLocaleString(locale, {
    style: 'currency',
    currency: 'USD',
    currencyDisplay: 'code'
  })

This code ensures that the number is formatted using 'USD' string in
place of currency symbol. This 'USD' string is then replaced with actual
currency symbol.

However, there was a bug - this string replacement wasn't performed when
no currencySign was passed to the function. In such case, the string
with 'USD' symbol was returned.

This commit ensures that this USD symbol is always replaced, even with
the empty string.

Related to issue #865

 

 

Edited November 19, 2019 by zen