Invoice number in emails by updating classes/module/PaymentModule.php

[30knees]

Is it correct that I would need to update classes/module/PaymentModule.php to enable {invoice_number} to be used in emails, eg bankwire module?

https://github.com/thirtybees/thirtybees/blob/main/classes/module/PaymentModule.php

And then adding here:

$params = [
                                '{voucher_amount}' => Tools::displayPrice($voucher->reduction_amount, $this->context->currency, false),
                                '{voucher_num}'    => $voucher->code,
                                '{firstname}'      => $this->context->customer->firstname,
                                '{lastname}'       => $this->context->customer->lastname,
                                '{id_order}'       => $order->reference,
                                '{order_name}'     => $order->getUniqReference(),
                            ];

'{invoice_number}' => $order->invoice_number,

[datakick]

This class handles sending of order_conf and voucher emails. So if you want to extend those email templates, then it's the right place to modify.

It has no impact on order status emails, like bankwire, though.

[30knees]

Thank you, I was looking for the bankwire status email. Where do I look for that?

Is this something that you would be fine with having in the core? Then I could do a PR.

[datakick]

OrderHistory

https://github.com/thirtybees/thirtybees/blob/0913a2fa58cfd7db1e1f9ac33b99389777edba78/classes/order/OrderHistory.php#L480

Sure, we would gladly accept PR. Extra parameters passed to email templates are fine, as long as it doesn't cause errors or performance issues.