SLiCK_303

if you removed it, then try installing again...

either way it doesnt matter, if you delete it, the option to install it will be back again.

can you get to BO>Modules and Services still?

If you cant get to your BO>Modules anymore then ftp to your site, and delete /modules/tbupdater.

So I just noticed something I haven't looked at in a looong time. When you goto BO>Customers>Groups then edit a group. Does setting Authorized modules actually do anything? Or is this some ancient leftover code that basically does nothing?

I'm 99% sure then that the pdfs get their address info from BO>Preferences>Store Contacts.

Is your website setup to be mutlistore?

Actually I think it gets its address info from BO>Preferences>Store Contacts then Contact Details at the bottom of the page.

I just did some testing myself, and found out a few things. Like you were saying, or the blog you posted, if you change your address on the site, you're old invoices won't have the new address on them, they will have the address at the time when they were created. So, I changed my address, looked at some old invoices, my addy wasn't on them. I made a new order, and my address was on that invoice. So.... I dunno what to tell ya,, I guess you could do what that blog suggested, modifying those files.

Are you sure that your /classes and /controllers folders both fresh 1.0.3 files?

@lathaneo said in Adding a ‘sort by sales’ option: In modules/blocklayered/blocklayered.php, just before the 'where [...]' line 3146, insert: LEFT JOIN `'._DB_PREFIX_.'product_sale` psa ON psa.id_product = p.id_product so you get: LEFT JOIN '._DB_PREFIX_.'manufacturer m ON (m.id_manufacturer = p.id_manufacturer) '.Product::sqlStock('p', 0).' LEFT JOIN `'._DB_PREFIX_.'product_sale` psa ON psa.id_product = p.id_product WHERE '.$alias_where.'.`active` = 1 AND '.$alias_where.'.`visibility` IN ("both", "catalog") there are two instances of that code, nether are on line 3146, do you change one, or both? [01515061457658blocklayered.php](Uploading 100%) [01515061485981product-sort.tpl](Uploading 100%) [01515061499590Tools.php](Uploading 100%) Your files didnt show up, might wanna try again.

@Lathaneo , nice job. You might want to make the first two changes overrides though, so you're not modifying the core..

Click on the three little vertical dots on the bottom right of one of your posts...

@foolab said in Adding a ‘sort by sales’ option: I vote for adding it to the core Me too....

I forked, and made a pull request for both of these issues....

I think I fixed it...amazing no? At any rate, in /classes/Product.php, find.. foreach (SpecificPrice::getIdsByProductId((int) $oldProductId) as $data) { change to.. foreach (SpecificPrice::getByProductId((int) $oldProductId) as $data) { I'll keep testing to make sure it's working.. I'll get back to ya... edit: seems to be working for me, try it yourself and let me know. I'm sure I'm not the only person who had issue with this not working. Again I could make this an override, but it needs to be fixed in the core instead.

Why duplicateSpecificPrices isn't working is beyond me. I can look at the function and tell it wont work, but as to making it work, is way above my paygrade.

After looking into it a bit more, a 'download' is NOT an 'attachment'. Sorry for my confusion. So it's not duplicating that because it's not told to. I will add it to the above code and see if it does duplicate attachments or not. edit: yes it does duplicate attachments if it's told to. Just put this in the code after.. && Product::duplicateDownload($idProductOld, $product->id) add.. && Product::duplicateAttachments($idProductOld, $product->id) So that can be done with an override, but I think it should be done to the core.

I hope everyone has a safe, and happy new years eve and day. :hugging:

There are a couple problems, at least these two, that happen when you duplicate a product. The specific prices and downloads(attachements) are not duplicated. They are supposed to be, if you look at the code in controllers/admin/AdminProductsController.php, via this block of code, and the associated functions in classes/Product.php.. if ($product->add() && Category::duplicateProductCategories($idProductOld, $product->id) && Product::duplicateSuppliers($idProductOld, $product->id) && ($combinationImages = Product::duplicateAttributes($idProductOld, $product->id)) !== false && GroupReduction::duplicateReduction($idProductOld, $product->id) && Product::duplicateAccessories($idProductOld, $product->id) && Product::duplicateFeatures($idProductOld, $product->id) && Product::duplicateSpecificPrices($idProductOld, $product->id) && Pack::duplicate($idProductOld, $product->id) && Product::duplicateCustomizationFields($idProductOld, $product->id) && Product::duplicateTags($idProductOld, $product->id) && Product::duplicateDownload($idProductOld, $product->id) ) { ...but they don't get duplicated.

Is it just me, or do all of the sites reviews come up as Reported Reviews(abusive), when you are looking at them in the BO?

Thanx for that @moy2010 .. That made it a tab, but the review info is still showing in all the tabs. To fix, I did the following changes to themes/your_theme/modules/productcomments/productcomments.tpl.. I changed this.. ``` {if !empty($comments)} ``` to this.. ``` {if !empty($comments)} ``` and changed this.. ``` {l s='No customer reviews for the moment.' mod='productcomments'} {/if} {/if} ``` to this.. ``` {l s='No customer reviews for the moment.' mod='productcomments'} {/if} {/if} ```

It doesn't include the reviews section, how does one make that a tab as well?

replace.. public static function getAttachments($idLang, $idProduct, $include = true) { return Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS( (new DbQuery()) ->select('a.*, al.*') ->from('attachment', 'a') ->leftJoin('attachment_lang', 'al', 'a.`id_attachment` = al.`id_attachment`') ->leftJoin('product_attachment', 'pa', 'pa.`id_attachment` = a.`id_attachment`') ->where('al.`id_lang` = '.(int) $idLang) ->where($include ? 'pa.`id_product` = '.(int) $idProduct : '') ->where('pa.`id_product` IS '.($include ? 'NOT ' : '').'NULL') ); } with.. public static function getAttachments($idLang, $idProduct, $include = true) { return Db::getInstance()->executeS(' SELECT * FROM '._DB_PREFIX_.'attachment a LEFT JOIN '._DB_PREFIX_.'attachment_lang al ON (a.id_attachment = al.id_attachment AND al.id_lang = '.(int) $idLang.') WHERE a.id_attachment '.($include ? 'IN' : 'NOT IN').' ( SELECT pa.id_attachment FROM '._DB_PREFIX_.'product_attachment pa WHERE id_product = '.(int) $idProduct.' )' ); } If you didn't have those two files handy... edit: I modified the first two variables, just to make it more a little more current. It would be nice if it was re-written with the (new DbQuery()) type... hint hint, nudge nudge... ;)

no,no...you need to re-write that sql statement in tb 1.0.4 format, not leave it in the old school way.... ;)