SLiCK_303 Posted December 12, 2017 Posted December 12, 2017 Well, I got sick of the Online Visitors and Traffic info being wrong on my site. I don't know if I have google Analytics setup wrong or what. So I went back and revisted dashactivity v1.0.0, and updated it a little, now my stats are the way I expect them to be. Here it is if you wanna use it too. I set the version for 1.0.1 which was never used. The problem being that TB sees that and wants to update it, I just ignore that. 01513049146056dashactivity_v1.0.1.zip
hfxracing Posted December 12, 2017 Posted December 12, 2017 Where was it off in the stats section or right on the dashboard?
SLiCK_303 Posted December 12, 2017 Author Posted December 12, 2017 The left section, Activity Overview.
hfxracing Posted December 12, 2017 Posted December 12, 2017 Ya I bit to get that setup correctly go here & create the API If the Oauth is not setup right your stats will be off. mine work perfectly. https://developers.google.com/analytics/devguides/reporting/core/v4/quickstart/web-php
Troy.Roberts Posted December 12, 2017 Posted December 12, 2017 What did you change? That has been broken forever imo
SLiCK_303 Posted December 12, 2017 Author Posted December 12, 2017 v1.0.0 didn't use Google Analytics realtime API. It's basically the PS 1.6.x version of it... I just addded some comments and changed arrays() to [], like in TB.
gonssal Posted December 12, 2017 Posted December 12, 2017 @slick_303 I've seen you sending changes to modules in zip files multiple times already. Why don't you consider sending the changes through github? It will make it very likely that they get commited to core.
lesley Posted December 12, 2017 Posted December 12, 2017 Tomorrow we are announcing a GitHub community repository, where we will have members of the community sign up to oversee it. They might make a good home there. We are hoping it will be a place for modules that the core does not actively maintain, but the community does and should be hooked into the store as well under a contributor called the community.
SLiCK_303 Posted December 12, 2017 Author Posted December 12, 2017 My hope with all of these is that they would be in the core, as they are all core modules. Well, all but this one maybe, since the core went with Google Analytics realtime API.... I put thirty bees as the author on all of them...
gonssal Posted December 12, 2017 Posted December 12, 2017 @slick_303 Then you should use github and send pull requests with your changes instead of posting them here as zip files. It's really easy, you just need to install git in your computer and create a github account.
lesley Posted December 12, 2017 Posted December 12, 2017 You also might look into GitKraken if you use windows, that is what a lot of us use as well. It seems to be the best GUI we have tried.
SLiCK_303 Posted December 13, 2017 Author Posted December 13, 2017 I'll look into it. I d/l and installed GitKraken, now I just have to figure out how to use it. ;)
SLiCK_303 Posted December 13, 2017 Author Posted December 13, 2017 I don't have permisions to push to TBs github. I'll have to wait for the GitHub community repository, and try using that.
gonssal Posted December 13, 2017 Posted December 13, 2017 @slick_303 The github workflow is based on *Pull requests*, which basically means you fork (copy) the project you want to make changes to into your own project, commit the changes to a branch on your project, and then "request a pull" of your changes to the original project. This last step is done through a simple click on your project's github page. Learn more here: https://help.github.com/articles/creating-a-pull-request/
SLiCK_303 Posted December 13, 2017 Author Posted December 13, 2017 all of it! hehe.... I'm still trying. This time on the statsmodule.
lesley Posted December 13, 2017 Posted December 13, 2017 Good luck. Be sure to pull before you push, it keeps everything up to date.
SLiCK_303 Posted December 13, 2017 Author Posted December 13, 2017 ok. I think I got it right for the statsmodule, not sure if I did for this one or not. You guys will have to look at both of them and see I guess.
lesley Posted December 13, 2017 Posted December 13, 2017 Everything looks right with that one, I will let @mdekker give it the final go, I don't know if he has them ordered for a reason or not.
SLiCK_303 Posted December 13, 2017 Author Posted December 13, 2017 I'm not sure why statsbestmanufacturers was left out in the first place. So maybe im not on the right track at all....i dunno. Seems to work on my site though.
lesley Posted December 13, 2017 Posted December 13, 2017 I just activated a new forum for github and free module questions / issues. I am opening the community repo tonight in just a little bit. I am going to fork some interesting modules to it, that I think might have potential, but need to be made compatible / checked.
SLiCK_303 Posted December 15, 2017 Author Posted December 15, 2017 I updated my version of this module. I changed the version to 6.0.0, so it doesnt try to update it all the time, plus I know TB will never go up to that version number. I also modified the sql calls to the newer way of doing it. https://github.com/SLiCK-303/dashactivity/releases
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now