Remove out of stock products from price-drop page

[movieseals]

Hi everyone,

I am trying to disable the out of stock products that appear on the price-drop page.  I do not see the point of putting on sale products that are out of stock.  We sometimes forget to remove the discount and customers complain about it.

So, here is what I tried to do:

I looked into the file classes/Product.php:

I found the function:

public static function getPricesDrop($id_lang, $page_number = 0, $nb_products = 10, $count = false,

$order_by = null, $order_way = null, $beginning = false, $ending = false, Context $context = null)

 

In there, in the SQL code:

		$sql = '
		SELECT
			p.*, product_shop.*, stock.out_of_stock, IFNULL(stock.quantity, 0) as quantity, pl.`description`, pl.`description_short`,
			MAX(product_attribute_shop.id_product_attribute) id_product_attribute,
			pl.`link_rewrite`, pl.`meta_description`, pl.`meta_keywords`, pl.`meta_title`,
			pl.`name`, MAX(image_shop.`id_image`) id_image, il.`legend`, m.`name` AS manufacturer_name,
			DATEDIFF(
				p.`date_add`,
				DATE_SUB(
					NOW(),
					INTERVAL '.(Validate::isUnsignedInt(Configuration::get('PS_NB_DAYS_NEW_PRODUCT')) ? Configuration::get('PS_NB_DAYS_NEW_PRODUCT') : 20).' DAY
				)
			) > 0 AS new
		FROM `'._DB_PREFIX_.'product` p
		'.Shop::addSqlAssociation('product', 'p').'
		LEFT JOIN '._DB_PREFIX_.'product_attribute pa ON (pa.id_product = p.id_product)
		'.Shop::addSqlAssociation('product_attribute', 'pa', false, 'product_attribute_shop.default_on=1').'
		'.Product::sqlStock('p', 0, false, $context->shop).'
		LEFT JOIN `'._DB_PREFIX_.'product_lang` pl ON (
			p.`id_product` = pl.`id_product`
			AND pl.`id_lang` = '.(int)$id_lang.Shop::addSqlRestrictionOnLang('pl').'
		)
		LEFT JOIN `'._DB_PREFIX_.'image` i ON (i.`id_product` = p.`id_product`)'.
		Shop::addSqlAssociation('image', 'i', false, 'image_shop.cover=1').'
		LEFT JOIN `'._DB_PREFIX_.'image_lang` il ON (i.`id_image` = il.`id_image` AND il.`id_lang` = '.(int)$id_lang.')
		LEFT JOIN `'._DB_PREFIX_.'manufacturer` m ON (m.`id_manufacturer` = p.`id_manufacturer`)
		WHERE product_shop.`active` = 1
		AND product_shop.`show_price` = 1

 I added              AND stock.`quantity` > 0

		'.($front ? ' AND p.`visibility` IN ("both", "catalog")' : '').'
		'.((!$beginning && !$ending) ? ' AND p.`id_product` IN ('.((is_array($tab_id_product) && count($tab_id_product)) ? implode(', ', $tab_id_product) : 0).')' : '').'
		'.$sql_groups.'
		GROUP BY product_shop.id_product
		ORDER BY '.(isset($order_by_prefix) ? pSQL($order_by_prefix).'.' : '').pSQL($order_by).' '.pSQL($order_way).'
		LIMIT '.(int)($page_number * $nb_products).', '.(int)$nb_products;

		$result = Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS($sql);

		if (!$result)
			return false;

However, it dit not work at all and I am not sure why.  I did the usual: clear caches, etc.  No dice and I am not sure why.

Anybody else can point me in the right direction or tell me what I am doing wrong?

[yaniv14]

You sql addon looks fine and I believe it should work.

Check if you have an override for classes/Product.php in your override folder. and also try to delete "cache/class_index.php" file.

[wakabayashi]

I have implemented this in our shop. But I am not at the computer now. I will post my override later... Do you use advanced stock management?

[movieseals]

I do not use advanced stock management, no. I can wait until you are able to guide me further.  Thank you!

Edited May 25, 2019 by movieseals

[wakabayashi]

Damn my memory was wrong. I haven't implemented it for price-drops. Can you tell me what error you get? As the code you posted make sense to me. So I am not sure where the problem is...

[movieseals]

I do not get an error, but it does not work either. 🙂

[movieseals]

44 minutes ago, yaniv14 said:

You sql addon looks fine and I believe it should work.

Check if you have an override for classes/Product.php in your override folder. and also try to delete "cache/class_index.php" file.

There is indeed 4 different overrides in products.  I guess I need to create another one on top of those?

[yaniv14]

Just check if this function getPricesDrop is being overrided in the override file.

If so, than just implant your modified sql there