Module Invoilc Prestabay

[Beeta]

@datakick

I'm on edge

I just updated TB and now prestabay give me critical errors:

Context: {"task":"autoList","errorText":"Unknown column 'fl.public_name' in 'field list'","trace":"#0 \/home\/nginx\/domains\/domain.it\/public\/classes\/db\/Db.php(441): DbCore->displayError()\n#1 \/home\/nginx\/domains\/domain.it\/public\/classes\/db\/Db.php(1102): DbCore->query()\n#2 \/home\/nginx\/domains\/domain.it\/public\/classes\/Product.php(2164): DbCore->getArray()\n#3 \/home\/nginx\/domains\/domain.it\/public\/classes\/Product.php(6358): ProductCore::getFrontFeaturesStatic()\n#4 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(878): ProductCore->getFrontFeatures()\n#5 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(422): PrestaBay\\Helpers\\ReplaceHelper::buildFeaturesTable()\n#6 [internal function]: PrestaBay\\Helpers\\ReplaceHelper::replaceCallback()\n#7 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(130): preg_replace_callback()\n#8 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/models\/ProfileProductModel.php(568): PrestaBay\\Helpers\\ReplaceHelper::parseAttributes()\n#9 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/models\/ProfileProductModel.php(432): PrestaBay\\Models\\ProfileProductModel->parseAttributes()\n#10 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Ebay\/Item\/ItemAbstractRequest.php(949): PrestaBay\\Models\\ProfileProductModel->getDescription()\n#11 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Ebay\/Item\/ListRequest.php(57): PrestaBay\\Services\\Ebay\\Item\\ItemAbstractRequest->isDescriptionEmpty()\n#12 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/EbayListHelper.php(96): PrestaBay\\Services\\Ebay\\Item\\ListRequest->validate()\n#13 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Tasks\/AutoList.php(76): PrestaBay\\Helpers\\EbayListHelper::sendList()\n#14 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/BaseTask.php(53): PrestaBay\\Services\\Synchronization\\Tasks\\AutoList->execute()\n#15 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Run.php(211): PrestaBay\\Services\\Synchronization\\BaseTask->run()\n#16 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Run.php(157): PrestaBay\\Services\\Synchronization\\Run->executeCronJobs()\n#17 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/controllers\/front\/cronGeneral.php(51): PrestaBay\\Services\\Synchronization\\Run->execute()\n#18 \/home\/nginx\/domains\/domain.it\/public\/classes\/controller\/Controller.php(196): PrestabayCronGeneralModuleFrontController->postProcess()\n#19 \/home\/nginx\/domains\/domain.it\/public\/classes\/controller\/FrontController.php(251): ControllerCore->run()\n#20 \/home\/nginx\/domains\/domain.it\/public\/classes\/Dispatcher.php(851): FrontControllerCore->run()\n#21 \/home\/nginx\/domains\/domain.it\/public\/index.php(33): DispatcherCore->dispatch()\n#22 {main}"}.

Is there a new column fl.public_name in 1.5?

[30knees]

If the module stops working one day you might want to look at https://baselinker.com/en-GB/integrations/ebay/

[datakick]

  On 7/23/2023 at 1:28 PM, Beeta said:

@datakick

I'm on edge

I just updated TB and now prestabay give me critical errors:

Context: {"task":"autoList","errorText":"Unknown column 'fl.public_name' in 'field list'","trace":"#0 \/home\/nginx\/domains\/domain.it\/public\/classes\/db\/Db.php(441): DbCore->displayError()\n#1 \/home\/nginx\/domains\/domain.it\/public\/classes\/db\/Db.php(1102): DbCore->query()\n#2 \/home\/nginx\/domains\/domain.it\/public\/classes\/Product.php(2164): DbCore->getArray()\n#3 \/home\/nginx\/domains\/domain.it\/public\/classes\/Product.php(6358): ProductCore::getFrontFeaturesStatic()\n#4 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(878): ProductCore->getFrontFeatures()\n#5 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(422): PrestaBay\\Helpers\\ReplaceHelper::buildFeaturesTable()\n#6 [internal function]: PrestaBay\\Helpers\\ReplaceHelper::replaceCallback()\n#7 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/ReplaceHelper.php(130): preg_replace_callback()\n#8 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/models\/ProfileProductModel.php(568): PrestaBay\\Helpers\\ReplaceHelper::parseAttributes()\n#9 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/models\/ProfileProductModel.php(432): PrestaBay\\Models\\ProfileProductModel->parseAttributes()\n#10 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Ebay\/Item\/ItemAbstractRequest.php(949): PrestaBay\\Models\\ProfileProductModel->getDescription()\n#11 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Ebay\/Item\/ListRequest.php(57): PrestaBay\\Services\\Ebay\\Item\\ItemAbstractRequest->isDescriptionEmpty()\n#12 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/helpers\/EbayListHelper.php(96): PrestaBay\\Services\\Ebay\\Item\\ListRequest->validate()\n#13 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Tasks\/AutoList.php(76): PrestaBay\\Helpers\\EbayListHelper::sendList()\n#14 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/BaseTask.php(53): PrestaBay\\Services\\Synchronization\\Tasks\\AutoList->execute()\n#15 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Run.php(211): PrestaBay\\Services\\Synchronization\\BaseTask->run()\n#16 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/services\/Synchronization\/Run.php(157): PrestaBay\\Services\\Synchronization\\Run->executeCronJobs()\n#17 \/home\/nginx\/domains\/domain.it\/public\/modules\/prestabay\/controllers\/front\/cronGeneral.php(51): PrestaBay\\Services\\Synchronization\\Run->execute()\n#18 \/home\/nginx\/domains\/domain.it\/public\/classes\/controller\/Controller.php(196): PrestabayCronGeneralModuleFrontController->postProcess()\n#19 \/home\/nginx\/domains\/domain.it\/public\/classes\/controller\/FrontController.php(251): ControllerCore->run()\n#20 \/home\/nginx\/domains\/domain.it\/public\/classes\/Dispatcher.php(851): FrontControllerCore->run()\n#21 \/home\/nginx\/domains\/domain.it\/public\/index.php(33): DispatcherCore->dispatch()\n#22 {main}"}.

Is there a new column fl.public_name in 1.5?

Expand  

yes, there is new column in table tb_feature_lang.

If you use coreupdater to update your store, it should be automatically created. If you updated your store manually, you can still use core updater to fix database differences.

[Beeta]

I asked support to Prestabay about some warning I was getting on the collect logs

[09:45:06.0606] [OLD] [fa0f947e29a961c1a5e0e2385808076c] [DEPRECATION] array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead in file modules/prestabay/library/PSR4/Involic/Model/AbstractModel.php at line 159.

[06:24:40.4040] [OLD] [8257f440fd98f959e057741ef5368edc] [WARNING] Link::getImageLink(): parameter $name has invalid type. Expected string, got array. This will raise error in future version of thirty bees. Called from: PrestaBay\Models\ProfileProductModel::getImageLink() in file 'modules/prestabay/models/ProfileProductModel.php' at line 1002 in file classes/Link.php at line 375.

They released 4.3.0 version and DEPRECATION are gone but still remain the WARNINGs.

I' now asking to fix the WARNING too.

[datakick]

  On 10/2/2023 at 4:36 PM, Beeta said:

I asked support to Prestabay about some warning I was getting on the collect logs

[09:45:06.0606] [OLD] [fa0f947e29a961c1a5e0e2385808076c] [DEPRECATION] array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead in file modules/prestabay/library/PSR4/Involic/Model/AbstractModel.php at line 159.

[06:24:40.4040] [OLD] [8257f440fd98f959e057741ef5368edc] [WARNING] Link::getImageLink(): parameter $name has invalid type. Expected string, got array. This will raise error in future version of thirty bees. Called from: PrestaBay\Models\ProfileProductModel::getImageLink() in file 'modules/prestabay/models/ProfileProductModel.php' at line 1002 in file classes/Link.php at line 375.

They released 4.3.0 version and DEPRECATION are gone but still remain the WARNINGs.

I' now asking to fix the WARNING too.

Expand  

That's great, I love that the collectlogs module help fixing bugs in third party modules.

The prestabay module probably pass $product->link_rewrite directly to Link::getImageLink method. Depending on mode the $product object was instantiated, this property can either contain text, or array of texts (one for each language). I guess in this case it's the later. This would result in image url like

https://domain.com/1-Niara_home/array.jpg

instead of expected

https://domain.com/1-Niara_home/product-link-rewrite.jpg

It is not a big deal, because both urls are valid. But the first url is ugly, wrong, and not-so-much SEO friendly.