Problem with installing override module

[Yabber]

When installing a module that overwrites blocknewsletter module, I get this error:

The following module(s) could not be installed properly:
    googlecaptcha :
        Unable to install override: Failed to evaluate override file /home/iwona/public_html/tbshop/modules/googlecaptcha/override/modules/blocknewsletter/blocknewsletter.php: syntax error, unexpected token "extends", expecting "{" at line 2

Code of the file blocknewsletter.php

<?php

class BlocknewsletterOverride extends Blocknewsletter
{
    public function confirmSubscription($email)
    {
        if (Module::isEnabled('googlecaptcha') && ($module = Module::getInstanceByName('googlecaptcha')) && $module->hookValidate('newsletter')) {
            $module->captchaValidate(Context::getContext()->controller->errors);
        }
        if (Context::getContext()->controller->errors) {
            return false;
        }
        return parent::confirmSubscription($email);
    }
}

Thirty bees version: 1.6.0
Thirty bees revision: db85aa271005ab890a8c3a9711a3cca9722d5095
Build for PHP version: 8.3

 

[Mediacom87]

Hi,

I'm having exactly the same problem with a 1.5.1 installation.

Have you tested other PHP versions?

[Mediacom87]

It's impossible to test below PHP 8.1 because of composition, so we'll have to find a solution to install module overrides.

 

[Mediacom87]

An idea @datakick ?

[Mediacom87]

Hi,

I still haven't found a solution for properly overriding a module, which is always refused or doesn't work.

@datakick

[datakick]

It's a bug in core, I've managed to reproduced on my dev env. I'll prepare a fix and let you know.

[Mediacom87]

7 minutes ago, datakick said:

It's a bug in core, I've managed to reproduced on my dev env. I'll prepare a fix and let you know.

Thank you for your feedback.

[datakick]

Should be fixed in bleeding edge, please try

[Mediacom87]

On 9/24/2024 at 8:35 AM, datakick said:

Should be fixed in bleeding edge, please try

Hi,

Thank you very much, I've just run the tests and it works perfectly.