SLiCK_303

Did you look on one of YOUR posts, but not the first one?

you click on the 3 little vertical dots on the right of one of your posts, the option to mark it solved is there.

wow...4 files changed. ok...ill give er a whirl. thanks

When creating a new address, we can save it into the DB even the phone number is just a whitespace. To test: BO > Customers > Addresses > Set required fields for this section > make the phone required, FO > Sign in > My addresses > Add a new address > fill the phone number with whitespace and "Save", check if the error message is displayed. The following almost fixes it, it makes it so you can't just put in a space, but doesn't fix the fact when you put in a space, goto a different field, the phone # field you just put a space in colors green for good. It also doesnt take into factor that I can put in an incomplete phone number, like 123-456-7 or 1234567, in the US it should have 10 digits.(ie. 123-456-7890) I guess I could change it to 10,15 or something.... ``` public static function isPhoneNumber($number) { $phoneNumber = preg_replace("/[+. ()-]/", "", $number); return (bool)preg_match('/^[0-9]{7,15}$/', $phoneNumber); } ``` This is a replacement for the function in /classes/Validate.php

We all await eagerly for your fix

@Generaal you might wanna start a new thread for that one, and mark this one solved.

@mdekker and @lesley are on it.....

@MockoB what browser are you using?

continue the favicon topic here...https://forum.thirtybees.com/topic/1346/fav-icons-not-working

The iPhone and iPad favicons don't seem to be working....

this need fixin.....

ahhh, bummer

I have them set, but as I don't have an iPhone or iPad I cant say if they work or not. What do you see if you goto my site on your iDevice?

you cut off the first word in that code snippet... edit: there ya go. ;)

solved by @mdekker as always... https://github.com/thirtybees/thirtybees/commit/2fee5fe47a63901c7103c92d22abdbce6ee8034a

what file are we talkin bout?

Have a product with a - in the name, like mine has '-Five for 35'. Then in 1.0.3 do a search for -five and see what happens, then do it in 1.0.4. In 1.0.3 it doesn't work right, in 1.0.4 it gives a nasty error message.

good deal!

good idea...but no. anything is possible i guess, if you can code though.

@Baarssen I would start now, why wait. That way you can start developing your theme, or modify your old one. You can also make sure your modules will be compatible to TB. I'm confident there will be an easy upgrade path from 1.0.3 to 1.0.4 via the updater... I maybe wouldnt do a full migration to it, ie making it live, but do a developer site...

I dont have any experience with doing that, but I'm thinking BO>Preferences>Custom Code might be of some use..?

Actually there are a few differences I can think of just off the top of my head, now that I think about it more. The modules statsbestmanufacturers, graphnvd3, and gridhtml are no longer in RC2, so you would want to uninstall and delete them, before copying the files over.

From what I've seen, I don't think there are any DB changes, so you should just be able to copy the RC2 files over the RC1 files and be good to go.

How about this one, it only changes two lines from the original 1.0.x file ``` protected function updateCustomizationQuantity($quantityChange, $idCustomization, $idProduct, $idProductAttribute, $idAddressDelivery, $operator = 'up') { // Link customization to product combination when it is first added to cart if (empty($idCustomization) && $operator === 'up') { $customization = $this->getProductCustomization($idProduct, null, true); foreach ($customization as $field) { if ((int) $field['quantity'] === 0) { Db::getInstance()->update( 'customization', [ 'quantity' => (int) $quantityChange, 'idproduct' => (int) $idProduct, 'idproductattribute' => (int) $idProductAttribute, 'idaddressdelivery' => (int) $idAddressDelivery, 'incart' => true, ], 'id_customization = '.(int) $field['idcustomization'] ); } } } /* Quantity update */ if (!empty($idCustomization)) { $result = (int) Db::getInstance(_PS_USE_SQL_SLAVE_)->getValue( (new DbQuery()) ->select('`quantity`') ->from('customization') ->where('`id_customization` = '.(int) $idCustomization) ); if ($operator === 'down' && ((int) $result - (int) $quantityChange) < 1) { return Db::getInstance()->delete('customization', '`id_customization` = '.(int) $idCustomization); } return Db::getInstance()->update( 'customization', [ 'quantity' => ['type' => 'sql', 'value' => '`quantity` '.($operator === 'up' ? '+' : '-').(int) $quantityChange], 'id_address_delivery' => (int) $idAddressDelivery, 'in_cart' => true, ], '`id_customization` = '.(int) $idCustomization ); } // refresh cache of static::_products $this->_products = $this->getProducts(true); $this->update(); return true; } ```

It seems like it works for me, I dont understand I guess what you're saying. I can add, and delete items in the cart with no issue. If this fix isn't the correct solution, at least we know the function causing the issue, and you can fix it. I made a video about it, but cant seem to share it here anymore. ;( Maybe this will work.. https://vimeo.com/250966125