tb_cart having non-existing id_carriers

[30knees]

Hi,

I am having some weird behaviour. Some orders are displaying in tbcart idcarriers that don't exist. This does not affect tb_orders.

I have these carriers:

In the database under tb_carriers I have all these entries:

Question 1: Can I delete the ones that don't exist anymore?

But in tbcart some orders have three figure idcarriers:

Because the idcarriers for idcarts 307, 317, 319 don't exist, I'm getting problems where some action relies on the idcarriers entry in tbcarts.

Question 2: Does anyone have an idea where these idcarriers could be coming from/getting into tbcart (and not into tb_orders)?

Of the three carts, one was non-ordered/abandoned and two were PayPal orders using @mdekker new PayPal module (no idea whether coincidence or not - other PayPal orders have been processing fine).

[Traumflug]

Wow, 23 carriers and only 5 in use.

Without looking at the code, my guess is that carriers never get really deleted, but marked as deleted in the database. This way they stay available for older orders, which used these no longer existing carriers back then.

If you have no orders, yet, I see no reason to not delete them. Looking at the deleted flag in the tb_carrier table might give some insights.

[Traumflug]

Regarding these three-digit carrier IDs we'd need a description on how to reproduce them. It looks like a bug, but one without a magic 'Fix Me' button.

Could you try to describe what you did to get these? The more precise, the better. Developers can only fix what they see.

[lesley]

@Traumflug You are correct about the deleted carriers, the carriers always stay in the database so they can be correlated to older orders.

[30knees]

Thanks, guys. I cleaned up the database.

@traumflug That's the problem. The orders were untouched by me. The only commonality I see is that they were processed using the beta PayPal module.

[Traumflug]

@mdekker, these three-digit carrier IDs are in table tb_cart. I take there's no actual carrier with such a number. Apparently a problem when a carrier gets selected/added to the cart.

[30knees]

@traumflug said in tb_cart having non-existing id_carriers:

@mdekker, these three-digit carrier IDs are in table tb_cart. I take there's no actual carrier with such a number. Apparently a problem when a carrier gets selected/added to the cart.

Correct, there is no carrier with those three digits.

[30knees]

@mdekker said in tb_cart having non-existing id_carriers:

Don't delete old carriers. The software breaks if you do so.

I did already, unfortunately. What exactly should I pay attention to to make sure nothing is broken?

[lesley]

Old orders. It is used for associating carriers with old orders and old invoices.

[30knees]

I checked the database to make sure there were no new three digit IDs before processing orders.

There were two new ones, all PayPal orders. @mdekker Is there no way that the new beta PayPal module could be doing this?

[roband7]

The code in the paypal 6 module, in controllers/front/expresscheckoutconfirm.php, function assignCartSummary(), the assignment: $cart->idcarrier = arraykeys($deliveryOption)[0]

Could that be the problem? Other code in core that picks the id_carrier from deliveryOptions does it differently.

[30knees]

@roband7 Thank you for not giving up and checking the code!

I'm happy to test the beta module again once this has been fixed.

[30knees]

Now I got an order with tbcart's idcarrier 0 (doesn't exist). In tborders the idcarrier is 29 (correct).

[30knees]

It's a totally normal address and the same as many others I've shipped to, nothing wrong with it. How can I try to figure out why the system might have marked it as not shippable?

[30knees]

That's odd, I don't have the file. I just uploaded the new beta2, never touched any files.

[30knees]

Also, I'm not using PayPal Express. In addition, though, the update doesn't install all files on my server: https://forum.thirtybees.com/topic/1095/paypal-6-0-0-beta-1-the-final-push-for-victory/52