carrier errors

[dotray]

This occurred after playing with the ranges, switching Carrier billing weight to price and back & saving.

I get a "Error thrown: [object Object] Text status: parsererror'" when trying to save some edits to carrier.  Ranges don't change when I think I successfully saved it.
I deleted/readded the carrier and now the carrier name and transit time is missing from the checkout page.

I think it's a PS bug that no one fixed until recently.

https://github.com/PrestaShop/PrestaShop/issues/12577#issuecomment-473379889

[toplakd]

Same happened to me a while ago. Got the same error.

Was unable to solve it, so I deleted the carrier and created new one with same settings which worked ok. (TB 1.0.8 migrated from PS)

[dotray]

Deleting the carriers didn't fix everything for me.   The name/transit time still doesn't show up.

I also noticed new rows being added to tb_carrier each time I edit the carrier; same with the 30bz demo.

[musicmaster]

That new rows are added to tb_carrier is normal. That way when you change your carrier prices existing orders aren't affected.

The Prestashop bug you mentioned has a fix: https://github.com/PrestaShop/PrestaShop/pull/12946/files

Did you try implementing that in your Thirty Bees file? Instead of line 695 you should read line 1089.

[dotray]

Ya I don't really know my way around github so I found the pull link afterwards.  Had to change the vars because I couldn't save the upper range but switching the billing price/weight back and forth is fine now.

                $range = $carrier->getRangeObject((int) $rangeType);
                $range->id_carrier = (int) $carrier->id;
                $range->delimiter1 = (float) $delimiter1;
                $range->delimiter2 = (float) $rangeSup[$key];
                $range->save();

 

[datakick]

I can also confirm that the fix works. I've picked this change into the next tb version 

https://github.com/thirtybees/thirtybees/commit/51ebfa051ebd330f0d35a873679ca28ff818e2d2