B-O Timestamped images return 404

[Pierrox15]

Hello,

In the Backoffice -> product edit -> Images Tab: Thumbnails got a timestamp like "?time=1568749403911"
The image return a 404 and a default no-image.jpg is displayed.  If I remove the timestamp from the url the image is display correctly.
the problem occur only on this tab. (i

I don't know why, my local web server do that for TB.
I try with modules and overrides disable, Hard cache reset on firefox and reload TB  cache but  it's the same issue.

In many other CMS timestamped resources have no problem and  In my CSS files on front I use timestamp for Fontello icon and it works as normal.

I don't know where I can search for fix that?

 

Edit: in the fancybox,  when i click on this image (exactly the same ressource is called) image display correctly. It's no sense for me 😞

Edited September 17, 2019 by Pierrox15

[Pierrox15]

More tests:

localhost/img/p/2/5/7/3/8/25738.jpg?time=156874940  // (thickbox) hit
localhost/img/p/2/5/7/3/8/25738.jpg // (thickbox) hit

localhost/img/p/2/5/7/3/8/25738-small.jpg //  hit
localhost/img/p/2/5/7/3/8/25738-small.jpg?time=156874940 // 404

 

[Pierrox15]

Hum, I  just create a "small" image in adminImages config and just it works™.

Sry for the inconvenient

[Pierrox15]

So what i understand: they are a rewrite rule who try to do this:

localhost/img/p/2/5/7/3/8/25738-small.jpg -> localhost/img/p/2/5/7/3/8/25738-small_default.jpg

who work but  break on querystring timestamp.

[Traumflug]

Excellent analysis! This timestamp was introduced here:

https://github.com/PrestaShop/PrestaShop/pull/4267/commits/1e1932559758ce989a8d42d931fd650043234d21

to fix this bug:

http://forge.prestashop.com/browse/PSCSX-7050

Such a timestamp doesn't make sense to me. Each image has an individual number, there should be no caching issue (unless one changes the image on the command line or by FTP).

I've reverted this commit, which results in loading the right picture. On Bleeding Edge -> 1.1.x in ~10 minutes.

[Pierrox15]

Timestamp is very usefull, and it will be available on all resources to refresh all cache when it needed. It's the easiest way to control a web cache server 🙂

I don't know prestashop very well... but I think, it will be the job of PageNotFoundController.php to consider querystring at the end of ressource and a .htaccess rules.

 

[danwarrior]

On 9/18/2019 at 6:44 AM, Traumflug said:

Excellent analysis! This timestamp was introduced here:

https://github.com/PrestaShop/PrestaShop/pull/4267/commits/1e1932559758ce989a8d42d931fd650043234d21

to fix this bug:

http://forge.prestashop.com/browse/PSCSX-7050

Such a timestamp doesn't make sense to me. Each image has an individual number, there should be no caching issue (unless one changes the image on the command line or by FTP).

I've reverted this commit, which results in loading the right picture. On Bleeding Edge -> 1.1.x in ~10 minutes.

You saved me again. Thanks so much!