Jump to content
thirty bees forum

wakabayashi

Silver member
 View Profile  See their activity

  • Posts

    2,018

  • Joined

  • Last visited

  • Days Won

    168

 Content Type 

Posts posted by wakabayashi

    Need a little help on a 500 Error im stuck

    in English

    Posted

    No problem. I understand. You need to adjust your theme. What theme are you using?

    Edit: you use community-theme-default. 

    Have you tried to update your store to bleeding edge? Search the menu "core updater" and select "bleeding edge" and "1.1.x". Then upgrade. That way you get a lot of bugfixes.

    Canelis - high quality catfood

    in Feedback on my store

    Posted

    8 minutes ago, datakick said:

    That means you only need to clear cloudflare cache when you edit js/css files. And if you enable CCC, you don't need to worry about this as well. 

    I can confirm that. I had never a single issue on anyting with php. Of course when you develop on js and use ajax you need to be a bit careful to delete the cache. But in general I am very happy with cloudflare.

    Shop Now Link

    in Themes

    Posted

    From this screenshot I have no idea, where it comes from. Please show a bigger screenshot. So expierenced user will know, which module is relevant.

    Edit order, update shipping

    in Technical help

    Posted

    50 minutes ago, datakick said:

    even when Recalculate shipping is false, there is some recalculation performed. For example, newShippingCostTaxExcl will be updated according to current carrier settings tax settings. That shouldn't happen -- in fact, I would not call the new updateShipping at all in this situation

    I will look again into this. But IMO this is not the case. It's true that 'updateShipping' is called always. This is because you can set a fixed amount of shipping. If you don't change this value and don't select recalculate, there is an update but with just the same values as you already had in DB.

    52 minutes ago, datakick said:

    when shipping is modified, then existing invoice would be updated. At least in my country this is very serious issue -- invoices send to customers must be immutable, and all changes should be done by new (corrective) invoice only

    In my country this is a bit different. But I am aware that this can be an issue. That's why I created the form in the second commit. The form allows me to add an "invoice select". So every merchant can select the invoice, which should be updated.

    54 minutes ago, datakick said:

    There is an issue with carrier selection -- if carrier was modified since the order was created, it will have different id_carrier (but the same id_reference). The original id_carrier will not be part of rendered carrier list, and therefore will not be pre-selected 

    Right. I completly forgot about this shitty id_carrier change. But I believe, if I just add the "deleted/changed" carrier to the selector as well, this should be solved.

    Edit order, update shipping

    in Technical help

    Posted

    2 hours ago, datakick said:

    It will have to be thoroughly tested before it is integrated to the core, obviously.

    I understand ofc. We are already using it in our live store, but ofc other testers are needed.

     

    2 hours ago, datakick said:

    One thing that would be nice to implement together with this functionality would be an audit log, so merchants could see why, when, and by whom was the order modified

    You mean in AdminLogs or something new? If it would be new, I believe we would better make a order history concept, that shows everything (like order status change, emails sent, customer messages, customer service cases) in a nice history tree or so.

     

    Have you briefly looked at the concept. How do you think about this: 

    "Technically a new cart is created based on the order values. The cart is used then to recalculate the shipping cost."

    • Like 1

    Edit order, update shipping

    in Technical help

    Posted

    I have invested another day. It's now possible to add fixed a fixed amount/weight. Also the hardcoded transit email can be fixed that way. 

    Still my code is not totally finished:

    • There needs to be validation check in the new updateShipping function.
    • RMA seems to use "submitShippingNumber" as well. That's maybe not problematic. I don't use RMA at all. So no idea what this should do. 

    After a click on edit, the form looks like this:

    shipping-update.JPG

    Btw: For me this project is quite evident. My goal is clearly to push this into the core (after careful validations with merchants). If this doesn't workout, I won't supply anything in the future. Cause developping things for core, which doesn't get applied, is too costly:

    1. I invest a lot of time to be consistent with the core, if it's only for my own store, all is much faster and simpler.
    2. After a modification get declined, I have to rewrite again, since I need to use the code in an internal module instead of core.
    3. If this important (and much wanted) feature can't be implemented, I lose faith, that there will come any real progess on other topics (like asm, attributes on bundles/virtualProducts and so on...).
    • Like 3

    Edit order, update shipping

    in Technical help

    Posted

    @RabbitZzZ, @toplakd, @datakick

    As I get mad almost once a week about the misssing "update shipping cost", I decided to tackle this myself. I couldn't wait any multiple years longer for this feature. In my opinion it's over due... As we pointed out above, there is no super clean solution to this problem, but I believe that my solution now is quite acceptable. At least it's much a cleaner way than the free PS module uses. 

    Technically a new cart is created based on the order values. The cart is used then to recalculate the shipping cost.

    I practice you can select the shipping method in an order and click on "recalculate shipping cost". This is very useful in case you have edited the order before. The select also allows to change the shipping method at all. This way you can change, in case your customer wishes so or you can also select a shipping method, that is only visible in the BO.

    I haven't imlemented a amount input yet, but that would be possible too. I hope, that some expierenced user test my snipped (in a test store) and give a feedback. It's really hard to forseen every case. In my (quite simple) cases, the code seems to work properly.

    https://github.com/eschiendorfer/thirtybees/commit/4ccd64465ff1e4b956e1caba1feb411b6ee834a3

    • Like 3
×
×
  • Create New...