Jump to content
thirty bees forum

Chandra

Members
 View Profile  See their activity

  • Posts

    192

  • Joined

  • Last visited

  • Days Won

    1

 Content Type 

Posts posted by Chandra

    Bug in Thirtybees Marketplace Module download

    in Bug Reports

    Posted

    Creating a new release of a module on github was supposed to pull the new version onto Thirtybees marketplace, but actually breaks the link and redirects to marketplace home. I notice it on several modules.

    e.g.: My module download worked until I created a new release. Try logging in to marketplace and clicking download button on this page: https://store.thirtybees.com/shop-modules/front-office/block-in-stock-products

    [Free Theme] Niara - Thirty Bees theme

    in Themes

    Posted · Edited by Chandra

    I dug a little more with the Community theme and the Niara themes.

    The community theme has this nice feature to show a message similar to "Product available with different options" when the product has multiple combinations and one of them is in stock, both on the product list and product pages (pics - I have tweaked the translations a bit). This seems to be missing in Niara, which is otherwise a lovely theme a lot of us have adopted.

    A couple of questions:

    @tommat Would it be possible to kindly port this feature to Niara? It would be a great addition if so.

    In general, can I also ask TB team if both community and Niara themes will be maintained or if there is guidance to use one over the other?

    Edit: I will answer my own question for anyone else looking for this feature.

    I found the code is also available in Niara and the messages are being hidden in css. You can show these messages by adding the following lines to custom code. 

    .product-actions-container .availability {
  display: inline;
}
#availability_statut {
    display: inline !important;
}
.label-success {
    display: none;
}
.label-danger {
    display: none;
}

     

    Possible bug: Order status 'Attach Invoice PDF' option is not respected

    in English

    Posted

    1 hour ago, toplakd said:

    Than you can set "payment accepted" status to not attach the invoice to the order confirmation for orders which are automatically marked as payment accepted.

    It is already set that way. Let me explain.

    1. Customer creates cart.
    2. Customer chooses either COD or Online payment module and confirms order.
    3. If COD -> Order status is 'Processing in progress'.
    4. If Online paid -> Order status is 'Payment Accepted'.
    5. Both statuses have been set to not attach invoice to order  confirmation email.
    6. However, both order confirmation emails have attached pdf.

    Hope that clarifies.

    Possible bug: Order status 'Attach Invoice PDF' option is not respected

    in English

    Posted

    Thanks all.

    3 hours ago, datakick said:

    ...you are mixing two things.

    The settings on Order Statuses has impact on 'Order Status Changed' email only (ie. Awaiting bank wire email)

    What you are talking about is the 'Order confirmation' email, and that has nothing to do with order status. This email is always sent, and it contains all current information available.

    I guess we could change the current semantics, and attach invoice to 'Order confirmation' email only if current order status has the send invoice checkbox enabled. However, I'm sure there would be plenty of merchants that would not want this behaviour by default.

    In my head, a new order meant an order status change from nothing to one of Processing/Payment accepted/Awaiting check payment etc. Hence I had thought the pdf checkbox would be respected.

    My view is that it should be an option to be respected, even if it defaults to yes since you reckon most merchants want it that way.

    To me, having the same content in the email body and the pdf is no additional value to the customer. I note the pdf delays order process by a few seconds (you will remember I was trying separately to make it faster by queuing up emails even).

     

    1 hour ago, toplakd said:

    Yes, the pic Chandra added to github, was showing Order Processing status, so we all checked if issue was in statuses.

    You should have told you are talking about Order confirmation email, that would have saved us some time spent on searching for issue that is does not exist.

    If you don't want to attach any invoice to the customer (even if you have invoice checked in status messages), you should disable invoices.

    And if invoices are enabled, it's only attached to "order confirmation" email if it was generated, this means, if paid with bankwire, and status is "awaiting payment" then no invoice is attached to "order confirmation" email as invoice was not yet generated.

    This issue is not an issue, its designed to be so.

    So, if invoices disabled, there is no invoice attached to confirmation email.

    However invoices do get generated once status is changed, and attaching invoices are then operated with the checkbox under status messages.

    Case closed.

    Sorry you had to take the trouble. Please see my explanation above on why I thought/think it should be related to the status.

    Disabling invoice for a status does not let the customer download it. I only think it makes sense to have an option to not to email it by status when the same info is in the email body.

    If it is the design, I request we review it.

    Possible bug: Order status 'Attach Invoice PDF' option is not respected

    in English

    Posted · Edited by Chandra

    I still have the invoice attached to the customer email. I have reconfirmed Attach invoice PDF to email is unchecked for the order status.

    Code base: up to date (bleeding edge)
    DB: Up to date
    Overrides: None relevant
    I have mailalerts module installed if that is of any significance

     

    @datakick @toplakd @wakabayashi

    Can any of you give me a hand on which file generates the email so I can dig a bit.
    I looked up the classes folder - Order related php files and did not find code that actually sent the email. Thanks.

     

    attached-pdf.png.832b5a92297793f5d566832e70e6fb35.png

     

     

    Possible bug: Order status 'Attach Invoice PDF' option is not respected

    in English

    Posted

    1 minute ago, toplakd said:

    For hunting down small bugs (or my mistakes) I always have 3 installation of thirty bees on the server. All latest bleeding edge

    One is live, one is exact copy of live shop for testing, and 3rd is always the clean stock thirty bees installation.

    So if something does not work on live but it works on stock install, i can compare testing shop with clean stock, and make adjustments or fixes until it works 100% like stock.

    Only after that, I apply it to the real live shop.

    Good plan.

    I never got to set them up but will do shortly.

    Possible bug: Jumpy invoice numbers

    in English

    Posted

    Invoice numbers occasionally jump up and don't sync with the Order numbers.

    The reason seems to be duplicate order lines in the following tables:

    tb_order_carrier
    tb_order_invoice

    This seems a case of creating a new order line than updating the existing one in specific cases?

    [Free Theme] Niara - Thirty Bees theme

    in Themes

    Posted

    On 1/20/2020 at 10:20 AM, Chandra said:

    ..., TB has a feature to alert the customer that a different pack size/combination is in stock when a different combination is clicked.

    I don't see that working on my Niara based shop. Can you please advise if this is a theme thing and can be fixed easily?

    I wanted to bump this topic to see if anyone sees this issue and have a way out.

    I think the right behavior would be for products with at least one attribute in stock to show the 'Add to cart' button and then lead/let the user select an available attribute on the product page.

    Currently it simply says the product is out of stock even if some attributes are in stock.

×
×
  • Create New...