-
Posts
3,035 -
Joined
-
Last visited
-
Days Won
465
Content Type
Profiles
Forums
Gallery
Downloads
Articles
Store
Blogs
Everything posted by datakick
-
Version 1.4 is here with PHP 8.+ support!
datakick replied to Smile's topic in Announcements about thirty bees
You have to configure your php server error reporting. Access logs are nice and all, but totally useless for troubleshooting. For that, we need error logs. This is the template that works with old version of homeslider module. If you have newest version, you have to adjust your theme template accordingly. Look at the changes in niara for inspiration: https://github.com/thirtybees/niara/commit/15e5338e628fca184a339d6cde66c961bfeb8169 This was fixed a long time ago. Update your themeconfigurator module to newest version. Make sure you are using thirty bees variant -- if the author is prestashop, delete the module, and install it again from tb repository. -
There's no simple solution, it's a name conflict. One of the implementation will have to change the name. This time, the conflict is between core and module. But it could very easily be conflict between two modules, if they both use same names in global namespace. Module authors should be careful to not pollute global namespace much. If they need to do so, they should use some prefixed variables. For example, i used 'revwsData' for my only global javascript variable in my revws module. This variable is an json object of other variables. There is very low chance for conflict this way. Declaring global variable 'displayPrice' was not very smart. It was not smart by AWP module author. And it was not smart by tb developers to declare this new function in global namespace as well. But what's done is done. I'm not sure what tb modules and themes adopted this new javascript function, so it would be quite risky to move it to some namespace now. You can ask module author to change their implementation, as nothing depends on that.
-
In xml, the language attribute contains iso code. When you import data to your thirtybees, you have to map these iso codes to language internal IDs. On every installation these ids can be different, depending on order in which you have installed the languages. That's one of the reasons why revws did not put language id into the xml file in the first place. When mapping 'Revws ID Language' field to xml file: 1) click on Advanced mapping 2) Then select attribute "language" from <Reviews> node: 3) Then click on 'Add new transformation', and select 'Find record' -- this will allow you to search for language using iso code stored inside xml attribute 4) select Languages and ISO code And that's it. During import, datakick will take value 'de' from xml file , use it to find Language by iso code, and store language primary ID inside revws Language ID field.
-
Thanks, fixed in bleeding edge.
-
I'm not really sure if your problem is caused by smarty. To replace smarty, you can download previous version of thirty bees from here https://thirtybees.com/download-specific/ , unzip it, and copy /vendor/smarty directory into your installation. That might be enough (or it will break your store). Backup the original /vendor/smarty somewhere.
-
Awesome. I'm personally using Redis as a caching engine, and it works like a charm. I opted for Redis because I deploy components on different digital ocean droplets - mysql and redis run on different server than php. For people running everything on single server APCu will probably be a faster and simpler solution. It might be less stable solution when server is under heavy load, but generally it should work fine. Regarding FPC -- it can be great solution if your store does not contain a lot of dynamic data. If you tweak it correctly, punch the right holes for right hooks, it can be blazing fast. Problem is that nobody can tweak it correctly unless they look into modules code. Smarty cache invalidation, on the other hand, is governed by modules themselves. Module author is responsible for proper cache handling, and they usually do it right. For most folks, using smarty cache should be go-to solution.
-
Hi everyone, We have just pushed new functionality into bleeding edge, and I would like to ask for testing if possible. We have added another option for smarty caching engine -- beside 'File System' and 'MySQL', you can now choose to store smarty cache inside Server Side Cache: When enabled, thirty bees will use cache implementation selected in Server Side Cache section: The most interesting options are Redis and Memcache -- these are extremely fast in-memory key-value stores. Please test and let me know if you find any problems.
-
Never seen issue like that. There were no changes in hook execution/evaluation in 1.4.0. Maybe this is related to smarty library update.
-
Seach fails in Blockwishlist fails under 1.4.0/php 8.0
datakick replied to Ian Ashton's question in Bug Reports
This has been fixed in https://github.com/thirtybees/community-theme-default/commit/017ebd1a72336d043b26f383984e67a0254a3f63 Either update your theme to latest version, or manually apply the fix.- 1 reply
-
- 1
-
All purchase_supplier_price in order_detail table wrong!?
datakick replied to wakabayashi's topic in English
When you look at code usage of purchase_supplier_price, then it looks like the amount was supposed to be stored in order currency. For example, AdminStatsController divides the amount by conversion rate. However, usage of `original_wholesale_price` is more complicated (and buggy). For example, statsbestcategories: IFNULL(SUM( CASE WHEN cp.`original_wholesale_price` <> "0.000000" THEN cp.`original_wholesale_price` * cp.`product_quantity` WHEN pa.`wholesale_price` <> "0.000000" THEN pa.`wholesale_price` * cp.`product_quantity` WHEN pr.`wholesale_price` <> "0.000000" THEN pr.`wholesale_price` * cp.`product_quantity` END ), 0) / o.conversion_rate AS totalWholeSalePriceSold this does sum of all original_wholesale_price if exists, or wholesale_price from product if not. This sum is then divided by conversion rate, suggesting that the amount should be in order currency. However, in product cuntext, the amount is stored in default currency. So this stats never worked again. I suggest we fix this as well, and save original_wholesale_price in order currency as well. Then let's fix the stats sql -
Litespeed cache module stopped working today out of nowhere
datakick replied to the.rampage.rado's question in Module help
This is nice bug. Calling __destruct on connection instance make this instance unusable, but does not remove it from connection pool. Sequence like this would fail: Db::getInstance(_PS_USE_SQL_SLAVE_)->__destruct(); Db::getInstance(_PS_USE_SQL_SLAVE_)->execute('select * from table'); Tracked in issue https://github.com/thirtybees/thirtybees/issues/1600 -
Probably override in your theme. Read here:
-
Again, there is NOTHING to fix here, from the thirty bees perspective. Thirty bees / ps16 always performed geolocation using maxmind database. Because maxmind stopped supporting database version 1, we had to fix it. When we were doing that, we though that it's a good thing to make this 'detect country' functionality pluggable, instead of depending on single implementation. So we extracted it to separate maxmind geolocation module. We support both this new module, and geolocation functionality in core core. If you use these two together, you will have the same functionality that always existed. This new pluggable architecture allowed ME (not thirty bees) to create another module that gets the geolocation information from cloudflare. This module is mine. I made it myself, in my free time. It is new functionality. It is not part of thirty bees native modules. From thirty bees perspective, this is just ordinary module by third party developer. You don't have any rights to go on this forum and demand changes to that module. It is absurd. It is like you creating a new issue in thirty bees project demanding changes to Panda theme.
-
You are mistaken. I have not marked this request as an enhancement. I have simply closed it as an invalid request. There is absolutely nothing to implement in thirty bees core here. Core does not know anything about individual geolocation modules, and therefore it can't check if those modules are correctly set up. That check should be responsibility of individual modules -- if not configured properly, module can simply not offer itself as an geolocation option. Your request is basically an enhancement request for my free CLOUDFLARE GEOIP module. Thirty bees core issue tracker is not the right place to submit enhancement requests for third party modules. That's the reason why I closed the issue. Nevertheless, I copied your request to my personal to-do list. This is module that I have implemented in my free time, and I offered for free on my website to the community. As a free module, it was released "as it is". I agree that your proposed enhancement make sense. But it has very low priority, especially since most users didn't have any problems settings things up. This is not a bug in the module, it works nicely if you setup cloudflare correctly (and have no intermediate proxy that might block these http headers). I have a big backlog of more pressing issues for my premium modules that have priority, and very little time to work on those. If this is really a pressing issue for you maybe you could try to fix it. After all, it's just "simple to do since its just data in a header."
-
Indeed, this was javascript bug. I've released new version 0.9.1 that fixes this one.
-
Error version 1.4 with PHP 8.0
datakick replied to Oncle's topic in Foro en Español - Discusión General
Both modules runs without problems even on PHP 8.2 As I wrote before - this looks like a theme issue. Your theme overrides template for these modules, and these overrides are causing issues. -
It's true that bleeding edge is not intended for production use. I personally use it on my production server, but that's because I know what I'm doing, and I'm fine with the risk 🙂 Bleeding edge changes quite often, and sometimes it contains some new bugs. This version should be deployed to testing environment, if you have any. If not, I strongly suggest you to create one -- so you can continuously test the upcoming release, and see if you are in need for any modifications. And provide feedback to us if you encounter any issue, so we have a chance to fix it before official release. For production, I recommend you use 1.4.x branch -- it can be found in 'Custom target'. This is bleeding edge for upcoming bugfix release 1.4.1. The diference between main (bleeding edge) and 1.4.x is that main contains bugfixes, new feature work, refactoring, code maintenance, etc. On the other hand, 1.4.x receives only well understood bug fixes. There are no new features or refactoring that could cause unnecessary troubles. One could argue that 1.4.x is more stable than stable release 🙂
-
Error version 1.4 with PHP 8.0
datakick replied to Oncle's topic in Foro en Español - Discusión General
What module is causing you trouble? Who is the module author? Did you report this issue, are developers aware of the problem? Are they still actively supporting/developing this module? If you are talking about this problem: then it's not a module issue, but theme one. You are using outdated community-theme version. You should update to new version. Core updater can help you with this, unless you modified the theme yourself. This particular problem was fixed by this commit back in September 2020: https://github.com/thirtybees/community-theme-default/commit/e8aaf3632640d8df85e6ca1074878d4b80d008a0 -
Error version 1.4 with PHP 8.0
datakick replied to Oncle's topic in Foro en Español - Discusión General
What module is causing you trouble? Who is the module author? Did you report this issue, are developers aware of the problem? Are they still actively supporting/developing this module? -
Go to Core Updater settings page (either click on Configure from Module list, or open core updater and click on Settings in upper right corner), and in distribution channel choose Bleeding Edge.
-
Yes. Fix is in both bleeding edge, and 1.4.x (bleeding edge for upcoming 1.4.1 bufix release)
-
Error version 1.4 with PHP 8.0
datakick replied to Oncle's topic in Foro en Español - Discusión General
Yes, it's normal, unfortunately. While thirty bees core is PHP8 compatible, many third party modules are not. New major versions of PHP bring breaking changes, which means that PHP code have to be updated. Users are warned about these breaking changes in advance by PHP deprecation warnings (while you are still running on lower versions of PHP). Unfortunately, not so many people looks inside their server's error log. I recommend this flow: update your store to thirty bees 1.4 still use PHP 7.4 install collectlogs module use your store for few days/weeks continuously watch Advanced Parameters > Error Logs. You should fix every Error/Warning/Deprecation. You can ignore notices, for the time being. once you fixed all issues, and no new warning was found for a few days, you can switch to PHP 8.0 watch error logs for few days, if everything is ok, upgrade to PHP8.1 do NOT update to PHP8.2 yet, as it is not supported by tb 1.4. Support will be added in 1.5 -
Hi, xml backup file generated by module can be imported using datakick export/import module, as it supports reviews data. Alternatively, you can open this xml data in excel, and transform it to csv format. Or dump tb_revws* database table and import them using phpmysql tool. Note that in all scenarios you will have to make sure your product ids and author ids matches in both systems, or map them manually.