short descriptions invisible in list view of category-catalogs

[Ulrich]

version 1.0.4 RC , warehouse-theme , PHP 7.0 I do not know if this also applies to version 1.0.3: If i import articles with short descriptions with a csv file, in the category-catalogs in the grid and table views the name of the product is displayed, in the list view the name of the product and also the short description is displayed, but ONLY if there is NO reference to an image and instead the default no-image-available-image is loaded. If I open and save an article in which the short description in list view is displayed (one of those without a picture) in the BO and save it again, short description will no longer be displayed, even if i don't change anything in the editor. The reason is that within

"short description" </ p> another pair

</ p> is inserted when i open the article in the BO or if a picture is referenced to the article, like this:

"short description" </ p> another pair </ p> and therefore "short description" remains invisible :-(

[Ulrich]

@zimmer-media But truncate means only counting of charakters to 360 (or any other length, cut the rest and delete it. It's not related to this dilemma of “

” … “

” inside “

” … “

”. striptags will remove inner pair of p and make descriptionshort visible, but no chance for text formatting. I think, clean solution will be to prevent adding this inner pair of p tags.

[zimmer-media]

sorry my mistake i mean "strip_tags" - its tooo late

[wakabayashi]

@Ulrich

To be honest, I haven't read trough the whole thread, but I guess this is kind of an easy problem. Do you want to have some HTML in your short_description?

If yes, then try this. Change: ```

{$product.description_short}

To:

{$product.description_short}

```

[wakabayashi]

@lesley

It seems to me a very bad practice to put short_description between

... I have noticed the same in my theme right now. How do you think about it?

[Ulrich]

@wakabayashi Yes, i want some HTML in my shortdescription, therefore i changed {$product.descriptionshort|striptags:'UTF-8'|truncate:360:'...'} to {$product.descriptionshort} as you suggested. This doesn't work and make descriptionshort invisible because if i add add a picture to an article in editor or open and save an article in editor for another reasaon, editor will enclose descriptionshort with

...

[wakabayashi]

@Ulrich I am not sure, if I understand you right. Have you tried the "div" thing? Is your site live? If yes, a link would be helpful...

[Ulrich]

What “div” thing? Site is online, but in maintenance mode. Can give you login to include yourself in IP-whitelist.

[wakabayashi]

Look at my post above. I told you to replace the

with

. This has to be done in your product-list.tpl file.

[lesley]

@wakabayashi Not really, here is the idea. It is in p tags so it can be targeted effectively. Also by default, we strip the html out of the short description. The mess of the change between list view and change between grid view uses a lot of javascript to target and move things, so not having it in a p tag would make it impossible to target and adjust that layout.

[wakabayashi]

it doesn't matter, if you use a p tag or div tag. Just target it by id or class... With a div tag you give the people the chance to use HTML. Otherwise I don't see a reason to offer an html editing field in the backoffice...

[lesley]

A lot of it has to do with the location. The short description is more versatile than the long description. The long description displays in one spot, the bottom of the product page. The short description displays in several spots, it can be displayed in any product-list, category pages, on the product page, ect. For flexibility, it could be changed to be in a div tag, but it would require people to update their themes. Also, it does help keep a site consistent. People tend to mark things up and use large fonts when allowed and it makes category pages look bad.

[wakabayashi]

Yeah, I completly agree with that. I wouldn't recommend to use HTML in short_description. But still I see no real reason, why not use a

in 2.0.

Maybe for some merchants it makes sense, to use some HTML in it. Maybe just making something bold or cursiv. Or putting a link.

[lesley]

It would still need p tags for wrapping.

[Ulrich]

@wakabayashi Changing of

to

works perfectly for my basic formatting (strong and br), many thanks for your help!

@lesley If I understand you correctly, the descriptionshort should be enclosed in p tags. When I create products manually, the editor does it in the background. If I import descriptionshort with csv, do you recommend including it with p tags before importing? Because there is no reason to edit the articles manually afterwards and the p-tag would be inserted only after manually creating an article when closing the editor.

[Briljander]

I haven't read this through totally but I had problem with this because of TinyMCE and had to update it to solve the problem.