cprats Posted October 27, 2018 Posted October 27, 2018 I've found another slowness. I run TB1.0.7 migrated from PS1.6.1.20 and the problem also reproduced under PS. See if it can help to identify any fault: When I click on Advanced Parameters -> Configuration Information the loading time is large. Here a profiling: Doubles seem to be OK: But meanwhile, in the server: When the page finishes loading, I/O Usage and IOPS return to normal values. I'll be happy if this info helps to find a possible bug, and I'll be happier if it can be solved. Additionally (and surely not related to this issue) the Changed/Missing files in Configuration Information warns about this missing file: public_html/administrationfolder/autoupgrade CC: @datakick
lesley Posted October 27, 2018 Posted October 27, 2018 Dekker fixed that page as best he could, but it needs all of that I/O. Basically what that page does, is it on demand checks all of your core files to see if there are any edits to them, then produces a list of the files that are edited.
Traumflug Posted October 28, 2018 Posted October 28, 2018 Phew. 56 seconds to go through all the files. For comparison, here's what I get in my development setup: about one second. And that's with an additional test searching for obsolete files already. This said, doing these tests is the whole intention of this page. They run only there, customers never see this. And merchants only when doing shop software maintenance.
datakick Posted October 28, 2018 Posted October 28, 2018 This is very strange. There's absolutely no reason why AdminInformationController should take so much time to load, as there's no business logic inside initContent method at all. Missing files list is generated after the page is loaded using ajax call. @cprats - is it possible that you have override installed for this controller? If you have migrated from ps16, it's possible. To check, you can install thirtybees Override check module to see what overrides are installed on your server.
cprats Posted October 28, 2018 Author Posted October 28, 2018 No overrides for this controller, but I've found 155 overrides of a module (Marketplace, by Knowband) I used a couple of years ago but not longer in use and even deleted. What a mess! Also, there is an override for nocaptcharecaptcha module, which I uninstalled after testing it. Is it safe to delete all these overrides?
datakick Posted October 28, 2018 Posted October 28, 2018 You should definitely delete all overrides from modules that you no longer use. I recommend you backup /override directory first, just in case something goes wrong.
cprats Posted October 28, 2018 Author Posted October 28, 2018 @datakick the problem was the Knowband Marketplace module old overrides. I've deleted all of them using the Override check module, and I've also had to delete manually a folder: override/classes/marketplace with 17 files: index.php, KbEmail.php, KbGlobal.php, KbPerProductSellerShipping.php, KbReasonLog.pgp, KbSeller.php, KbSellerCategory.php, KbSellerCRequest.php, KbSellerEarning.php, KbSellerMenu.php, KbSellerOrderDetail.php, KbSellerProduct.php, KbSellerProductReview.php, KbSellerReview.php, KbSellerSetting.php, KbSellerShipping.php, KbSellerTransaction.php. I list them here for knowledge base purpose. Now I/O Usage values are normal. Profiling gives a more reasonable load time, but still the double of that shown by @Traumflug : Thanks to you all. I've learned more in 20 days in this forum than in six years in the PS forum.
Traumflug Posted October 28, 2018 Posted October 28, 2018 Missing files list is generated after the page is loaded using ajax call. Oops, entirely missed this fact. It works so fast I never noticed. Response time 775 ms here.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now