Panda theme: Volume discounts for combinations shown excluding taxes instead of with taxes

[30knees]

Update: This is a Panda theme issue.

Problem:

I have a product with a combination. The price for 1x is 10 incl. taxes. This is displayed correctly.

Starting at 5x the price is set as 9 incl. taxes. It should show 9 incl. taxes (which would be 8 excl. taxes). However, it shows 8 excl. taxes.

It's misleading for customers, understandably. 

Edited November 9, 2020 by 30knees
Update

[datakick]

I can't reproduce this issue. Could you please provide some screenshots, both from the admin and frontend?

Note that this might be theme issue

[30knees]

Thank you for helping out.

Admin specific price:

Combination standard price:

Frontend price standard:

Front end price with volume discount 2x:

Shopping cart price for volume discount 2x (this is your Chex module):

17.02 / 2 is 8.51, which is the displayed volume price above plus tax.

[datakick]

I've re-tested with your numbers and it works fine for me.

I guess this is either theme issue, or you are using old thirtybees version.

 

[30knees]

Thank you, datakick.

I'm using the Panda theme. @JonnyAre you aware of any issues as described above? I have version 1.5.5.

[30knees]

Yes, it is the theme. I tested with the community template and it works perfectly fine there. 

[datakick]

Try to upload js/product.js from community or niara theme to panda to see if it fixes the problem. 

Back up the original file, of course

[30knees]

Unfortunately, it didn't work. It also prevented the product photo from displaying when I did that. I used the community theme to do so. Thank you for the tip, though!

[haylau]

Have you reported this directly on the sunnytoo forum?

[datakick]

This is indeed bug in product.js file, function updateDiscountTable. Change it from:

function updateDiscountTable(newPrice) {
	$('#quantityDiscount').find('tbody tr').each(function() {
		var type = $(this).data('discount-type');
		var discount = $(this).data('discount');
		var quantity = $(this).data('discount-quantity');
		var discountedPrice;
		var discountUpTo;

		if (type == 'percentage') {
			discountedPrice = newPrice * (1 - discount / 100);
			discountUpTo = newPrice * (discount / 100) * quantity;
		} else if (type == 'amount') {
			discountedPrice = newPrice - discount;
			discountUpTo = discount * quantity;
		}

		if (displayDiscountPrice != 0 && discountedPrice != 0) {
			$(this).attr('data-real-discount-value', formatCurrency(discountedPrice * currencyRate, currencyFormat, currencySign, currencyBlank));
			$(this).children('td').eq(1).text(formatCurrency(discountedPrice * currencyRate, currencyFormat, currencySign, currencyBlank));
		}
		$(this).children('td').eq(2).text(upToTxt + ' ' + formatCurrency(discountUpTo * currencyRate, currencyFormat, currencySign, currencyBlank));
		// $(this).attr('data-real-discount-value', formatCurrency(discountedPrice * currencyRate, currencyFormat, currencySign, currencyBlank));
	});
}

to

function updateDiscountTable(newPrice) {
	$('#quantityDiscount').find('tbody tr').each(function() {
		var type = $(this).data('discount-type');
		var discount = $(this).data('discount');
		var quantity = $(this).data('discount-quantity');
		var discountedPrice;
		var discountUpTo;

		if (type == 'percentage') {
			discountedPrice = newPrice * (1 - discount / 100);
			discountUpTo = newPrice * (discount / 100) * quantity;
		} else if (type == 'amount') {
			discountedPrice = newPrice - discount;
			discountUpTo = discount * quantity;
		}

		if (displayDiscountPrice != 0 && discountedPrice != 0) {
			$(this).children('td').eq(1).text(formatCurrency(discountedPrice, currencyFormat, currencySign, currencyBlank));
		}
		$(this).attr('data-real-discount-value', formatCurrency(discountedPrice, currencyFormat, currencySign, currencyBlank));
		$(this).children('td').eq(2).text(upToTxt + ' ' + formatCurrency(discountUpTo, currencyFormat, currencySign, currencyBlank));
	});
}

 

In community theme / niara this was fixed by commit https://github.com/thirtybees/niara/commit/e70102d1816aa1af03c2d8ff2b9d446146aa3ff9

 

[30knees]

16 hours ago, haylau said:

Have you reported this directly on the sunnytoo forum?

They changed their login method and I'm waiting for access. I may need to send a follow-up if I don't hear back by end of next week. 

[30knees]

2 hours ago, datakick said:

This is indeed bug in product.js file, function updateDiscountTable.

(SNIP)

Change it from:In community theme / niara this was fixed by commit https://github.com/thirtybees/niara/commit/e70102d1816aa1af03c2d8ff2b9d446146aa3ff9

 

Thank you so much, that's so nice of you to check! Thank you so much. 🙂