Jump to content
thirty bees forum

wakabayashi

Silver member
  • Posts

    1,952
  • Joined

  • Last visited

  • Days Won

    148

Everything posted by wakabayashi

  1. The PR is now in, but it will surely take some time and some changes to be good enough for the CORE: https://github.com/thirtybees/thirtybees/pull/1455 Github says 1412 lines are changed, which can give you an impression, how much time and energy I invested into it. Btw we are using it since a few weeks on our live site and it works fine 😏
  2. What does that mean? I don't understand it. Maybe the M2/M3 thing is the thing that my PR does actually solve πŸ˜… No sorry, I won't do that. I doesn't have a lot to do with my PR and I don't even use the layered navigation module from tb. I have my own one...
  3. V.1.1.0 has been released: https://github.com/eschiendorfer/genzo_branch_tester/releases/tag/v.1.1.0 Here is a very quick preview of what the new system is capabale of. If you test it you will find even more options πŸ™‚
  4. I believe, that this can only be fixed in the theme. Niara uses: {$feature.value|escape:'html':'UTF-8'} If we change it simply to: {$feature.value|escape:'UTF-8'}
  5. 10 years is a long time... I am happy if the next 10 months are safe for me πŸ˜… In general tb developement seems to be more alive than 1 year ago. At least thats my impression on github. I am here since day zero and I don't plan to switch anywhere. If @Smile does the same and holds @datakick here, the thing goes on. We will see how long old PS theme and modules stay compatible with PHP 8 and so. But to be honest: you have this problem anyway. If you stay on PS 1.6 or switch here.
  6. No idea, why this additional weren't implemented multistore ready. Makes not a lot of sense to me. Probably it just got forgotten. When the coder don't work on multistore you can easily forget. I don't have time to fix it, but I can give you a simple (dirty) solution: Open header.tpl in your theme Search for the "</head>" tag. Just before add your code in this schema {if $cart->id_shop==1}/* Your Code for shop with id 1 */{/if} {if $cart->id_shop==2}/* Your Code for shop with id 2 */{/if} {if $cart->id_shop==3}/* Your Code for shop with id 3 */{/if} That was the way I started coding 5 years ago ^^
  7. Thanks a lot Petr! Very interesting, cause when I tested it like 5 minutes on the core before releasing the module. I noticed this issue too. But I don't have it on my live site. I will check it. Cause my intention was also to allow "<br>". The other schema values I will implement as well ☺️ Are you on a clean installation? What I notice on my clean installation. The closing "x" of chosen is not showing up. But I guess it has nothing to do with my work...
  8. I have worked for weeks now, to improve the multiple feature system: Possibility to use displayble (Show a different value from filter value) Usage of chosen plugin in BO Product Form Possibility to add feature values in BO Product Form Possibility to sort feature values and use custom seperators Drop of custom feature values Now it's time to test. PLEASE ONLY DO THIS ON A TEST ENVIRONMENT. The steps: Update your test store with core update to bleeding edge. Install genzo_branch_tester module and click "update". Don't worry: this module won't be needed in the future. It's just for override files and adding an sql table. Go to core updater module and fix the database. Now you should be good to go. Try to play around. Check if it works out with your filter module. With this new version, you can improve the usage of every filter module. How do you like it?
  9. With this informations it's almost impossible to evaluate the issue. Which module are you using? What is the url?
  10. Hard to say. I just turn on the debug mode in BO and it throw out a logical error (for coders). It tries to delete tables that might not be there. That's why I check, if these modules are installed or not... The rest I just wondered: why is this module again needed? Is it about the frontOffice functionality, cause we have a delete button on customers in BO. But I guess it will just delete the core object customer and not any related table.
  11. I dunno, but I get clear error messages when turning on debug mode. Have you used mailalerts/productcomments module before and uninstalled them? This seems to be an issue. The module is in general well structured and the code looks solid. But I think this is necessary: if (Module::isInstalled('mailalerts')) { $queries[] = "DELETE FROM `" . _DB_PREFIX_ . "mailalert_customer_oos` WHERE id_customer = " . (int)$customer->id; } if (Module::isInstalled('productcomments')) { // delete customer from productcomment module $queries[] = "DELETE FROM `"._DB_PREFIX_."product_comment` WHERE id_customer = ".(int)$customer->id; // clean productcomment module $queries[] = "DELETE FROM `"._DB_PREFIX_."product_comment_grade` WHERE `id_product_comment` NOT IN (SELECT `id_product_comment` FROM `"._DB_PREFIX_."product_comment`)"; $queries[] = "DELETE FROM `"._DB_PREFIX_."product_comment_report` WHERE `id_product_comment` NOT IN (SELECT `id_product_comment` FROM `"._DB_PREFIX_."product_comment`)"; $queries[] = "DELETE FROM `"._DB_PREFIX_."product_comment_usefulness` WHERE `id_product_comment` NOT IN (SELECT `id_product_comment` FROM `"._DB_PREFIX_."product_comment`)"; } I added the two if (Module::isInstalled...) in deleteDataFromPrestashop function.
  12. I guess it's allowed then. I can take a short look and see what might cause the problem. But I am still a bit sceptical about deleting customer. What does it mean? addresses? orders? module data? Should this all be deleted? 😊 I doubt that every merchant want the same...
  13. Wow you have even done a video! That's amazing!! Thanks a lot 😍 I did add a link to the first post in my modules thread. Love this kind of "teamwork" πŸ‘
  14. It's correct. If you use the custom hook, you can place it direct at the "category block". Do you know a hook that is this category block? I believe there is just no hook, that does it. That's why I took the footer...
  15. Sure! I would like that 😎 Thanks a lot for your work 🀩
  16. I could convince thirty bees team to add the "discussion" tab on github: https://github.com/thirtybees/thirtybees/discussions I invite all devs to take part, to advanced talks about technical stuff. Note: this should by no way replace the forum. It's just the right place, to discuss advanced technical topics.
  17. I have rewritten this module. Version 2.0.0 is out. It works now out of the box. Download is now available for everyone: https://github.com/eschiendorfer/genzo_category/releases/tag/v.2.0.0
  18. There is a module called "beesblog". It should be available in your backoffice under "modules". It's free. But in general it's ofc not easy, to launch an ecommerce business without any budget. Just sayin. Nothing is impossible πŸ™‚
  19. No thats not possible. You can install both and then link from one to the other. IMO I wouldn't mix them. I would either use thirty bees and a blog module. Or I would use wordpress with woocommerce.
  20. Edit Reason "forgot". Forgot to Spam? LMAO 🀣
  21. I wouldn't do that... Most customer are kind of "ok" with the first email, but there is surely no love for it. A second one would make a lot of them angry. You need to find other ways to raise conversion rate of reviews. Give them reasons, why they should write a review.
  22. I couldn't agree more. 😎 You see I am adding a lot of PR these days. But this is out of my reach. A very very good understanding of TB and PHP is needed.
  23. OK I guess Dekker implemented something really powerful, but nobody knows, how to use it. Here is the example: https://github.com/thirtybees/favicons/blob/master/template.html I believe using this, will solve all my errors in log πŸ˜‹ Edit: lol there is button "download a new template". πŸ˜‚ Is it just me, that never clicked on it? πŸ™„
  24. @datakick This whole favicon stuff looks like a big mess to me. Dekker did some work on it, but IMO he did it too techy. I can't imagine that a lot of merchant's understand "TB_SOURCE_FAVICON_CODE". I do not either... Also the difference between "TB_SOURCE_FAVICON" and "PS_FAVICON" is very unclear. Shouldn't we just go for one field and generate "all" the favicons by code? Is "PS_FAVICON" supposed to do that? We could also go for two fields as merchants maybe want a big and a small version. But this was basically the old system. Why was it dropped like that? To be honest: I don't care too much for favicons, but my log is full of errors due to it.
Γ—
Γ—
  • Create New...