wakabayashi

This is not the whole error log... A dev needs to know where the error comes from. It's a module...

Tonight I had the brilliant (not) idea, to look a bit into it. Looks like quite a huge project. But something confused me 🤨 @datakick Are you already working on a consistent image/webp support? I found this: https://github.com/thirtybees/thirtybees/commit/6334306227ee5df399d4b1576d536fc4c3457dec Isn't this the fallback mechanism you were talking about?

Does this tool anything special or is "just" about getting the earning per order correct?

Yeah, I know that. But that is with all current modules the same, isnt it? I mean I could implement customController rules. Like https://github.com/Pixel-Open/prestashop-cloudflare-turnstile does. I have thought now a bit about it. IMO a perfect solution would be like this: We implement a new Subclass CaptchaModule (similar to PaymentModule or so). The core and any third party module call a hookRegisterFormCaptcha($controllerName, $submitName). The merchants goes to AdminMetaController and selects all wished forms, that that have been registered in step 2. All active forms (selected in step 3) are handled by the Captcha Module (like my module does it). Do you like this idea? Or is it overcomplicate? IMO this would allow a merchant to install ONE captcha module and he can handle all his forms. If all captcha can work like mine, no override is involved. I see only advantages, but I might be wrong 😅

Who of you is using this configuration? My goal is to set up all costs of an order correctly. Then calculate the net earning and display it on orderpage. Basically this is, what orderprofit stats tries to do. But this stat is not designed correctly. For having consistent numbers, we would have to save per order costs in the tables. Also we shipping fees need to have an absolute costs value (as payment fees already has). If there is interest in the community, I can implement this in the core. If not, maybe I will just do it in own of my modules 😅

Great 😎 While it sounds like it, IMO that's not really true. I have added to the AuthController now, which took me 30 seconds and it seems to work: https://github.com/eschiendorfer/genzo_turnstile/blob/master/genzo_turnstile.php#L167-L173 In general this approach is so simple, that I am not sure, if we really need a new sepecific hook. Actually that hook would be tied very closely ☺️ If you have a few free minutes, maybe you can evaluate, if nocaptcharecaptcha module would work with my approach to. I personally will switch to cloudflare... @ukclearance My module is open source: https://github.com/eschiendorfer/genzo_turnstile/. Only thing missing is actually the settings on which controller you want to use the captcha. The rest is working for me. Maybe you can check it out!?

This is aksing for a lot of trouble. Spacing in webfolders is never a good idea... Just go for "niaragel"... or "niara-gel" is probably also working.

Do you know that this project is dead tomorrow, if datakicks or smile "have enough"? Your behaviour is very disrespectful and without any reason. Datakick does merge a huge amount of PR in a fast manner. You seem to have no idea, what it means to lead this project...

I wouldn't conclude that. I don't think a lot of merchants are using this at login.

I coded in the night and it looks promising. I believe, that I found a solution for contact form, that needs no override and no file changes at all. Is there any need for something else than contact form? But I am little confused, how complex the ps-module and the nocaptcharecaptcha are working. @datakick My approach is like this: Register hookActionFrontControllerSetMedia (Hint: I am missing a hook like actionFrontControllerInit) Check if controller is instanceOf ContactController If yes, check if Tools::isSubmit('submitMessage') is true If yes, validate captcha If NOT valide I just unset($_POST[$submitToCheck]); Looks quite simple to me. Do you see any problem with it?

Interesting! I will look into it, cause I also don't like google too much anymore. I will try to get rid off all their tools (which have direct access on my site)...

This is no big problem IMO. You just have to divide original_wholesale_price/o.conversion_rate and not the sum. First taking the sum is even mathematically wrong, isnt it!? 😅 I mean there is not a single static conversion_rate. It changes every day 🤔 We are on the same page 😎 I will update my PR.

PR is out https://github.com/thirtybees/thirtybees/pull/1598 😎

Yeah I understand your point. I am personally just not a fan of mixed currencies in the same table, that are not marked by name or so. But ok it's not so an important thing. More important is to fix the bug, which is really there...

This makes sense imo. Also PS has this approach, but lacked of consistency. @datakick If I see it correctly, the columns "purchase_supplier_price" and "original_wholesale_price" are stored in shops default currency. The other numbers in orders currency. My proposal would be, that we use for all numbers order currency. As we have the conversion rate, we can simply calculate them back. What do you think? This is actually what most devs would expect. They surely don't always recheck which column is in which currency. Ok I admit, that these columns probably weren't used a lot ^^ If you agre, I would make a PR.

To me it's also questionable in which currency all the numbers of an order (ps_orders and ps_order_detail table) are (or should be) saved. @datakick do you know that? Are they ALL saved in the currency that the customer used? Are they ALL saved in the default currency? Or is there a mixture? Only this understanding would allow a serious usage of these numbers. After testing a bit, I think most values are in currency, which the customer chosed. But not all. That's why it's no surprise that devs use it wrongly.

Nobody? Looking deeper into all these numbers, I have to say: PS did a solid job in saving the numbers. But a horrible job calaculation/accounting. There are a lot of places, where the system is just doing dubious things. Best example is statsordersprofit... If you have a simple setup without multiple currencies, it might be solid. If your shop has multiple currencies (suppliers) and a lot of price changes (suppliers) it's useless. But I can't fix this without other merchants, supplying me with their data.

I am not totally sure. Maybe it works to create an override.js file and add the whole function. Then make sure that override.js is loaded after tools.js. It might work, but I really haven't used this before. Let me know 🤗

Looking a bit into earnings I checked out order_detail table. In my case, it seems that the column purchase_supplier_price is always calculated wrongly. This column should show the price, you need to pay if you reorder the product at the supplier. The currency is your default currency. That's where my issue comes from instead of $price/$currencyRate it does $price*currencyRate... Can you please check, if it's the same in yours? (only relevant when you set up supplier price in a different currency) It's also helpful, if you show me a screenshot of your currency rates:

@Beeta This things are quite tricky. Are you an experienced dev? I don't know exactly, what you are trying to achieve. But if it's only about "involic prestabay". It could be easier to modify this module a very little. You could set up a little cronjob and search for new/modified products by date_add or date_upd. Then you trigger the module "involvic prestabay" hook function (but not the hook itself).

I don't know him personally and haven't used his version. But he is an experienced PS Dev and seems to invest a lot of time. So we would surely benefit, if he joins our community (and I guess he would benefit too).

PR are out: https://github.com/thirtybees/thirtybees/pull/1582 https://github.com/thirtybees/niara/pull/65 At the moment only the password confirmation handling was changed in Niara. The birthday is still handled the old way. The deletion apply was not implemented yet, as I am not sure, if it's really wanted.

No other opinions on this topic?

Oh yeah this makes sense 🙂

I would do the same ^^ The module above is crap?