Jump to content
thirty bees forum

wakabayashi

Silver member
  • Posts

    1,948
  • Joined

  • Last visited

  • Days Won

    148

Everything posted by wakabayashi

  1. Ok, I came back today. When do you get this warnings? Are they still showing up? I believe, they only happen, when the configuration setting was never set.
  2. I will be 10 days on vacation from tomorrow on. That's why I don't look deep into this now. I am a bit surprised, how this controller is handling form submissions, but ok it really does it with the email input field. So your way of doing it, is the only possible solution right now. I don't know what chex module (or your setup of it) is doing here, as there is already an email sending functionality in the core!?
  3. Ah bist du sowas wie ein Dropshipper oder wie muss man das verstehen? 🙂
  4. What do your settings under AdminStatuses (orders > status) look like?
  5. Hab den Namen "ENO" noch nie gehört. Was ist das? Dementsprechend würde mich das überraschen, wenn es da was geben würde 😉
  6. Hard to say. I use a customized version. Also your information is not enough to say for sure. Are you using advanced stock management? Where are you looking at the quantity? Cause in tb there is not just one "quantity". There is a difference between physical and real quantity (it's even more complex, but I don't go into details here). If "waiting for bank payment" is set up correctly. The real quantity should go down, but the physical should stay.
  7. I don't understand. I mean it's up to you, what kind of attributes you define...
  8. You should look at attributes. Maybe it works out of the box for you or with some little modifications.
  9. @datakick helped me, to investigate my issue. It's not related to @vsn, I believe. In my case 'ph_simpleblog' module had a severe security hole. I must say, that I haven't updated this module for years. I would expect, that there were fixes as the issue of this module was actually officially known. Btw the dev of this module is now working for prestashop company. I am sure, he wouldn't make this error again, but I it reminded me on a few things: It can hit everyone (I use only a handful external modules) -> make sure you have uptodate backups. Update your store (with core updater bleeding edge) and modules regularly Delete all stuff (especially modules) you don't need. Make sure, you have a contact person, who can help you in such a situation. Such a finding will lead to a lot of stress. It's very important, to have an expert, who knows, what is going on and whom you can trust. @datakick is the obvious choice for all tb users.
  10. I am not sure if it's coincidence, but I am being under attack right now. Also got an email about a security hole. Not sure, if it's real or not... The attacker sends all kind of forms. Has even opened a customer account (in my case this removes captcha). The customer account was even opened two times with same (email). So this was probably also due to any kind of form submission...
  11. Category images are kind of broken as we have two inputs, but only one image is saved. In my image rewrite branch, I have tackled this issue. But ofc (some) themes have to be adjusted accordingly.
  12. wakabayashi

    Images

    Yeah I would consider that at least. Of course it can be done cleaner with a module. Always adding this manually to product description has also some drawback and takes time. But anway you will need a mechanism, which products are involved and which not.
  13. wakabayashi

    Images

    But how many images are duplicates? You want to add same image to all 11'000 products? In what do your products differ from eachother? I have 30'000k products and only a few times the same images...
  14. wakabayashi

    Images

    About how many products and images are we talking here? The idea to solve this in database will likely fail. If this is REALLY relevant I would solve this by some module or tpl-hack. I mean if you always show the same "information" in the image. I wonder why not put this image without ps_image in product.tpl or so!?
  15. I have been in touch with @datakick the last days. We discussed a lot of things about this change. He improved the core updater and established a new dev branch there. He also pointed out a lot of issues. I am first going to fix/improve these points. When I am done, you will then be able to use core updater. 😎
  16. Google Maps in AdminOrders view was silently removed, right?
  17. Thanks a lot. I believe best would be if @datakick can make a dev branch for it. So that everyone with a teststore can use core updater and play around. Unfortunately I haven't reached him last weeks. If have used last days to test things on my own teststore. Things are looking good. I only found some details to fix. I could reduce size of img folder quite a lot (more than 30%).
  18. Hm interesting I have 1.4.0 there, but upgraded my store yesterday to bleeding edge.
  19. Hm, you haven't copied it manually from github before, right? Not sure, why it's not working for me as expected. Maybe related to the "tb_min_version" thing...
  20. @datakick I had to change this line $this->tb_min_version = '1.5.0'; to $this->tb_min_version = '1.4.0'; I guess with bleeding edge, I am not yet considered as 1.5.0
  21. Am I missing something or is this module just on github and not in BO modules list?
  22. I plan to finish this project soon. I have done so much now and need to stop, otherwise it will never get to an end. Here are some highlights: Consistent webp support in core (upload product images in webp is now possible) Modules can simply use core image system instead of implementing themself (beesblog was used as a test and simply supports now webp too). Just use AdminController and objectModels and image implementation takes minutes instead of days… Getting an image link was never so easy: all entity types are working with Link::getGenericImageLink(). This function also returns the source image, if you let $imageType empty. All image entities support now usage of $link_rewrite New we don't try to guess if 'home', 'home_default' and 'Niara_default' are all the same image type. We add all image type names to the db. First this may shock, how many different image types are used. But we introduce an alias system, that let you merge them. So a merchant has full control. Category image and category image thumbnail are now handled separately, so no more bugs on this. This is true for all other object model classes. They can add as many image inputs as they want. Image quality can possibly raise. I noticed some dubious places, were source file were possibly reduced in quality. So that meant, that image quality was actually lower than expected. I personally plan to use webp and 95 quality. I guess that raises quality and could even reduce size compared to old jpg system 😉 Employee image is now showed instead of icon-user. Default images were fixed (this was a complete mess). Now you can simply upload it under localization -> language and you are fine. Generation of retina images was improved a bit (no more blurry image generation). But I am still not totally convinced about this feature. The implementation doesn't check anywhere, if a retina display requesting an image or just a normal display. In general a huge amount of hardcoded stuff was removed and replaced by clean methods/constants. I would expect, that we can add new image extensions like "AVIF" quite quickly now. But I haven't tested this yet. Unfortunately plesk doesn't support AVIF yet and I don't want to install this manually on my server. So who is excited and ready to help testing this? To make clear, why this isn't a simple PR:
  23. @SLiCK_303 Thanks a lot for your message. Yeah I will go back to this, but I am not totally sure how and when. Somehow the module is overloaded with features, I guess. Your help is very much welcomed. That was always very helpful for me! @datakick pointed out to me, that there as some php warnings. I wanted to fix them long time ago, but forgot again to finish. Just way too much work right now. Btw the other post is SPAM. You should delete the quotation, as there is a link in it...
  24. Yes, it's no core functionality. I agree. But as a module it's very interesting IMO. On all social media plattforms it's becoming "normal" that you tag products on posts/images/videos. Maybe I can do that one day, but won't promise anything as I have already a lot of "projects" open 😉 In general I am making good progress on the image rewrite. I am now testing things with Beesblogmodule. With my rewrite almost all custom image stuff can be dropped there. Instead you just define this in BeesBlogPost::$definition: 'images' => [ 'beesblogposts' => [ 'inputName' => 'post_image', 'path' => _PS_IMG_DIR_.'beesblog/posts/', 'imageTypes' => [ ['name' => 'beesblog_post', 'width' => 800, 'height' => 500] ] ] ] It's going to be a lot of fun (almost no work) as a dev to use images 😎 Merchants will have consistent webp support 😏
  25. How do you like me now? 🤣 Ok, there are still a lot of issues left in scenes. But the video shows that this hidden feature is not completly death 🤭 scenes.webm
×
×
  • Create New...