wakabayashi

Sorry ich habe das Thema total vergessen. Das wurde in meinem Shop mittlerweile auch ganz anders gelöst. Ich erachte es als sehr sinnvoll solche Produkte zurückzustellen. Wir berechnen daher bei uns einen score wo verschiedene Parameter entscheiden, wie die beste Reihenfolge ist. Aber ok das ist ein anderes Thema. Zur Lösung: der Core Code ist hier wirklich hässlich... Du verwendest auf deinem Shop das Filter Modul. Deshalb muss man die Lösung da suchen. Das Module heisst blocklayered. Suche die Datei blocklayered.php. Es gibt dort eine Funktion: public function getProducts($selected_filters, &$products, &$nb_products, &$p, &$n, &$pages_nb, &$start, &$stop, &$range) Die musst du bearbeiten... Suche die Zeile: m.name manufacturer_name, Füge danach folgendes ein: IF(stock.quantity>0,1,0) AS sort_helper, Nun füge zudem nach "ORDER BY" folgendes ein: sort_helper DESC, Nun sollte es funktionieren. Hier noch ein kleiner Screenshot: Funktioniert das so für dich? Ich konnte diesen Code nicht intensiv testen, da meine Shops nicht dieses Modul nutzen. ACHTUNG: bei jedem Update dieses Modul wirst du das wieder anpassen müssen.

Thirty bees is still alive, that is the only thing that counts for me 😊 A lot of great things are going on github. It would be wishful, if we could clone Datakick somewow, but might be difficult 🫠

Damn I wasted now like 2 hours to understand why the core updater is suddenly no more working 🤦‍♂️ Please note: atm you can't have the setting "Server PHP version" with PHP 8.4. You have to select 8.3 🫣

I am now on bleeding edge and php 8.4. My first impression is, that it works pretty well beside deprecation warnings. I will keep you updated 👍

Thanks you very much. It works now 👍 This feature will be so great, love it. Especially, if we can save presets. 🤩 As I had this functionality in mind too. I wonder about something. Why do you implement the new $this->filters_list? I wanted to add this functionality $this->fields_list, then I would also allow an employee to select the columns he wants to display. He could then save the columns and also filters. IMO this would help merchants to customize their list to their needs even further. They can just hide unnecessary stuff and as a dev we can add more columns, without having to think a lot about "is it too much". A module like orderlistcarriers would just be obsolete with a few lines of code. Also your example with the customer email would be good. Maybe some merchants would like to see in orders list!? I hope you get my proposal. Maybe I don't see the drawbacks!? 😊

I am now playing around with this... What is the technique behind it, where are the filter values saved? In cookies? With a pretty basic list of my module, it seems to work fine. With a very complex list, I get the following:

Yeah this sounds like a very stupid idea from smarty team. But now I am little confused about the php 8.4. Does it mean the smarty version of the core, doesn't work with it? Or are we also just talking about some deprecation warnings?

I basically only use my own modules and a few core modules and a frew from datakick. So I am fine on this side. Ok that sounds good for me. 😏👍

Spring is coming, which is always the time for me to make the big upgrades. I want to update my shop to bleeding edge again. In this process I wondered, if ThirtyBees does support PHP 8.4? Officially I can only read about PHP 8.3... Are there any expected/known issues with PHP 8.4?

@the.rampage.rado your post reminded me, to renew my supscription 👍

Thanks a lot for this new feature! It will be very helpful. Something similair was on my ToDo list as well 😏 I will have break in early april. Afterwards I will update our system to new PHP version and will also upgrade again to bleeding edge. Then I can test it with my live site 🤩

Good to know. The question is now, if this makes any sense for anyone. I really don't know why the core does this. The fact that you have issues and me too, makes this part of the code really dubious.

It might be, that I got pissed by this issue too in the past. Cause I just checked my override and there I only check for this: if ($orderDetailList[$idOrderDetail]['quantity'] > 0) { if (Tools::isSubmit('reinjectQuantities')) { $this->reinjectQuantity($orderDetail, $orderDetailList[$idOrderDetail]['quantity'], false, Configuration::get('PS_STOCK_CUSTOMER_ORDER_REASON')); } } So basically I remove the hasBeenDelivered() function...

Hard to say. I use this feature too, but with multiple overrides. The logic happens in AdminOrdersController.php -> postProcess() -> Tools::isSubmit('partialRefund') Also in AdminOrdersController there is function reinjectQuantity(), but IMO this should not even be called your case. if (!$order->hasBeenDelivered() || ($order->hasBeenDelivered() && Tools::isSubmit('reinjectQuantities')) && $orderDetailList[$idOrderDetail]['quantity'] > 0) { $this->reinjectQuantity($orderDetail, $orderDetailList[$idOrderDetail]['quantity']); } I would wonder, what your $order is returning on hasBeenDelivered(). Also the question is about which quantity you are talking. Are you using advanced stock management?

Go also under modules->positions and check for this: