-
Posts
3,122 -
Joined
-
Last visited
-
Days Won
488
Content Type
Profiles
Forums
Gallery
Downloads
Articles
Store
Blogs
Everything posted by datakick
-
The error makes it clear that database migration was not performed. This could happen either update process failed -- you confirmed this is not the case you have some override that blocks core updater to discover new database schema changes. This is the most likely case Check if you have override for Combination - check if file /override/classes/Combination.php exists. I bet it exists, and it contains something like public static $definition = [...] If that's the case, you will have to modify it to include the new changes from core.
-
Contact Form Recipient Email Address Filter module
datakick replied to the.rampage.rado's topic in Modules
Indeed. Looks like a bug in translation system, when $this->l() does not accept strings with quotes, only with single apostrophes. Oh my... The fix is here: https://github.com/thirtybees/tbcontactformrecipientfilter/commit/0318e7a56d261a21e92fc9960aff6ed3bd80b66d The fix of the actual bug (translation strings extraction in core) will be hopefully in next version. -
Contact Form Recipient Email Address Filter module
datakick replied to the.rampage.rado's topic in Modules
You don't need to 🙂 the email address is entered on contact form, for non-logged in customers -
Contact Form Recipient Email Address Filter module
datakick replied to the.rampage.rado's topic in Modules
yes, they should. Try to send customer message using email address with .ru email 🙂 -
Contact Form Recipient Email Address Filter module
datakick replied to the.rampage.rado's topic in Modules
Indeed. I fixed this, you should see the other module as well now -
list of modules is fetched from https://api.thirtybees.com/updates/modules/all.json Modules zip files locations are listed in the json file. Usually it's github, but some premium modules have different location.
-
Revws module - possibly missing product structured data
datakick replied to 30knees's question in Module help
As this is not a bug, I will not be releasing a new version to fix it. It is common that module template sometimes needs to be adjusted in order to work properly with your theme (or in this case with other module). You can simply edit file /modules/revws/views/templates/hook/home.tpl and change col-sm-12 to col-xs-12. Or, you could modify the template of the other module in a similar way. -
Revws module - possibly missing product structured data
datakick replied to 30knees's question in Module help
The problem is that two templates, from different modules, use different bootstrap class. Bootstrap does not like this You need to choose which class you want (col-xs-12 or col-sm-12) and then edit and change one of the template -
No, "Block Facebook Share" works only on product page. It should be simple enough to modify the module to work with cms hooks (displayCMSTop or displayCMSBelow), as the module does almost nothing. You should register selected hook in install section implement hook handler hookDisplayCMSTop -- almost copy of existing hook, only different way to resolve url for cms page
-
That's hard to tell, it depends on what modules you are using. For example, I've seen module thats send abandoned carts emails to raise 500 errors after the old carts were deleted. Some modules (for example my revws) uses guest table as a.persistent identifier to identify anonymous visitors (revws is using that to allow anonymous visitors to edit / delete their reviews. Pruning data from guests table will break this functionality). And there are more. To improve performance, on a clean installation without additional modules, it's safe to delete old carts (tb _cart, tb_cart_products, tb_cart_cart_rule,...) delete old entries from (tb_log) delete old visitor-related entires (tb_guests, tb_connections, tb_connections_source) prune tb_mail entries It can be hard to do that manually. There are modules that do that in a safe way on a regular basis.
-
Yes, it's safe
-
Updated to 1.6 and CSV import failed.
datakick replied to jnsgioia's question in Updating thirty bees
Indeed, the composer dependency of this module do not work properly with the composer dependencies inside core. We really need some way to have composer dependency isolated (to support different versions in every module). But that will be very hard task to implement. Meanwhile, I've released a new version of tbspreadsheetdatasource for thirty bees 1.6.0. Please update the module, and it should work again -
The autoload directory is to add your custom css files, not for overriding existing css. But for css, that's usually what you want. Add your css rules that have higher priority, so browser will use it. For example, if the css rule you want to change look like this: .sf-menu { float: left; margin-bottom: 1em; } and you want to change margin-bottom, you can create css file that contains only change: .sf-menu { margin-bottom: 2em !important; } Browser will use all rules and merge them together. Because of !important keyword, the your custom value for margin will be used. So -- do not copy the original file, but only copy rules you want to change.
-
It probably depends on mail transport module you are using. Old tbswiftmailer module delegates placeholder replacement to swiftmailer library (Swift_Plugins_DecoratorPlugin class), and this probably applies the replacement to subject as well. New tbphpmailer module does the replacement manually, and only for email body. I'm not sure if this is a bug in the module, or in core Tracked here: https://github.com/thirtybees/thirtybees/issues/1923
-
Names of front controller files should be lowercase, I believe. There was recently a fix for this https://github.com/thirtybees/thirtybees/commit/73bd67f18a143bf06fdc014302495ec7c77986f8 but for BC compatibility reasons (if you want module to run on older tb versions) you should use vouchercheck.php
-
Until thirty bees 1.5.0, CMS category description did not allow HTML content. We enhanced this in 1.5.0. However, old themes do not support this. You have to edit your theme cms.tpl file, and remove escaping. See this commit, how it was done in niara theme: https://github.com/thirtybees/niara/commit/402af237ecf99c5b9cb49e9316c54b88dd5b5c28 https://github.com/thirtybees/thirtybees/commit/09fcb66221a3ed14008c3476e1cfed1ff3d531d7 So this is not a bug. However, thanks to you I found different / related bug -- description displayed in the back office CMS category list needs to be striped from tags. I've fixed this, it's in bleeding edge now.
-
If you find any errors, please file github issues. The worst that can happen is that we will close it as a not-a-bug. Related to custompayment module - we have just released new version of module that fully supports image rewrite functionality. Mostly, buggy custom code for handling image upload/deletion was deleted, and everything is handled by the core in a generic way.
-
Replace this line with if (! is_array($error)) { $error = []; } $error = array_merge($error, $carrier_error); Core method variant allows $error parameter to have null value, and it properly handles that situation. Your override version does not - it's probably from very old ps16. Note: This override completely replaces the core version of getAvailableCarrierList method. There has been a lot of changes in that method (for example added support for min package weight), which will not work for you now. You should update the override code -- copy the current version from tb core, and apply the needed changes. Otherwise system will not work properly in all cases. This is not related to 1.6.0, though -- it's the same with 1.5.1 as well.