Jump to content
thirty bees forum

datakick

Administrators
  • Posts

    3,101
  • Joined

  • Last visited

  • Days Won

    478

Everything posted by datakick

  1. Until thirty bees 1.5.0, CMS category description did not allow HTML content. We enhanced this in 1.5.0. However, old themes do not support this. You have to edit your theme cms.tpl file, and remove escaping. See this commit, how it was done in niara theme: https://github.com/thirtybees/niara/commit/402af237ecf99c5b9cb49e9316c54b88dd5b5c28 https://github.com/thirtybees/thirtybees/commit/09fcb66221a3ed14008c3476e1cfed1ff3d531d7 So this is not a bug. However, thanks to you I found different / related bug -- description displayed in the back office CMS category list needs to be striped from tags. I've fixed this, it's in bleeding edge now.
  2. If you find any errors, please file github issues. The worst that can happen is that we will close it as a not-a-bug. Related to custompayment module - we have just released new version of module that fully supports image rewrite functionality. Mostly, buggy custom code for handling image upload/deletion was deleted, and everything is handled by the core in a generic way.
  3. That's because you have enabled high dpi images - 2x dpi. Source image should be at least 2 times the size.
  4. I've also updated core code in bleeding edge, to have better backwards compatibility with legacy overrides.
  5. Replace this line with if (! is_array($error)) { $error = []; } $error = array_merge($error, $carrier_error); Core method variant allows $error parameter to have null value, and it properly handles that situation. Your override version does not - it's probably from very old ps16. Note: This override completely replaces the core version of getAvailableCarrierList method. There has been a lot of changes in that method (for example added support for min package weight), which will not work for you now. You should update the override code -- copy the current version from tb core, and apply the needed changes. Otherwise system will not work properly in all cases. This is not related to 1.6.0, though -- it's the same with 1.5.1 as well.
  6. paste content of override/classes/Carrier.php
  7. What's the severity of that message? I doubt it's exception or error, it looks like notice or warnings. If so, than it probably won't be the root cause
  8. Anything can cause that. Install collectlogs module, update back to 1.6, and then look what errors are collected.
  9. Well, it must be placed somewhere, and everywhere it will block something. If you can't close it, it means that you have some javascript error in your back office, most likely caused by some module. That error is probably blocking execution of other javascript, and is therefore most likely causing problems elsewhere as well. This just made it more prominent. Fix your store.
  10. id_cart in your cookie is set to null instead of an actual cart it. All places in core that writes id_cart into cat are putting integer value (not null), so there must be some module that did this.
  11. The code works for me. Browser doesn't like it much, though. When you select multiple orders with invoices, and then click on multi-download, browser opens multiple tabs for every invoice. This is not a normal behaviour, and browser quite correctly treat this as unwanted popups. I had to click on 'always allow popup on this site' to make this functionaltiy work. Note: please remove this code from admin.js -- that is a core file, and should not be modified. The best way to implement these changes is using custom module. I've quickly prepared a very simple module that adds custom js file to all admin pages: backofficejs-v1.0.0.zip Just install it, and then modify file /modules/backofficejs/views/js/backoffice.js in order to add your code.
  12. It depends on what type of voucher it is. It can be either: Single-Purpose Vouchers (SPVs) --- can be used only if the tax rate and the place of supply is known. So, if the voucher can be used only for products with standard VAT rate, and only in Bulgaria, than such voucher meet the SPV criteria. You can then collect VAT at the sale of such voucher, and voucher can be used as a standard discount. or Multi-Purpose Vouchers (MPVs) -- voucher can be used for any product, or EU-wide -- an actual VAT rate is not known at the time of voucher sale. Voucher must be sold without tax, and tax must be collected when the voucher is applied. Voucher shouldn't be used as a discount, but as a method of payment.
  13. That's very nice, thanks for sharing. I would just like to point to a problem related to VAT, and EU laws (https://www.vatcalc.com/eu/eu-review-of-vat-on-vouchers/) When you sell voucher, it is considered to be a MPV voucher (A multi-purpose voucher is a voucher where, at the time of issuance, the VAT treatment of the goods or services to which the voucher relates is not known). You are required to collect VAT when customer redeem the voucher. Unfortunately, thirty bees does not do that. In thirty bees, cart-rules are treated as discounts, and they affect price before tax. Example: Let say you have a product A that costs 1OO without tax, 120 with tax You also have voucher virtual product with face value 120 You sell voucher product with VAT rate 0, because VAT should be collected on voucher redemption. When your customer use the voucher to purchase a A, the voucher will decrease the pre-tax amount to zero. This will result into free order, and there will be no tax applied at all. The correct behavious should be the free order, but with applied tax. Which is obviously wrong, and you can have problems with your tax authority. In other words, credit vouchers should not behave like discounts, but more like a payment method. We are thinking about how to fix this. We will probably introduce new kind of cart rules, that will behave correctly. Note: currently, the same problem is with vouchers generated from credit notes. It just isn't so obvious, because credit notes are not used that much. Example: you customer buy product A for 120€ you collect 20€ VAT and send it to your tax authority you customer request full refund you generate credit note, and will request refund €20 from you tax authority you generate voucher with face amount €120 to your customer your customer can use this voucher to purchase product A. The voucher will reduce the pre-tax amount, and your invoice will be with zero tax You once again stole from your tax authority. You sold product A for price with tax, yet didn't actually send the tax to tax authority.
  14. You should not focus on google, but on your customers experience. Block features is, in my opinion, a nice way to showcase your best selling products to new visitors. But it's up to you. Note that having metadata about products in list miniatures is not a good idea. This template is used on a lot of places. For example, if you have 'Related Products' module enabled, it will be displayed on product page. If this template contains product metadata, it can confuse search engines. When they crawl your product page, it will see metadata about 7 products (one primary, and 6 related products). How will google know which one is the primary one? What review average ratings should it display in search results? .... these additional metadata just produce noise, and bring no benefit. My recommendation is to remove the metadata from this template anyway.
  15. edit product-list-item.tpl, and remove all itemtype, itemprop and itemscope attributes.
  16. Review metadata are not emitted for product miniatures / listing. They are emitted only on product page, for primary product. I suggest you to modify your theme, and remove all metadata from product miniatures. Having them there does not help your site.
  17. That library is just a tool to embed xml into pdf files, and then read them back. It performs xml validation to ensure that it matches factur-x xml schema, but that's all. In order to use this, you still need to generate xml file with data first. Then you can use this library to embed the data into pdf generated by thirtybees
  18. I would be a little afraid about blocking regular customers by mistake, but it could be easily done for sure.
  19. Hi everyone, we are happy to announce new premium module: Contact Form IP Address Blocker module First of all - this module only works on thirty bees version 1.6.0 -- if your store is not on this version, you will need to update first. Thirty bees 1.6.0 introduced new hook that allows modules to filter contact form messages. This Contact Form IP Address Blocker module use this hook to block sending messages based on IP address. It collects statistics for every IP address -- how many times it send/attempted to send contact form message. This information is shown to administrator, and they can ban IP addresses of spammers. There is also an option to automatically ban IP addresses after they send N messages in the last H hours (where both N and H can be configured) Note that the ban is for sending contact form messages only. So, if you ban somebody by mistake, they can still use your site, they just can't send you contact form message -- they are asked to send email instead. I hope you will like this new addition to our of premium modules.
  20. OrderHistory https://github.com/thirtybees/thirtybees/blob/0913a2fa58cfd7db1e1f9ac33b99389777edba78/classes/order/OrderHistory.php#L480 Sure, we would gladly accept PR. Extra parameters passed to email templates are fine, as long as it doesn't cause errors or performance issues.
  21. This class handles sending of order_conf and voucher emails. So if you want to extend those email templates, then it's the right place to modify. It has no impact on order status emails, like bankwire, though.
  22. In 1.1.0, the test mail functionality does not use standard Mail::Send -- there was a dedicated method in Mail Controller that simply attempted to send email using provided credentials. If this works, but no other email works, then the issue will be somewhere in Mail::Send. You are saying that nothing has changed. I don't believe that -- something must have changed, otherwise it would continue to work. It doesn't mean that you did any changes, though. For example, it's possible that your site was hacked, and some core files were modified, breaking some functionality. Or your hosting provider may have changed php version, or upgraded the mysql server.
  23. What exactly do you mean by 'Order confirmation' emails -- do you mean email sent to customer, or to merchant? If you are talking about merchant email, then it will be issue with your mailalerts module. My guess is that the email is not correctly translated to your language. Some older thirty bees version (for example 1.1.0 🙂 ) contained a bug that created empty email templates in your /themes/<theme>/modules/<module>/mails/<lang>/ directory when you opened Localization > Translations > Email Translations. Check the path for mailalerts module, and verify that there are no files with zero size. Delete them if they exists. Check if the email is logged as sent in Advanced Parameters > Emails. If it's listed there, it's not a thirty bees problem, but issue with your mail server.
  24. I suggest you extract these as overrides into a custom module. That way you, can easily transfer the same functionality between installations (for example to your test env), and the changes are nicely attributed to your module when listing overrides in 'overridecheck' module. It should be fairy easy task, my estimate is 1-2hours of work at most. We are happy to help you with this you can buy adhoc support time or you can purchase one of the supporter plans that come with 1 or 2 hours of support monthly. You can use this time for anything -- store update, custom dev,...
×
×
  • Create New...