Order edit / stock management problems

[RabbitZzZ]

Hi, on thirty bees 1.0.8 without advanced stock management we found the following problems:

If you add a quantity of products to the order, the stock gets reduced. If you delete it again, it wont be added back to the available stock.

Also the shipping costs are not updated due to the additional weight of the added products.

Any way to solve this?

Thanks!

[RabbitZzZ]

Can somebody confirm this? Is it a bug?

[wakabayashi]

I use asm, so I cant tell. What is normal: the shipping cost never adjust! I would like to have it, but its not there...

[RabbitZzZ]

Ok, good to know about the shipping cost. Still would be a useful feature to implement.

The stock problem remains. It also seems like sometimes the stock is reduced twice when products are added to an order. Is there something wrong with some calls for the database update in the background?

[wakabayashi]

Do you have some overrides? Cause in general this is working for me...

[RabbitZzZ]

Nothing I suppose would tangle with the stock management. The only override that is active is the one from a module that changes the order reference numbers.

[30knees]

I edited an order by adding one and then subtracting one from the quantity and it worked. However, I did get, after editing, this mangled editing form:

[wakabayashi]

@30knees I can confirm, that this sometimes happens. I don't know exactly when...

[30knees]

@wakabayashi Thanks for confirming! I always get it, unfortunately :(

[wakabayashi]

@30knees just refresh the page and it looks normal again...

[RabbitZzZ]

I just tried and this is what happened:

• created an order with one article, 4 times -> fine
• edited the order, added and removed about 2-3 of the article -> fine
• added another article (90 available) 25 times -> remaining stock is 40

so double the quantity got subtracted from the stock. Seems to happen all the time if you add a new product to the order.

[wakabayashi]

I just don't think its a core issue, since we dont have it and @30knees also not. I would try two things: - disable overrides - do the same tests on a clean tb installation

[RabbitZzZ]

Disabled overrides and non thirty bees modules -> same problem

[wakabayashi]

Damn thats bad... Maybe somebody else can confirm the issue?

[RabbitZzZ]

So I tried on a fresh and unaltered 1.0.8 version and still there is the same problem.

[datakick]

I was able to reproduce this issue. Fix will be part of the upcoming version.

https://github.com/thirtybees/thirtybees/commit/45fe39bf0b82aedf0e570263447c8fb7cc306a58

[wakabayashi]

@RabbitZzZ thx a lot for looking that deep into it. You were right, I was wrong! Sorry for that.

@datakick thx a lot for the fix.

[RabbitZzZ]

Thanks all for finding out together! I will try the fix today.

Edit: Works! Thanks a lot!

[30knees]

Something related, perhaps. I had an order that I set to canceled. Then I refunded the order in PayPal, which is why the status "refunded" was automatically set. Then I moved it back to canceled (for our work flow purposes). 

	Canceled		12.09.2023 07:37:07
	Refunded		12.09.2023 07:21:28
	Canceled		12.09.2023 07:20:38

Stock was added back for both cancellations. Is this expected behaviour or should stock added back only work if in between two "canceled" there was a status that substracted stock?

Edited September 12, 2023 by 30knees

[the.rampage.rado]

When you click on refund this is the last order status you have to set in this scenario. Some other payment methods (modules) might not restock but in this case you would not have to put Canceled after Refunded.

Also this might help in quick analysis of the order s in BO - how many refunded, canceled, etc orders you have divided in different end statuses.