E-mail field TLD validation not working after update to 1.1.0

[DorkV89]

After I updated from 1.0.8 to 1.1.0 the e-mail address validation when making an account or placing an order is not working anymore.

So the customer can fill in ''e-mail@url''  as an e-mail address. And this is accepted without the TLD. Filling in an address without the ''@'' isn't accepted.

This never happened before and is on all the shops I have updated to 1.1.0

 

[Traumflug]

A '@' is mandatory part of an email address, obviously.

Perhaps you could give us a few examples of addresses which should work, but don't.

[wakabayashi]

As far as I understand. He doesn't like that an email address without a "." is accepted.

[dynambee]

53 minutes ago, Traumflug said:

Perhaps you could give us a few examples of addresses which should work, but don't.

It seems that it's more of a problem that addresses that shouldn't be accepted, are.

[DorkV89]

Before the update the customer was not able to make an account with for example:

e-mail@email
or
mail@email.

It was blocked (like when the @ is missing) because the TLD is missing. At this moment (after the update) the customer can make an account or fill in e-mail address without the TLD.

The address in the attachment is accepted and should not.

 

Where on the old environment it is not accepted and blocked by an error:

[colorful-ant]

i´m not sure
mail-address have no correct domain for example email@email.COM - have you tried with the last signs (.com or another) ?

[DRMasterChief]

OHHH !  Holy moly !  DorkV89 is right,  it is possible also at tb 1.0.7 and  1.0.8

( i have tried with several email addresses  like  myname@dropdown  and no '.' (dot) or TLD at the end,  and i can sign up with such an no-workin email-address ) !! 

Please tb team, have a look at this ! 😟 

Edited October 28, 2019 by DRMasterChief

[DorkV89]

1 hour ago, DRMasterChief said:

OHHH !  Holy moly !  DorkV89 is right,  it is possible also at tb 1.0.7 and  1.0.8

( i have tried with several email addresses  like  myname@dropdown  and no '.' (dot) or TLD at the end,  and i can sign up with such an no-workin email-address ) !! 

Please tb team, have a look at this ! 😟 

Yes, that is what I mean. I didn't know how to explain it better. 

[colorful-ant]

2 hours ago, DRMasterChief said:

OHHH !  Holy moly !  DorkV89 is right,  it is possible also at tb 1.0.7 and  1.0.8

( i have tried with several email addresses  like  myname@dropdown  and no '.' (dot) or TLD at the end,  and i can sign up with such an no-workin email-address ) !! 

Please tb team, have a look at this ! 😟 

thanks - now I understand the problem

[dynambee]

I've opened an issue on github about this here. I don't think it will be a difficult issue to fix.

However even after this is fixed it will always be possible to create an account with a fake email address unless you force email validation before allowing a new account to make purchases. Even with validation people can use free temporary email addresses to sign up for websites. Beyond that many people use a free email account for all their online purchases and then rarely if ever actually check that account.

There isn't really anything realistic that we as merchants can do to make sure we have a long term ability to communicate with customers.

[DRMasterChief]

I absolutely agree to this:  https://github.com/thirtybees/thirtybees/issues/1086#issuecomment-547341365 

Dotless domains are useless in such surroundings like an onlineshop  😉 

We can not control or do anything if an customer does not check his mails, but we should be correct to raise a technical correct email address, just to make sure the customer did not forget to type it correct  (and they will forget a lot when typing their address or similar......)