Jump to content
thirty bees forum

datakick

Administrators
  • Posts

    3,130
  • Joined

  • Last visited

  • Days Won

    492

Everything posted by datakick

  1. There is no redirect. Javascript code simply changes the url (removing ?combination=xxx and replacing it with # hash parameters), but the page is not actually reloaded.
  2. Parameters behind # are for client use only. Request to the server never contains those parameters, server never sees them and can't react to them. When you open urls https://www.example.com/en/products/84/sample-product#/72-size-large or https://www.example.com/en/products/84/sample-product#/whatever your server receive the very same request - https://www.example.com/en/products/84/sample-product It does not know what combination you are requesting. Javascript will later parse the hash parameters, and will modify the product page to display the wanted combination if it's found. This also means that initial page render shows different combination, and only a few milliseconds later the page is 'adjusted' When you provide ?combination=xxx parameter, server knows upfront what you want to display, and can returns page with combination already selected (if your theme supports this, of course). The page already contains correct pricing information, product name, reference code etc -- this is important for web crawlers. This means that you need to provide urls with standard query parameters (after ?) to google
  3. What geolocation module are you using?
  4. Yeah, it's a bug in core. You can reproduce it even without clicking on Cron link, simply by updating currency rates in single shop context. I've created an issue on github: https://github.com/thirtybees/thirtybees/issues/2073
  5. Don't think so, they are mostly the same, just few minor styling changes between them
  6. I was mistaken, niara do not hide images not associated with selected combination. It only shows combination cover image. However, it's not complicated to implement this. You need to modify file themes/niara/js/product.js - search for function refreshProductImages and add hiding/showing logic for images
  7. What theme do you use? This is, ultimately, theme responsibility. Core only provides information about images and their associations with combinations to theme. What theme decides to do with those informations is up to theme. I believe that standard thirty bees themes do implement this image hiding. But only if the combination have at least one image associated
  8. datakick

    emails problem

    this is a known issue with switftmailer - on some php versions it do not work properly. Install tbphpmailer module and use it as you mail transport
  9. The standard template that datakick module installs do not contain shipping weight by default. You can very easily add it, though. GMC documentation https://support.google.com/merchants/answer/6324503?hl=en tells us that they are looking for element like this <g:shipping_weight>3 kg</g:shipping_weight> So let's edit the template, and add this element under <entry> node To get data in correct format, you need to use the expression product.packageWeight + " kg" Note that you need to do this twice if you are using GMC template for combinations, as there are two <entry> nodes in template, one for products without combinations, one for products with combination. In this case, you will need to use different expression in second node: combination.packageWeight + " kg" You can download this template: gmc-with-weight.json and install it into your datakick module, as an inspiration
  10. Uninstall "Google Analytics API" module
  11. Check if you can complete order using other payment method. If you can, then it's a bug in this third party module. Ask developer to fix it, or hire someone
  12. What payment module do you use for card payments?
  13. I don't think it's a bug in the system. I have no problems creating customer accounts with that name, or creating orders. My guess is that your database charset / collation is not correct. Use core updater to check if your database tables use correct character set and collation. It should be CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
  14. I've added the option to set columns as hidden by default. When you create list column, you can pass 'hidden' => true, and thirtybees will not show it by default. Here's example: https://github.com/thirtybees/thirtybees/blob/f27320165d9e788af9f702af547adaaed6e0db90/controllers/admin/AdminOrdersController.php#L179 Once we implement list column customization, we will be able to show those default hidden columns, hide columns that are displayed by default, or even reorder columns in the list.
  15. Yeah, that's unfortunate. It's because there is actually no type column in product table. Product type is determined on thy fly from other product properties. For pack, there must be pack items in pack table. So, you have to switch to 'Pack combination' type AND then, before you save product, go to Combination tab and assign pack content to at least one combination. That will lock it in
  16. Sure, it make sense, but only after we add support for list column customization. Without it, there would be too much clutter.
  17. Thanks everyone for testing. I've created the issues for those problems, and will make sure they are addressed before we merge this into bleeding edge. As we found out, the solution we implemented before was not good enough for all use cases. The virtual/dynamic attributes are fine in most cases, but sometimes we need even more flexibility. So we implemented yet another enhancement in this area -- full-fledged packs per combination. You can now choose between two different versions of packs Pack of existing products -- original implementation, when pack is defined on product lavel. You can use virtual/dynamic attributes here to tweak pack content using dynamic product attributes, as described in this thread above Pack of existing products - combinations -- new functionality. When you select this, you won't be able to define pack on product level, but you will have to define packs for every combination separately. This gives you great flexibility, as your combinations can have totally different/independent pack items. But obviously, it will be more complicated to set up, as you need to define pack content for every and each combinations. So choose this only when appropriate Pack content on combination level: This new functionality is in pack-combinations branch. If you can, please help us with testing once again.
  18. Thanks for testing Yes, so far the values are saved in cookies. However, there is now an abstraction (ListViewStorage interface) that will make it possible to save filter values differently in the future. It's a todo task that I would like to implement soon. With this in place, cookies will be much smaller, and we will be able to implement additional features like saved filter presets. I think that will make this quite useful Thanks for bug report. I believe I have fixed this - could you please re-test on latest version of this branch? If you still get the error, please send me a controller class, so I can figure out what is wrong.
  19. No, 1.0.8 is not the latest version. Go to core-updater module settings, and clear cache
  20. I've just released a new version 1.6.12 of coreupdater that should fix this php5.6 compatibility issue.
  21. Thanks, interesting read. At least for smarty v5 there is a dirty fix available that will not require much work. That's good to know. Unfortunately this fix is not available for smarty 4.4.x, so we will have to skip those and update straight to smarty v5. And there are many breaking changes related to that update, so it won't be doing that anytime soon.
  22. Unfortunately it won't be easy to upgrade smarty to newer versions easily. New versions of smarty raises a lot of new deprecation warnings when templates call php methods directly. We are now required to register all methods that are allowed to be called from smarty template. As you can imagine, that's something absolutely impossible for system like thirtybees/prestashop -- we simply don't have that information. For example, if some module template contains code like this: {if Configuration::get('PS_INVOICE')} <span>...</span> {/if} we would have to tell smarty engine that the method Configuration::get exists and can be called. In the near future, using that template without registering the method would cause runtime error. Because we are using templates from third party modules and themes, we simply don't know what methods are used. The only potential solution for us is to parse templates to collect list of all used methods so we could register them before template is used. While the parsing can be done only once (when template source changes), the registration of methods needs to be done on every render. That will cause quite a big performance impact - we need to load the info from somewhere and pass it to smarty engine. I don't understand why this change has been introduced, and I'm very unhappy about that. We will either have to keep using smarty 4.4.1 forever (which is not possible due to new php versions not supporting it). Or we will have to invest days or weeks of work to implement that stupid registration, just to get to the same point we are now.
  23. The core is not yet php8.4 ready. We already fixes few issues, but there are still some to iron out. There is nothing braking, though - just a lot of new deprecation warnings, mostly related to "Implicitly nullable parameter types". PHP8.4 now complains when parameter with default null value is not marked so. All methods and function that look like public function func(string $test = null) must now have slightly different signature: public function func(?string $test = null) It's fairy easy to fix these warnings. There are even an automated scripts to do that across entire codebase. But obviously, we can't fix third party modules. I'm also a little bit worried about method overrides. I'm not sure how well PHP will take if the overridden method has slightly different signature.
  24. This functionality is based on Products to Order overview. That table shows list of all supplier products and calculates safety stock/reorder point for each supplier. To calculate this, it takes into account your sales history, supplier lead time, stock keeping costs, and some other factors. You can check that table to figure out when you should order product from that particular supplier. For every supplier, the reorder point for that product can be different: Now, the Auto generate button is very simple. It looks into this table, but only for suppliers that are set as product default supplier. It current stock is below reorder point, the empty/blank/draft purchase order for that supplier is created. No product is added. It just exists so the back office employees knows what to check. It's not perfect, and it's not for everyone, but it can help keep an eye on things. No, the module currently does not do that. It's a good suggestion, I've added this enhancement request to the backlog. We already have a similar ER to warn when the product is in another PO (draft or sent).
  25. Well, this is more complicated. To accomplish this, you will first need to slightly amend the code of the module. Edit file /modules/datakick/engine/prestashop/schema/combination.php find section 'fields' -- it begin with this code like this (depending on module version it might be slightly different): 'fields' => [ 'id' => [ 'type' => 'number', 'description' => 'id', 'selectRecord' => 'combinations', 'mapping' => [ 'pa' => 'id_product_attribute', 'pas' => 'id_product_attribute', 'sa' => 'id_product_attribute' ], 'update' => false ], and inside this section add new field: 'hasImages' => [ 'type' => 'boolean', 'description' => 'Has associated images', 'update' => false, 'sql' => 'EXISTS(SELECT 1 FROM ' . _DB_PREFIX_ . 'product_attribute_image AS pai WHERE pai.id_product_attribute = pa.id_product_attribute)', 'require' => ['pa'] ], After you save it, you will be able to use this new field in datakick module. You can use it in condition. Edit conditions for <entry> node: This way, you can have a section that display only combinations that have explicitly associated images. In this section, we want to display only images associated with combination. So edit <g:additional_image_link> node, and use 'Restriction = Combination images' Next step is to duplicate entire <entry type="variant"> node, but this time use condition Combinations: Has associated images is No This new section will display only combinations without explicitly associated images. In this section, we want to show all product images. So you should edit <g:additional_image_link> node and use Restriction = All data (all images) add custom Condition (combination.productId == image.productId) to filter out images that belongs to other products At the end, you will have three <entry> nodes at the top level nodes of your template, it should look like this (I've removed the children nodes of <entry> nodes):
×
×
  • Create New...