SLiCK_303 Posted February 11, 2018 Posted February 11, 2018 I think when you have it set to 'Hide reviews tab completely', that it should still show the 'Rating: Sign in to write a review', up top still, like this... IMO
nickon Posted February 11, 2018 Posted February 11, 2018 @SLiCK_303 Agree. Just instead of "Rating" is should display an icon instead IMO
SLiCK_303 Posted February 11, 2018 Posted February 11, 2018 @nickon said in [Free Module]Revws - Product Reviews: @SLiCK_303 Agree. Just instead of "Rating" is should display an icon instead IMO sure, like icon-sign-in for instance..
nickon Posted February 11, 2018 Posted February 11, 2018 @SLiCK_303 icon-comment would be better. IMO the icon should replace the "rating" word to keep consitancy with "mail" and "print" icon (You show to the user that this is a comment, you explane next to it that he needs to sing in)
SLiCK_303 Posted February 11, 2018 Posted February 11, 2018 @nickon said in [Free Module]Revws - Product Reviews: @SLiCK_303 icon-comment would be better. IMO the icon should replace the "rating" word to keep consitancy with "mail" and "print" icon (You show to the user that this is a comment, you explane next to it that he needs to sing in) agreed...
SLiCK_303 Posted February 11, 2018 Posted February 11, 2018 This is personally the way I have mine setup, thankfully you can change the tpl files for your theme. It's closer to the way Product Comments was setup. or if you cant post a review, because anon. users can't post... or...if you cant post, and theres no reviews.. or..you can post, and theres no reviews...
SLiCK_303 Posted February 12, 2018 Posted February 12, 2018 @datakick Could you please do a new release? I am trying to get your latest source working, and it just isn't. I can't get the new options in the BO to show up, and the changes don't show in the FO either. I've cleared the site cache, and my browsers, nothing helps. I've tried removing my /themes/mytheme/modules/revws folder too, and just rolling with your stock config, still no joy. I'm hoping an install of the official release will make it work. I assume the two javascript files have changed, and I don't have the new ones, and that's the problem...
datakick Posted February 12, 2018 Author Posted February 12, 2018 @slick_303 yes, git repository is NOT a valid module. You need to build it first, and for that you need nodejs and gulp. I've described how to do it in this dev manual
SLiCK_303 Posted February 12, 2018 Posted February 12, 2018 Thanks for the latest build, thats all I wanted.... :) edit: So I still for the life of me cant get the new options to show up in the BO settings. I've clearred my sites cache, cleared my browsers, ctrl-f5'd the page, nothing....
datakick Posted February 12, 2018 Author Posted February 12, 2018 @slick_303 this option is available only when guest reviews are disabled. Maybe that's the problem...? Edit: also, I've found a bug in the code , so use this version instead
SLiCK_303 Posted February 12, 2018 Posted February 12, 2018 Thanx for the new build! Works like a charm so far. edit: Ok, so, if you do a review as a guest, then it gets approved, then you look at the item you reviewed again, you can edit your review. However once you sign in, then sign out, so you're now a visitor again, and look at that product you reviewed again, you have lost the ability to edit your review. You also now have the ability to write another review.
Generaal Posted February 15, 2018 Posted February 15, 2018 Hello Petr, I have install and configure your module, but I come to the follow things. I have servoral times to click again to approve the written review in FO. On the review in FO, there don't come up some options to give some information on the review, after placed and approved the review. When I tried to delete some reviews in BO, I have to click serval times to change some settings and it's not possible to delete them even. Thanks for the module. Roger
datakick Posted February 15, 2018 Author Posted February 15, 2018 @generaal said in [Free Module]Revws - Product Reviews On the review in FO, there don't come up some options to give some information on the review, after placed and approved the review. Options to vote/report abuse are available only for other visitors, not for review author. Review author see edit/delete review buttons instead. When I tried to delete some reviews in BO, I have to click serval times to change some settings and it's not possible to delete them even. I don't understand what exactly the problem is. Do you mean that the app does nothing when you click on delete button, of on review itself? If so, what browser do you use? Also, it's not possible to permanently delete review, you can only mark it as deleted. I'll add an option to permanently delete them in the future, or even better filter them out of the list. I'm not a big fan of permanent deletion
wakabayashi Posted February 15, 2018 Posted February 15, 2018 @datakick just wanted to let you know, that I am working on loyalty points module. I plan, to share it for free as well. It will offer two hooks which other modules (as your review module) can use. ;) https://forum.thirtybees.com/topic/1505/planned-free-module-loyalty-points
Generaal Posted February 15, 2018 Posted February 15, 2018 Hello Petr, I use Safari as browser, empty the cash, BO and FO. Thanks to explain the option to see some lines in the reviews. The delete option, are no great issue to me, I understood your point of view. The only thing I come back are that when I write a review and click to accept the review, the popup give a negative state. When I reload the page again (browser), the written review come up, strange. I think it have something to do with Zend cache on the server.
datakick Posted February 15, 2018 Author Posted February 15, 2018 @wakabayashi awesome. I assume one of the hooks you've mentioned will be there to discover all available rewardable actions in the system, and the second hook to inform your module that the action actually happened? Or do you have some other mechanism in mind?
datakick Posted February 15, 2018 Author Posted February 15, 2018 @Generaal, do you have debug mode enabled? If so, please turn this fu***g functionality off. It screws everything
wakabayashi Posted February 15, 2018 Posted February 15, 2018 This are the hooks: hookActionRegisterKronaAction hookActionExecuteKronaAction Every external Module is registering the actions they want. You could register for example: $post_review = array( 'module_name' => 'revw', 'action_name' => 'post_review', ); Hook::exec('ActionRegisterKronaAction', $post_review); Now the merchant makes the settings in my module: Defining how many points this action will get. If it can be executed limited times or only once or only 5 times a month. If an user posts a review you call the hookActionExecuteKronaAction: ``` $hook = array( 'modulename' => 'revw', 'actionname' => 'postreview', 'idcustomer' => $this->context->customer->id, 'actionmessage' => '', 'actionurl' => '' ); Hook::exec('ActionExecuteKronaAction', $hook); ``` You only have to deliver 'modulename', 'actionname' and 'idcustomer'. The others are optional, to give an even better user experience. In 'actionurl' you could give the url to the review for example. Is the concept clear to you? I am not super experienced developer, since I am actually more a merchant... But I am getting better from day to day. I hope the concept makes sense to you!?
Generaal Posted February 15, 2018 Posted February 15, 2018 Hmm, I will disable the debug mode and look again if it is disappear! It works!! Thanks for you support, Petr!
MockoB Posted February 15, 2018 Posted February 15, 2018 @wakabayashi is it possible to add functionality once the customer spends X amount on your store to receive award?
datakick Posted February 15, 2018 Author Posted February 15, 2018 @wakabayashi that's good, but I would recommend to refactor the first hook. When should other modules register actions? During their installation? That introduce dependency on module installation order... If user first install revws, and then your krona, they wouldn't be linked. I suggest you reverse it. Instead of registering, use dynamic discovery. So, when user opens config page of your module, your module will trigger hook actionDiscoverKronaAction. Every module in the system that's krona-enabled will be reply with their actions. The code will look like this: $modules = Hook::exec('actionDiscoverKronaAction', [], null, true, false); if ($modules) { foreach ($modules as $key=>$def) { // $def contains actions defined by module with key $key } } I'm actually doing something very similar in my new module mailstream, that will be used for email automation. I'm using this technique to discover review modules in the system.
wakabayashi Posted February 15, 2018 Posted February 15, 2018 @datakick oh thanks for the input. You are right, my system is not perfect designed ;) Your way seems to be very clever. I will try to implement it that way! Do you have idea when your email module will be released? @MockoB I will open another thread next days about my module. What do you mean with award? Basically customer collects points by actions (accountcreation, order, newsletterregistration or many others). Then merchant can define if a customer reaches 1000 points, he will get a coupon. Also non coupon awards are planned. So the merchants can define levels like "Super Ninja" if a customer reaches 5000 points.
wakabayashi Posted February 15, 2018 Posted February 15, 2018 @datakick tested your way to register. Thats brilliant! Thanks a lot.
MockoB Posted February 15, 2018 Posted February 15, 2018 Yes that's fine also, as customer receives notification that he reached "super ninja" level and from now on he falls under "ninja" customer group with permanent discount of 10% for example. And that happens automatically with your module :)
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now