30knees

In the current 1.0.x bleeding edge (this didn't happen before), adding a discount to the order throws the below exception for me. Does this happen to others, too? Stack trace: 1. classes/ObjectModel.php:324 source ObjectModelCore->validateFields() 2. classes/order/Order.php:285 source ObjectModelCore->getFields() 3. classes/ObjectModel.php:755 source OrderCore->getFields() 4. controllers/admin/AdminOrdersController.php:1532 source ObjectModelCore->update() 5. classes/controller/Controller.php:197 source AdminOrdersControllerCore->postProcess() 6. classes/Dispatcher.php:837 source ControllerCore->run() 7. administrator/index.php:63 source DispatcherCore->dispatch() Property Order->total_discounts is not valid in file classes/ObjectModel.php at line 1037 1034: $message = $this->validateField($field, $this->$field); 1035: if ($message !== true) { 1036: if ($die) { 1037: throw new PrestaShopException($message); 1038: } 1039: 1040: return $errorReturn ? $message : false;

I found this in the module's own error log. Perhaps packages aren't always compatible with other setups? Value '3' is not a valid select key: [1, 2, 5] Rule #2: Location: /home/abcde/public_html/modules/conseqs/classes/parameters/select-parameter-definition.php line 50 Stacktrace: #0 /home/abcde/public_html/modules/conseqs/classes/parameter-values.php(96): Conseqs\Parameters\SelectParameterDefinition->convertFromString('3') #1 /home/abcde/public_html/modules/conseqs/actions/create-voucher.php(145): Conseqs\ParameterValues->getValue('params.currency') #2 /home/abcde/public_html/modules/conseqs/classes/rules-manager.php(120): Conseqs\Actions\CreateVoucher->execute(Object(Conseqs\ParameterValues), Object(Conseqs\ParameterValues), Object(Conseqs\ParameterValues), Object(Conseqs\RuntimeModifier)) #3 [internal function]: Conseqs\RulesManager->runRuleInternal(Array, Array, Object(Conseqs\RuntimeModifier)) #4 /home/abcde/public_html/modules/conseqs/classes/error-handler.php(45): call_user_func_array(Array, Array) #5 /home/abcde/public_html/modules/conseqs/classes/rules-manager.php(57): Conseqs\ErrorHandler->handleErrors('Rule #2', Array, Array, Array) #6 /home/abcde/public_html/modules/conseqs/classes/rules-manager.php(330): Conseqs\RulesManager->runRule(Array, Array, Object(Conseqs\RuntimeModifier)) #7 /home/abcde/public_html/modules/conseqs/conseqs.php(355): Conseqs\RulesManager->dispatchHook('hookactionRevws...', Array) #8 /home/abcde/public_html/classes/Hook.php(761): Conseqs->__call('hookactionRevws...', Array) #9 /home/abcde/public_html/classes/Hook.php(469): HookCore::coreCallHook(Object(Conseqs), 'hookactionRevws...', Array) #10 /home/abcde/public_html/classes/Hook.php(288): HookCore::execWithoutCache('actionRevwsRevi...', Array, NULL, false, true, false, NULL) #11 /home/abcde/public_html/modules/revws/classes/notifications.php(152): HookCore::exec('actionRevwsRevi...', Array) #12 [internal function]: Revws\Notifications->processReviewApproved(120, 'visitor', Object(Revws\Settings), Object(Revws\KronaIntegration)) #13 /home/abcde/public_html/modules/revws/classes/notifications.php(77): call_user_func(Array, 120, 'visitor', Object(Revws\Settings), Object(Revws\KronaIntegration)) #14 /home/abcde/public_html/modules/revws/classes/notifications.php(57): Revws\Notifications->process(Object(Revws)) #15 /home/abcde/public_html/modules/revws/controllers/front/api.php(282): Revws\Notifications->closeConnectionAndProcess(Object(Revws)) #16 /home/abcde/public_html/modules/revws/controllers/front/api.php(52): RevwsApiModuleFrontController->reply(NULL, -1, Array) #17 /home/abcde/public_html/modules/revws/controllers/front/api.php(31): RevwsApiModuleFrontController->ajaxProcessCommand() #18 /home/abcde/public_html/classes/controller/Controller.php(208): RevwsApiModuleFrontController->initContent() #19 /home/abcde/public_html/classes/controller/FrontController.php(253): ControllerCore->run() #20 /home/abcde/public_html/classes/Dispatcher.php(837): FrontControllerCore->run() #21 /home/abcde/public_html/index.php(33): DispatcherCore->dispatch() #22 {main}

Is it with all products? Does updating other fields work?

Thanks! I removed the artifact, but I still get the error. This is what I get in the network console for consequences:

Thanks for the update. Pity with servercow. 😞 Support is important. So far I've been lucky with them - I hope it stays like that. Good luck with OpenSRS!

Are there other possibilities I can look at if debug mode is disabled?

Great idea! I wanted to test the voucher for review rule, but I get "Failed to load rule" when I click on it after adding it. Do you have an idea why this might be?

@FactorThank you! Now it works. In the meantime I ran the core updater again. It didn't find anything to change, however. No idea what caused the temporary issue, but thanks for the nudge to check again. 🙂

Ah, really? So they always need to be matched. That's not the case now with all my emails. Then, together with the other answers, it sounds like the best way would be to keep everything very simple, have a text version I then use a WYSIWIG editor to make into a lookalike html email, and use that. Thanks @dynambeeand @Factor!

But isn't that quite a niche thing? I'm not saying it's a bad idea, I'm only mindful of whether it would be a significant attractor.

Maybe, and I could imagine this would help also to show that tb is actively being developed, we could have two demo installations on the website: bleeding edge (with latest update date) and stable.

Generally, I want to use text emails only because then I only have to maintain one set of emails. However, for some emails, like @datakick's great Revws module, I would like to use HTML emails because it's easier for a customer to click on the rating right in the email. I thought I could achieve this by: having the setting "send both html and text" activated deleting the html email templates and leaving only the text email templates, except for those emails that should use HTML This didn't work because then no email was sent. Then I tried to copy the txt content into the html content (so leaving out all the html formatting), but that looked horrible because the email was interpreted as not having any line breaks, etc because of the lack of HTML. 🙂 Does anybody have an idea how to achieve what I am looking for? Otherwise I'll just copy and paste my text into a WYSIWIG email creator and use that.

They show up under Customers>Shopping carts but I can't transform them to orders. Any idea where I can look to troubleshoot?

Hi, I updated to the bleeding edge and now I am unable to manually create an order in the backend. Nothing happens when I click to add the selected products to the cart. Could somebody using the bleeding edge please check whether they can manually create an order? Thanks

Ah, but I see that after the Revws update that shows up as a trigger (I used the wrong terminology when I wrote "record type"). Great integration!

That's great! I don't use push, so I can't tell you, unfortunately.

Those are brilliant actions! So cool, looking forward to implementing. Thank you! p.s. Would "Revws review" as a record type make sense to add (or I just didn't see it)?

No problems, I'm very happy. Fingers crossed they accept you!

You already have experience with Mailcow. You could go with a managed Mailcow https://servercow.de/mailcow#managed or a simple Mailcow: https://servercow.de/mailcow#hosted Support is fantastic. I really like being there. I don't see anything in English, but drop them a note: https://servercow.de/kontakt I'm sure it shouldn't be a problem. Fastmail is indeed another great option. I second @Brent Dacus.

Just a note that this happened again. I have a Paypal paid order that isn't in the shop. Paypal shows order number 123 but the store order number 123 belongs to a manually created order 123. Both orders were placed approximately at the same time. I guess some fluke meeting of orders?

I thought this was reported already but I couldn't find it. When a product or variant is added to an order manually in the backend with a quantity of x, the stock of that product is deducted by 2x. So if 2 is added, then 4 is deducted, etc. This also works in the thirtybees demo.

The VAT exemption module drops VAT based on the billing address only. Can it take the shipping address into consideration, too? Problem: For an EU-located store, a customer can add a (real or fake) billing address in Switzerland, a shipping address in Germany, and then get the order without VAT. This is a problem because in that scenario the customer would actually need to present the invoice to customs when crossing the border from Germany to Switzerland, get the invoice stamped, and send the shop a copy. Otherwise, the shop will be liable for the VAT that wasn't collected. Proposal: If the shipping address is NOT in a country where VAT shouldn't be charged, the order should always include VAT. If a customer presents a stamped invoice the shop can still refund the VAT.

Oh, I see. I'm very curious about the gamification part. Your shop is perfect for it. Ours is food.

Oh, I'd have thought you'd use it in your own shop! 🙂 But yes, the button should be fine.

Would it be easy to have the coins used automatically? I realize things are mostly much more complex on the inside than they seem to be from the outside for a non-coder. But a big fat button should also do the trick. 🙂