Jump to content
thirty bees forum

datakick

Administrators
  • Posts

    2,908
  • Joined

  • Last visited

  • Days Won

    437

Everything posted by datakick

  1. In this case there's no hook available. The only way to disable this functionality is using override. Because this is thirtybees-only functionality, NONE of the existing seo module comes with such override. They don't need to, because ps16 does not have this feature. What that means for merchants? It means that in order to use any of these seo modules, they need to modify them first, and create php override file. Or manually create override file. Or modify core... Now, isn't it easier to simply turn this feature off, and then install module that do this particular thing better?
  2. It's simply not possible to implement feature like this and cover needs of every merchants. The default implementation is pretty solid, and meets the requirements of almost everybody. But then there are few use cases when it doesn't. I know about two already: - multistore / one store per language setup -- if we wanted to support this in the core then it would actually require quite complex configuration page, and that would definitely not make things easier to setup... and no, it's not really possible to resolve this automagically / algorithmically. Some user input is required here - custom canonical links / relations between different products - I remember there was some thread asking about this recently. Somebody wanted to group similar products under one canonical product umbrella to avoid duplicate content penalisation. Again, if we wanted to have this in core, it would require quite an extensive config page And I'm sure there are other scenarios when the default implementation just doesn't work out of the box. But what's worse, it actually blocks merchants from implementing alternative. When you install any seo module, you will get conflicting metadata in html markup, and that can actually hurt from the seo perspective. That's why it's definitely good to have an option to disable this default implementation.
  3. Third party modules, mostly. Since ps16 does not have this, there already exists many modules that implements this functionality, and then some. It makes sense for some merchants to turn the default implementation off, and use this 'advanced module' implementation instead. Anyway, I think it's a good strategy to have features hidden behind a switch (and they already usually are).
  4. I believe @lesley is planning to move away from patreon to some different solution. What exactly is not 'handy for business user' ?
  5. There are multiple commits [ 1 , 2 , 3 ]related to this, you'll need all 3. Then you get this:
  6. The fix for this, including new back office switch, is scheduled for the next release. @Smile there's no need to sponsor individual fixes, especially when they are trivial 🙂 But feel free to join patreon program (if you haven't already), that's always appreciated!
  7. The bug that was causing 500 error code was fixed, so Full Page cache should be usable in the upcoming version. Note that by default every hooks are non-cached, so when you turn it on, you might even experience some slowdown. To get the benefits of FPC, you will need to turn on caching for hooks that *you believe* should be cached. And this is the hard part -- nobody knows if the hook has some side effects other than rendering the output. If it has side effects, turning caching on will break stuff. So you need to be very careful, and test everything.
  8. Tracked here: https://github.com/thirtybees/thirtybees/issues/848
  9. It is a bug, but it's also very specific. You need to have multistore enabled, and distinct set of languages used by each stores. With this configuration, tb will indeed emit alt links for languages used in other stores. This should be fixed. Should thirtybees emit alt link for different store? That's questionable. Probably not, imho. While it would make sense for your specific use case, when you use multistore as a language selector, it would not work in general. Especially when stores have their own products. I also agree that there should be a switch to turn off this feature, and a hook to alter alt links just before they get rendered to the html.
  10. The auto-login functionality exists only in premium version, and it's tied up to email record. Every sent review request email is tracked in database, and it includes private security key needed to perform the auto login. I've tested on my environment, and image aspect ratio is maintained correctly. I've tested with image sizes 150x300 and 300x150, and in both scenarios the result was ok. It's possible that you have modified/outdated revws css, or that some other css is applied to review list as well.
  11. Another free version 1.0.23 released Enhancements Issue 86 - custom placement for review average - you can now position stars/ratings widget anywhere on your product page. For example prominently below product title Issue 97 - added shortcuts from settings page to reviews, import, criteria pages Issue 100 - added configuration option for number of reviews to be displayed on all-reviews / my-reviews page Issue 48 - you can now edit review date from back office Issue 47 - review lists can now be filtered by category and brand. Bugfixes Issue 90 - fix pagination problem that occured on some versions of MariaDB without proper support for SQL_CALC_FOUND_ROWS Issue 96 - fixed overflow problems with long review content Issue 20 - read review link now works in quick view Issue 99 - don't filter reviews on my-reviews page by selected language Tip and tricks Try adding this short snippet somewhere into your smarty template. It will display product reviews associated with category 4 {hook h='displayRevwsReviewList' category=4 }
  12. what do you mean change the classes/tools.php ?
  13. I believe that new core updater module handles database migration as well: https://github.com/thirtybees/coreupdater/blob/e58130881076265a0bc1a
  14. That's correct. It's stupid, isn't it 🙂
  15. migration module does not replace any module, unless it's one of the few known incompatible. It's up to merchant to decide if he wants to upgrade to Thirtybees native module, or keep prestashop version
  16. @Séane it's possible to override module's primary file, so you are in luck. Just create file overrides/modules/blocktopmenu/blocktopmenu.php with content like this: class BlocktopmenuOverride extends Blocktopmenu { protected function generateCategoriesMenu($categories, $isChildren = 0) { // your custom implementation } }
  17. Yes, this is already in 1.0.8. Please keep the issue opened, as traumflug wants to use it to track the original performance problem
  18. I'm just wondering what this has to do with gdpr module...? Anyway, the code is pretty much ok. I would drop $this->need_instance = 1; because it's tells thirtybees to instantiate this module every time it renders Modules page in back office, which can slow it down a bit. But other than that, there's nothing wrong with it. And if you have your skroutz javascript on your order confirmation page, then the module must be installed properly.
  19. The easiest way is to edit Module.php file, and just before the line where it failed add this code: die((new ReflectionClass('Validate'))->getFileName()); Then refresh your front page. Instead of your beautiful thirtybees shop you will see file path to the Validate class. Don't forget to remove this line after 🙂
  20. Also, you can use Override Check module to quickly find all orphaned overrides. This module is available to install in your backoffice
  21. Looks like it is indeed obsolete, and you should be able to remove it. These overrides remnants are, unfortunately, common problem with module upgrades. Another question is why is there an override for sendChangedNotification method. This method only triggers actionOrderEdited hook. By overriding this method this hook is not executed, which might cause problems with other modules integration.
  22. https://github.com/thirtybees/thirtybees/commit/8e89acf9061e88bc106658891c8bd5abb83eeb9c
  23. There's a bug in 1.0.8 regarding saving Conifguration, that's probably it. Since you are using gitupdater, you can try to forward your shop to bleeding edge. It's fixed there
×
×
  • Create New...