zimmer-media Posted March 15, 2018 Posted March 15, 2018 @datakick Thank you for your answer. And I hope you do not misunderstand it. With my request I wanted to contribute to the optimization of the general public. I may not be up to date right now, but my online tools should be. So when I look at the results after testing I wanted to ask if it is possible to change this in the module in general. I had hoped that, for example, there is a possibility in the specifications or by the settings in the module to integrate it directly by css or adapt. For example - if star size 10 then css class revwspaddi10 - if star size 12 then css class revwspaddi12 etc I'm glad it's on your ToDo list. Despite the meanwhile high speed of the internet, the data size of the web pages is included in the calculation. Google, for example, the less amount of data a page the better -> more and more on the mobile devices such as mobile phones and tablets. It's getting harder and harder to keep up with online shops than with a blog website. In terms of page load times etc, this has a total impact. This really great module is not the only thing that appears when looking for a page through customers and search engines. I am not an SEO expert and not a big programmer. Nevertheless, I add another argument: more program code (including inline style) the more I have to add as text on the page. The relationship between code and content is still up to date. This further increases the size of the page (eg in kb), which in turn means that it is rated negative. for example on firefox - with one of my shops without style changes for every star -> inline style => 5 stars -> 5 inline styles -> 40 products with rating 200 inline styles only for the size/star - and plus stroke style
datakick Posted March 19, 2018 Author Posted March 19, 2018 I've just released a new version 1.0.6 - this one get rid of inline styles we have discussed with @zimmer-media. This version introduces breaking change - if you copied front.css file to /themes/<yourtheme>/modules/revws/revws.css and modified it, it will no longer be used. To make changes to CSS, please create file /themes/<yourtheme>/modules/revws/views/templates/front/css-extend.tpl and enter your css changes here. Content of this file will be appended after content of file /modules/revws/views/templates/front/css.tpl. CSS priority rules will make sure definitions in css-extend.tpl file will have priority over default values from css.tpl file. You might have notices that the css file(s) has .tpl extension - that's right, this is normal smarty template, we just generate css instead of html markup. Generated css file is stored in you theme cache directory. Example of how to extend CSS styles - create file css-extend.tpl with following content to have your stars in red color .revws-grade-on path { fill: red; stroke: red; }
SLiCK_303 Posted March 19, 2018 Posted March 19, 2018 @datakick Were you able to reproduce my problems in php 7.x? Also, as you did not make a zip file for your new release, the d/l link on the tb shop is not working.
datakick Posted March 19, 2018 Author Posted March 19, 2018 @SLiCK_303 - I've added zip file to release. Regarding php 7.xx - I couldn't reproduce this issue. Everything seems to be working ok on my 7.0.11. What version exactly do you have?
SLiCK_303 Posted March 19, 2018 Posted March 19, 2018 It's working like a charm, thanx for the update. It still doesn't let you pick your name in modules, and have the module show up, that sure would be nice if that worked.
datakick Posted March 19, 2018 Author Posted March 19, 2018 @SLiCK_303 I may have found the problem with smarty cache. Could you please try it on your end to verify it's working - simply change line ~326 in revws.php from return $this->display(__FILE__, 'product_list.tpl'); to return $this->display(__FILE__, 'product_list.tpl', $this->getCacheId() . '|' . $productId); Then clear cache. Let me know if that helped
SLiCK_303 Posted March 19, 2018 Posted March 19, 2018 The problem worked itself out I guess, it actually seems to be working as is.... do you still want me to change that?
datakick Posted March 19, 2018 Author Posted March 19, 2018 @slick_303 I didn't have smarty cache enabled before. When I enabled it, it started doing exactly the same weird behaviour you've reported before. With the fix it seems to be working.
zimmer-media Posted March 19, 2018 Posted March 19, 2018 @datakick you´re great, many thanks for this update, it looks very fine - i hope other seller with this module have now more fun cool with change star color etc
Pedalman Posted March 19, 2018 Posted March 19, 2018 I vote for screen shots of user having fun to show us their way of implementing it. May be someone creates a style that differs totally of what we are used too. The module is working now and I like it very very much. Such a good time this year! So many superb modules at our hands now by so generous and capable developers that I am happy to forget all the troubles I had with Prestashop over years. Thank you very much Petr PS: I am happily willing to learn as fast as possible to make use of your main module Datakick now. I am sure it is going to be of great help to me to hone my shop user EX and SEO wise.
Troy.Roberts Posted March 21, 2018 Posted March 21, 2018 This might be a stupid question, but where do i go to approve product comments? Also i'm having an issue where the review frame doesn't pop up to allow a user to review. What might be wrong? (running 1.0.6)
SLiCK_303 Posted March 21, 2018 Posted March 21, 2018 @Troy-Roberts You goto BO>Catalog>Product reviews to approve reviews. The second issue, what theme do you use?
SLiCK_303 Posted March 21, 2018 Posted March 21, 2018 Do you see part of the review frame? Or do you just see nothing? Are you logged in?
Troy.Roberts Posted March 21, 2018 Posted March 21, 2018 @slick_303 Logged in user, when i click the link, the page just sort of "pops" to the top of the page and does nothing. Also don't get the review alert e-mails, presume it's because i'm hosting on cloudways and don't have access to php(mail)
SLiCK_303 Posted March 21, 2018 Posted March 21, 2018 So you see it, but can't change the stars, or anything else?
SLiCK_303 Posted March 21, 2018 Posted March 21, 2018 I'm not sure why the top link is just jumping to the top of the page, instead of bringing up the review popup. I'm also not sure why the module is not sending emails. Hopefully @datakick has some ideas for you.
datakick Posted March 21, 2018 Author Posted March 21, 2018 @Troy-Roberts if the popup does not show, there's probably some javascript error. Could you send me url of your shop so I can have a look? Regarding emails - do you have email templates translated to your language(s)?
datakick Posted March 21, 2018 Author Posted March 21, 2018 I've released new version 1.0.7 - this is a bugfix - I've forgot to include txt email templates to previous module builds. This resulted in not sending emails.
Troy.Roberts Posted March 21, 2018 Posted March 21, 2018 @SLiCK_303 and @datakick Thanks for your help guys, you both rock.
SLiCK_303 Posted March 21, 2018 Posted March 21, 2018 @Troy-Roberts np, glad I could help, wish I could have more. @datakick I noticed I can now get to your module by your name, thanks for that.
datakick Posted March 22, 2018 Author Posted March 22, 2018 Since I have a little bit of a free time this week, I decided to implement another feature to this module. Since version 1.0.8 you can change star color from settings page.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now