Jump to content

Welcome, Guest!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Traumflug

thirty bees 1.1.0 Preview

Recommended Posts

Great thanks. Is this a Release Candidate? Is there formal testers and testing cycles?

Share this post


Link to post
Share on other sites
Posted (edited)

Thanks, I'll install this on a test server post-haste.  BTW, I've been trying to do this for the past couple days anyways, pulling things off git, with no success.  Hopefully this will install, as my attempts it would not.  I'm excited to see the new theme, niara.....

edit: Installed fine. Getting into BO>Modules and Services seems to be taking a long time, sometimes.

Edited by SLiCK_303

Share this post


Link to post
Share on other sites

@Traumflug can you please expose Niara theme repository.

Installation went smooth (only tested RTL).

RTL css need some modification.

Share this post


Link to post
Share on other sites
Posted (edited)

one-page checkout is not working/throwing an error for me...

Capture.PNG

Edited by SLiCK_303

Share this post


Link to post
Share on other sites

I have found the cause of it.

order-carrier.tpl lines 62-67. for some reason lines 65-67 popped out of the foreach loop.

```

{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
{/foreach}
{if isset($carrier.instance->delay[$cookie->id_lang])}
  <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
{/if}

```

Should be:

```

{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
  {if isset($carrier.instance->delay[$cookie->id_lang])}
    <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
  {/if}
{/foreach}
```

Share this post


Link to post
Share on other sites
10 hours ago, yaniv14 said:

I have found the cause of it.

order-carrier.tpl lines 62-67. for some reason lines 65-67 popped out of the foreach loop.

```


{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
{/foreach}
{if isset($carrier.instance->delay[$cookie->id_lang])}
  <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
{/if}

```

Should be:

```


{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
  {if isset($carrier.instance->delay[$cookie->id_lang])}
    <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
  {/if}
{/foreach}
```

With new version of tb there comes new version of smarty, which changes how things works sometimes.

In old version of smarty, $carrier variable would hold value of last item after the {foreach} cycle has ended. So the original template code worked, but it just Delivery time for the last carrier in the list only.

New version of smarty works the same, *unless* $carrier variable is defined before the {foreach} cycle starts. If $carrier variable already existed in global scope, then after {foreach} cycle ends, the original value is recovered. 

With this changed semantics the template no longer works. I'm not sure what the intention of this code in this template was. But it looks very likely that @yaniv14 is right, and that author really meant to do show delivery time for all carries. 

So to fix this particular case, we can

  1. use yaniv's proposed fix - this would change template output, but that's probably correct 
  2. rename iteration variable from $carrier to something else. This would keep the template output the same

I vote for #1

 

 

 

Share this post


Link to post
Share on other sites

Since a couple of people are already testing the release, can you test a new functional module that I just made public that will be in the release. 

Here is the module, https://github.com/thirtybees/thememanager/releases/tag/1.0.2 

It only works if you are using both the Niara theme and the 1.1.0 release candidate. 

What the module does is add a new tab to the back office product pages, as seen in the screenshot below. 

image.thumb.png.00fb27682eddc051025d6ef560649b44.png

 

Right now there is only one other template, it is the product wide template. It requires you to add a new image type, that will be added in the installer on the final release. But make sure you add a new image type called product_wide that is 400px tall and 1200px wide. 

 

Over the next day or two I am going to add more template files to the theme. The module is set to work on category pages, cms pages, and product pages. So you can create different look and feels on a per page level. I really think this will open up a lot of new possibilities for themes in thirty bees. 

 

  • Like 3

Share this post


Link to post
Share on other sites

I was able to install, add modules, work in the BO and FO.  I haven't install the current theme I am using but will try that soon. no issues so far.

Share this post


Link to post
Share on other sites

Installation, adding modules in BO and FO has worked well on our tests.

Re: new template manager module:-

"added a new image type called product_wide that is 400px tall and 1200px wide."

Our results uploaded.

2019-06-25 18_09_23-Soap.jpg

2019-06-25 18_16_58-Candle.jpg

2019-06-25 18_29_15-Images • settings.jpg

Share this post


Link to post
Share on other sites

Installed onto my new CentOS7 server and the system seems to work well. Webservice working as with earlier versions. My custom modules also seem to work without any issues.

Found a couple of minor design issues:

  • Front office create new account, "Mr. & Mrs." options are not aligned
     
  • On page 4 of checkout can't click on the small circles to select the carrier. Must click on the carrier description. Should be able to click on both, and ideally those little circles should be a bit bigger as many customers will try to click on them (as I did, and thought I couldn't choose the carrier at all.)

I'll keep testing things out over the coming days and see what comes up.

Share this post


Link to post
Share on other sites

@Signut did you like the whole idea behind that module? I am going to release a few more templates to the repo sometime today. 

Share this post


Link to post
Share on other sites

@yaniv14 It should be, I will defer to @Traumflug for that, I have never done that. I know over the next day or two I will be adding some new templates for the theme and modules that will need to be translated, so it might make sense after that to do it. I am not sure how that works. 

Share this post


Link to post
Share on other sites
8 hours ago, dynambee said:

Found a couple of minor design issues:

  • Front office create new account, "Mr. & Mrs." options are not aligned
     
  • On page 4 of checkout can't click on the small circles to select the carrier. Must click on the carrier description. Should be able to click on both, and ideally those little circles should be a bit bigger as many customers will try to click on them (as I did, and thought I couldn't choose the carrier at all.)

I created git issues for both of these....

  • Like 1

Share this post


Link to post
Share on other sites

Thanks @SLiCK_303 and @lesley, I will test out the fixes later today my local time.

I have found a couple of other issues with the carriers page in the checkout as well, and have opened a git issue about them.

In short though, the "delivery time" is not displayed correctly for each carrier. The delivery time for the first carrier is displayed for all carriers.

The second issue is that the price column doesn't align properly.

Here are the same images that I posted in the git issue:

image.thumb.png.b99b5bc751f53fccfc9a3a8a1d3fb20b.png

 

image.thumb.png.dd55fd941b8a8c29b998ad6405907278.png

 

 

A big thank you to the dev team for all the hard work that has gone into this release. It's looking really good!

 

 

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×