Jump to content
thirty bees forum

thirty bees 1.1.0 Preview

Traumflug
 Share

Recommended Posts

SLiCK_303 Contributor

SLiCK_303

Posted
Posted (edited)

Thanks, I'll install this on a test server post-haste.  BTW, I've been trying to do this for the past couple days anyways, pulling things off git, with no success.  Hopefully this will install, as my attempts it would not.  I'm excited to see the new theme, niara.....

edit: Installed fine. Getting into BO>Modules and Services seems to be taking a long time, sometimes.

Edited by SLiCK_303
Link to comment
Share on other sites
yaniv14 Rookie

yaniv14

Posted
Posted

I have found the cause of it.

order-carrier.tpl lines 62-67. for some reason lines 65-67 popped out of the foreach loop.

``` 

{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
{/foreach}
{if isset($carrier.instance->delay[$cookie->id_lang])}
  <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
{/if}

```

Should be:

``` 

{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
  {if isset($carrier.instance->delay[$cookie->id_lang])}
    <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
  {/if}
{/foreach}
```
Link to comment
Share on other sites
datakick Experienced

datakick

Posted
Posted
10 hours ago, yaniv14 said:

I have found the cause of it.

order-carrier.tpl lines 62-67. for some reason lines 65-67 popped out of the foreach loop.

``` 


{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
{/foreach}
{if isset($carrier.instance->delay[$cookie->id_lang])}
  <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
{/if}

```

Should be:

``` 


{foreach $option.carrier_list as $carrier}
  <strong>{$carrier.instance->name|escape:'htmlall':'UTF-8'}</strong>
  {if isset($carrier.instance->delay[$cookie->id_lang])}
    <br>{l s='Delivery time:'}&nbsp;{$carrier.instance->delay[$cookie->id_lang]|escape:'htmlall':'UTF-8'}
  {/if}
{/foreach}
```

With new version of tb there comes new version of smarty, which changes how things works sometimes.

In old version of smarty, $carrier variable would hold value of last item after the {foreach} cycle has ended. So the original template code worked, but it just Delivery time for the last carrier in the list only.

New version of smarty works the same, *unless* $carrier variable is defined before the {foreach} cycle starts. If $carrier variable already existed in global scope, then after {foreach} cycle ends, the original value is recovered. 

With this changed semantics the template no longer works. I'm not sure what the intention of this code in this template was. But it looks very likely that @yaniv14 is right, and that author really meant to do show delivery time for all carries. 

So to fix this particular case, we can

  1. use yaniv's proposed fix - this would change template output, but that's probably correct 
  2. rename iteration variable from $carrier to something else. This would keep the template output the same

I vote for #1

 

 

 

Link to comment
Share on other sites
lesley Newbie

lesley

Posted
Posted

Since a couple of people are already testing the release, can you test a new functional module that I just made public that will be in the release. 

Here is the module, https://github.com/thirtybees/thememanager/releases/tag/1.0.2 

It only works if you are using both the Niara theme and the 1.1.0 release candidate. 

What the module does is add a new tab to the back office product pages, as seen in the screenshot below. 

image.thumb.png.00fb27682eddc051025d6ef560649b44.png

 

Right now there is only one other template, it is the product wide template. It requires you to add a new image type, that will be added in the installer on the final release. But make sure you add a new image type called product_wide that is 400px tall and 1200px wide. 

 

Over the next day or two I am going to add more template files to the theme. The module is set to work on category pages, cms pages, and product pages. So you can create different look and feels on a per page level. I really think this will open up a lot of new possibilities for themes in thirty bees. 

 

  • Like 3
Link to comment
Share on other sites
dynambee Newbie

dynambee

Posted
Posted

Installed onto my new CentOS7 server and the system seems to work well. Webservice working as with earlier versions. My custom modules also seem to work without any issues.

Found a couple of minor design issues:

  • Front office create new account, "Mr. & Mrs." options are not aligned
     
  • On page 4 of checkout can't click on the small circles to select the carrier. Must click on the carrier description. Should be able to click on both, and ideally those little circles should be a bit bigger as many customers will try to click on them (as I did, and thought I couldn't choose the carrier at all.)

I'll keep testing things out over the coming days and see what comes up.

Link to comment
Share on other sites
SLiCK_303 Contributor

SLiCK_303

Posted
Posted
8 hours ago, dynambee said:

Found a couple of minor design issues:

  • Front office create new account, "Mr. & Mrs." options are not aligned
     
  • On page 4 of checkout can't click on the small circles to select the carrier. Must click on the carrier description. Should be able to click on both, and ideally those little circles should be a bit bigger as many customers will try to click on them (as I did, and thought I couldn't choose the carrier at all.)

I created git issues for both of these....

  • Like 1
Link to comment
Share on other sites
dynambee Newbie

dynambee

Posted
Posted

Thanks @SLiCK_303 and @lesley, I will test out the fixes later today my local time.

I have found a couple of other issues with the carriers page in the checkout as well, and have opened a git issue about them.

In short though, the "delivery time" is not displayed correctly for each carrier. The delivery time for the first carrier is displayed for all carriers.

The second issue is that the price column doesn't align properly.

Here are the same images that I posted in the git issue:

image.thumb.png.b99b5bc751f53fccfc9a3a8a1d3fb20b.png

 

image.thumb.png.dd55fd941b8a8c29b998ad6405907278.png

 

 

A big thank you to the dev team for all the hard work that has gone into this release. It's looking really good!

 

 

  • Like 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...