-
Posts
3,035 -
Joined
-
Last visited
-
Days Won
465
Content Type
Profiles
Forums
Gallery
Downloads
Articles
Store
Blogs
Everything posted by datakick
-
It would. There's actually a bughancement request for this https://github.com/thirtybees/thirtybees/issues/1024 already
- 1 reply
-
- 1
-
thirty bees 1.1.1 - pre-release bug hunt
datakick replied to datakick's topic in Announcements about thirty bees
do you mean media servers? -
Hello everyone, it's been a while since the release 1.1.0, and it's time for another one. Version 1.1.1 should be released by the end of November. This new version is all about code quality -- there aren't many new enhancement or dazzling features. Instead, a lot of bugs and errors were fixed. For more information about this release, you can read here. Right now, I would like to ask you all for cooperation with pre-release testing and bug huntint. If you can, please use core updater to forward your store to latest bleeding edge 1.1.x, and test your store properly. If you find any bug, please report it to github. If the bug is an newly introduced problem, or if it's a seriousone, we'll try to fix it before the official release. Other bugs will be tracked and fixed in the next version(s). Thanks in advance for helping this project!
-
Looks ok. Anyway, this settings is for FPC. I don't think you have it enabled
-
No, not yet
-
That is a good question. I have encountered this behaviour a few times already. - there used to be an exception for hookBackOfficeHeader -- this hook was intentionally called for every module, even disabled one. This was fixed in 1.0.8. I never really understood why this was enabled in the first place -- my suspicion is that ps guys implemented this 'feature' for their onboarding/tracking module - even if the module is disabled, it is sometimes instantiated. This means that module __construct method is called by php runtime (and also the module file is loaded, which provides another opportunity for code execution). If module constructor contains some side-effect code, anything can happen. There are multiple reasons why (even disabled) modules are instantiated. Some of them can be fixed, like this one. - overrides -- when you disable module, all its overrides stay put, and continue to be executed. It's up to module developer to check whether the module is enabled/installed or not. This is obviously a bug.
-
HookCategoryUpdate seem not be call when changing product to non defaut category
datakick replied to Pierrox15's question in Technical help
hookActionXXXUpdate is called when object model properties are changed. So, when you save Product from your back office then hookActionProductUpdate is called. Unfortunately, at this point, only product properties has been saved to database. Category associations weren't saved yet, because they are not property of an object. Controlelr will save them a littile bit little bit later. That means your Product::getProductCategories(intval($id_product)) is probably retrieving old set of categories -
Google analytics module is for tracking - it adds google tracking code to your pages. Google Analytics API is for retrieving collected infromation from google servers back to your store. Without this module, the dashboard will still show zero
-
If you are trying to use value 7100640000 as a product primary key then the mysql will probably complain - id_product column is defined as unsigned int, which can store max value = 4294967295
-
That's not an error. This dashboard shows data fetched from your google analytics account -- for this to work, you need to install and configure Google Analytics API module.
-
The thing about multistore configuration is that there exists multiple layers of configuration. for specific shop for shop group for all shops When some configuration key is not found for specific shop, it will fall-back to more generic settings. In your case, you have configuration on All Shops level set up the same as for your shop B, and (some) configuration key for specific shop A weren't set up correctly. So, thirtybees merged these settings, and resulting mix was not valid stmp configuration. The same probably happens with logo
-
Are you asking when the next release will be? Probably by the end of this month
-
Banküberweisung Zeilenumbruch
datakick replied to RabbitZzZ's topic in Deutsches Forum - Generelle Fragen
Then you have some override installed, or modified core code. There is actually a test that verifies behavior of this method, and it runs on every git commit. -
Banküberweisung Zeilenumbruch
datakick replied to RabbitZzZ's topic in Deutsches Forum - Generelle Fragen
Let's fix this newly discovered bug, where we are at this topic: https://github.com/thirtybees/bankwire/commit/51e3afb916fdc83111628ca04de254dbbc0a2674 -
Banküberweisung Zeilenumbruch
datakick replied to RabbitZzZ's topic in Deutsches Forum - Generelle Fragen
No, it's not. I've just tested it. I tried to save this string: Hello <strong>there</strong> With false, it's saved as Hello there With true, it's saved correctly: Hello <strong>there</strong> Note that you have to re-load the page, because this module (like most of them) shows last $POSTed value, instead of what was actually saved into db. That can be, of course, considered as another bug. This is probably why you thought it is always called with `true` parameter. -
Banküberweisung Zeilenumbruch
datakick replied to RabbitZzZ's topic in Deutsches Forum - Generelle Fragen
That's true. If we were to remove the else branch, then Configuration::updateValue($key, $value) call would not remove html tags from values stored into configuration table. And that would be a HUGE security bug. In other words -- if programmer wants to store html code, he need to be very explicit about it. He must evaluate the context in which data are provided, and decide if it's safe to allow html code to enter the system or not. He needs to know where the data will go, and how it will impact rendered output of these pages. -
Thanks @Jonny for the module. This is excellent support! I see that the modification of core Dispatcher class is needed for this to work properly. This actually points to a bug in the core. It assumes that controller with name 'category' is always core CategoryController, while in fact it can be controller in any module named 'category'. The same applies for other core controllers as well. This will be fixed in upcoming version of thirtybees.
-
Yeah, you are right. It still doesn't work. They use flock to lock the file, but it's not enough. Probably one of these kicked in (from php documentation): You should report this bug once again. And while you are at it, tell them to remove this 'cache' functionality completely. The extendCache method tries very hard to create var/paygreen/autoload.cache.php cache file. But they don't actually use this file at all - the module reads it in constructor into property $classNames, but this variable is never used for anything. This means that if we modify the file and delete: property $classNames constructor extendCache method and the call $this->extendCache we will end up with much smaller, faster code doing exactly the same. But without this race-condition bug. I'm attaching modified file, please pass it to the dev of the module when you report this issue. Autoloader.php
-
Yes, this is now in bleeding edge, and the maxmindgeoip2 module has been released as well. You can install it even in 1.1.0 and prior, but it will have no effect